I submitted a pull request with a few shell scripts that can be used for tasks including automation of bisects for ICE regressions in https://github.com/rust-lang/cargo-bisect-rustc/pull/47. If these are acceptable upstream, I'd be happy to add documentation to the tutorial as part of the PR. They are very straightforward at the moment and @Marcel Hellwig recommended a change in approach for one of the scripts that I'd be happy to implement. Please let me know if there is anything else that you need to review the PR.
I think it would be great if we can add a lot of things like the ones you've added but as subcommands of the executable
anyway, meanwhile we don't have that I guess we could apply this
I would definitely be interested in helping to work on this in the Rust source but am likely to need some assistance at this stage
let's see what Mark says but I'd be happy to help where possible
I don't have time to manage/guide this, but I think adding the scripts either as they are in scripts/ or subcommands is fine
@simulacrum yeah I just wanted you to chime in favor of the scripts or to build the thing as a subcommand
but yeah as I was saying we can start placing those scripts there and then implement the ideas inside the tool
That sounds good. Let me know if there is anything else that you want to see on the PR for the scripts.
I took a look at the Rust sources last night and will start looking into builtin approaches with new subcommands. Let me get my bearings on the project and then I will have more informed questions about how to approach this. I'll do my best to come prepared so that this isn't onerous :slight_smile: It's a great opportunity for me to learn more about Rust and I really look forward to it. Please let me know if you have any ideas about subcommand functionality that is not on the issue tracker.
I don't have any particular idea
I think subcommand is better
Particularly because scripts directory is not going to be readily available if we installed from cargo
It sounds like @pnkfelix intends to add support for the subcommands in the tool. We are discussing this on https://github.com/rust-lang/cargo-bisect-rustc/issues/34
(added command line parameters to catch ICE's and other variants in cargo-bisect-rustc#53)
@Chris Simpkins maybe you might like to be part of the review of PR #53 ?
(I in turn can maybe allocate some time to look at the PR's you posted...)
Sounds great @pnkfelix. I will have a look tomorrow. Look forward to these changes!
It looks like your PR was already merged @pnkfelix I will catch up on the changes that you made. I was working on a refactor of the source in main into a library so that we can add tests. I will rebase that work on your changes if they are implemented in the main.rs module.