Stream: t-compiler/cargo-bisect-rustc

Topic: unrecognized option json


Santiago Pastorino (Jun 10 2020 at 16:33, on Zulip):

I'm getting...

Santiago Pastorino (Jun 10 2020 at 16:33, on Zulip):
   Compiling myapp v0.1.0 (/tmp/myapp)
error: Unrecognized option: 'json'

error: could not compile `myapp`.

To learn more, run the command again with --verbose.
Santiago Pastorino (Jun 10 2020 at 16:33, on Zulip):

when trying to cargo bisect rustc using old dates

Santiago Pastorino (Jun 10 2020 at 16:33, on Zulip):

I thought it was related with the edition but I've removed the edition from Cargo.toml and still getting this issue

Santiago Pastorino (Jun 10 2020 at 16:37, on Zulip):

I've seen that I need to use --script for these cases

Santiago Pastorino (Jun 10 2020 at 16:40, on Zulip):

now I wonder how to correctly use script

Santiago Pastorino (Jun 10 2020 at 16:40, on Zulip):

cc @LeSeulArtichaut @Chris Simpkins

Eric Huss (Jun 10 2020 at 16:41, on Zulip):

I think you need to use --with-cargo for older releases.

Santiago Pastorino (Jun 10 2020 at 16:41, on Zulip):

Eric Huss said:

I think you need to use --with-cargo for older releases.

with-cargo where?

Eric Huss (Jun 10 2020 at 16:41, on Zulip):

cargo-bisect-rustc --with-cargo …

Santiago Pastorino (Jun 10 2020 at 16:42, on Zulip):

ahh

Santiago Pastorino (Jun 10 2020 at 16:42, on Zulip):

right

Chris Simpkins (Jun 10 2020 at 16:44, on Zulip):

believe that this starts to occur prior to ~ Jul 2019

Chris Simpkins (Jun 10 2020 at 16:46, on Zulip):

I haven’t tried the —with-cargo option. Good to hear that there is a workaround! :slight_smile:

Vadim Petrochenkov (Jun 10 2020 at 22:01, on Zulip):

https://github.com/rust-lang/cargo-bisect-rustc/issues/81

Chris Simpkins (Jun 11 2020 at 02:55, on Zulip):

Vadim Petrochenkov said:

https://github.com/rust-lang/cargo-bisect-rustc/issues/81

Is there a reason why this is not the default? I've run into this problem on a number of occasions too

Santiago Pastorino (Jun 11 2020 at 13:43, on Zulip):

I'd make it a default but about the reason unsure, cc @simulacrum

simulacrum (Jun 11 2020 at 13:55, on Zulip):

faster to not do it. we should probably make it the default though.

Santiago Pastorino (Jun 11 2020 at 13:57, on Zulip):

maybe the best is to check the date and figure out if you would need it or not

simulacrum (Jun 11 2020 at 13:57, on Zulip):

I'd just always do it.

Santiago Pastorino (Jun 11 2020 at 13:57, on Zulip):

:+1:

Chris Simpkins (Jun 12 2020 at 13:49, on Zulip):

simulacrum said:

I'd just always do it.

Will have a look this weekend.

Chris Simpkins (Jun 13 2020 at 02:15, on Zulip):

@Santiago Pastorino I changed the default approach to use installed nightly cargo by default. Can you point me to the source and bisect-rustc command that you used in your original post in this thread so that I can test it?

Chris Simpkins (Jun 13 2020 at 02:31, on Zulip):

https://github.com/rust-lang/cargo-bisect-rustc/pull/98

Chris Simpkins (Jun 15 2020 at 18:02, on Zulip):

@simulacrum @pnkfelix @Santiago Pastorino thoughts?

Santiago please let me know what source you were working with here and I will confirm that this works

simulacrum (Jun 15 2020 at 18:02, on Zulip):

hm I think I would just download cargo always (perhaps have an explicit override but no more than that). realistically nightly cargo isn't necessarily going to work with old master commits either, seems like it's probably just replacing one problem with another

simulacrum (Jun 15 2020 at 18:03, on Zulip):

oh I see that's what your PR already does, I misinterpreted "nightly cargo"

simulacrum (Jun 15 2020 at 18:03, on Zulip):

yeah seems fine though I didn't look at the code too closely

Chris Simpkins (Jun 15 2020 at 18:10, on Zulip):

:+1:

Santiago Pastorino (Jun 15 2020 at 19:53, on Zulip):

Chris Simpkins said:

simulacrum pnkfelix Santiago Pastorino thoughts?

Santiago please let me know what source you were working with here and I will confirm that this works

I don't remember anymore what I was testing exactly

Santiago Pastorino (Jun 15 2020 at 19:54, on Zulip):

but I guess if you try an start date that is old enough you will hit this issue

Chris Simpkins (Jul 04 2020 at 17:21, on Zulip):

added the --without-cargo option in PR https://github.com/rust-lang/cargo-bisect-rustc/pull/98. If you know of an old ICE that we can use to test, please let me know

Santiago Pastorino (Jul 06 2020 at 13:09, on Zulip):

@Chris Simpkins merged!, feel free to release a new version

Chris Simpkins (Jul 06 2020 at 13:14, on Zulip):

@Santiago Pastorino Ty. It still needs to be tested. I need to find source for an old ICE to make sure that this addresses the issue.

Santiago Pastorino (Jul 06 2020 at 13:18, on Zulip):

:+1:

Chris Simpkins (Jul 06 2020 at 13:33, on Zulip):

Santiago Pastorino said:

:+1:

Will push a new release as soon as this is verified. There is a date fix in master that is worth getting out too.

Last update: Nov 25 2020 at 03:00UTC