Stream: t-compiler/cargo-bisect-rustc

Topic: Searched date range misreported #82


Santiago Pastorino (May 07 2020 at 16:16, on Zulip):

@bjorn3 I believe cargo-bisect-rustc#83 should fix the issue you've reported

Santiago Pastorino (May 07 2020 at 16:17, on Zulip):

didn't have time to properly test it, if you or someone can test it please go ahead, otherwise I'll try to properly test later

bjorn3 (May 07 2020 at 16:39, on Zulip):

I can probably try Saturday. Can you please @ mention me at the PR, so that the gh notification acts as a reminder for me?

Santiago Pastorino (May 07 2020 at 17:34, on Zulip):

done

bjorn3 (May 07 2020 at 17:34, on Zulip):

Thanks

Chris Simpkins (May 08 2020 at 13:26, on Zulip):

@bjorn3 if Santiago's changes address this, please let me know and we will push the fix with other changes that are in master over the weekend.

bjorn3 (May 08 2020 at 14:28, on Zulip):

Sure

Santiago Pastorino (May 11 2020 at 15:45, on Zulip):

@bjorn3 just pushed a different fix for this one

Santiago Pastorino (May 11 2020 at 15:45, on Zulip):

https://github.com/rust-lang/cargo-bisect-rustc/pull/83

Santiago Pastorino (May 11 2020 at 15:45, on Zulip):

it's a tiny bit ugly

Santiago Pastorino (May 11 2020 at 15:45, on Zulip):

let me know how can I test exactly what you're testing

bjorn3 (May 11 2020 at 17:09, on Zulip):

Just pushed a commit to cargo-bisect-rustc-bot-jobs to test it: https://github.com/bjorn3/cargo-bisect-rustc-bot-jobs/runs/664142625

bjorn3 (May 11 2020 at 17:18, on Zulip):

searched toolchains nightly-2020-04-25 through nightly-2020-04-25
[...]
Regression in nightly-2020-04-08

Santiago Pastorino (May 11 2020 at 18:26, on Zulip):

@bjorn3 ouch this is another issue and I see what that is, if it's easy for you to lunch tests I may keep asking you to try otherwise if you can show me how to reproduce this would be nice too :)

Santiago Pastorino (May 11 2020 at 18:48, on Zulip):

@bjorn3 pushed another attempt to fix it, test it again or let me know a way of testing this

Santiago Pastorino (May 11 2020 at 19:49, on Zulip):

this latest fix works, just tested your repo and reported back on the issue

Santiago Pastorino (May 12 2020 at 14:58, on Zulip):

@Chris Simpkins you around?

Santiago Pastorino (May 12 2020 at 14:58, on Zulip):

we clearly need a test suite here :joy:

Santiago Pastorino (May 12 2020 at 15:37, on Zulip):

anyway, I've addressed the new problems

Chris Simpkins (May 12 2020 at 15:55, on Zulip):

Yep! I am here. Definitely agree with the test suite issue and commented on your PR thread. I am up for diving in on a refactor with test coverage in mind. Problem on my end is time for a significant refactor right now

Chris Simpkins (May 12 2020 at 15:56, on Zulip):

@pnkfelix mentioned that he began work on testing and IIRC this is in a branch of his fork of the repository. Perhaps we can begin there and see what direction he is heading with this? If you'd like to get together to run through how to refactor with other SH's in the project, count me in.

Santiago Pastorino (May 12 2020 at 15:57, on Zulip):

yeah same happens to me, the main problem is finding time :)

Santiago Pastorino (May 12 2020 at 15:58, on Zulip):

but :+1: on what you've said

Chris Simpkins (May 12 2020 at 16:06, on Zulip):

Posted this in the "Testing" thread: https://rust-lang.zulipchat.com/#narrow/stream/217417-t-compiler.2Fcargo-bisect-rustc/topic/Testing/near/197299207

Santiago Pastorino (May 12 2020 at 16:08, on Zulip):

I think the PR should be ready to be merged now

Santiago Pastorino (May 12 2020 at 16:10, on Zulip):

@Chris Simpkins given that there are a bunch of "unrelated" things in the PR, I'd recommend reviewing commit by commit

Chris Simpkins (May 12 2020 at 16:14, on Zulip):

Will take a look this evening.

@bjorn3 any concerns about merging Santiago's work to address your bisect-rustc issue? It looks like this is sorted out and should be fixed as of his latest commit. We are having a more general conversation about how to approach the reporting and it would be useful to hear from you what elements in the report are useful/required for your GH Actions based tool. Separate issue, but please let us know if there is a way to better support your approach.

bjorn3 (May 12 2020 at 16:28, on Zulip):

@Chris Simpkins Merging is fine.

bjorn3 (May 12 2020 at 16:28, on Zulip):

The main problem with my bot right now is that github doesn't allow me to access github actions logs using a personal access token. I think the documentation implies that you have to create a github app to access it.

Chris Simpkins (May 13 2020 at 13:33, on Zulip):

This fix was merged. We will push a release this week.

Last update: Jun 05 2020 at 23:20UTC