Stream: t-compiler/cargo-bisect-rustc

Topic: expand error handling


Santiago Pastorino (Apr 07 2020 at 20:31, on Zulip):

hey @Chris Simpkins I guess I've failed to help you with https://github.com/rust-lang/cargo-bisect-rustc/pull/58

Santiago Pastorino (Apr 07 2020 at 20:31, on Zulip):

the problem I have is that I'm not really familiar with the code base

Santiago Pastorino (Apr 07 2020 at 20:31, on Zulip):

I meant, it's not hard to figure out but ...

Santiago Pastorino (Apr 07 2020 at 20:31, on Zulip):

can you describe exactly what are you trying to accomplish?

Santiago Pastorino (Apr 07 2020 at 20:32, on Zulip):

oh sorry, after reading a bit more I see what you were after

Santiago Pastorino (Apr 07 2020 at 20:33, on Zulip):

I think your idea makes sense

Santiago Pastorino (Apr 07 2020 at 20:33, on Zulip):

unsure if you want to reopen it and push it over the finish line

Santiago Pastorino (Apr 07 2020 at 20:33, on Zulip):

let me know how can I help in that case

Chris Simpkins (Apr 07 2020 at 20:33, on Zulip):

No worries! I think that it would have required a fairly significant refactor anyways. Felix added a big update after that was posted and it is likely easier to just return to it rebased on the current master branch. It is just error handling. There are lots of spots that raise panics and I think that we can provide error handling instead

Santiago Pastorino (Apr 07 2020 at 20:34, on Zulip):

yeah saw that

Santiago Pastorino (Apr 07 2020 at 20:34, on Zulip):

agree :+1:

Chris Simpkins (Apr 07 2020 at 20:35, on Zulip):

I'll have a look at it again at some point and we can see if it makes sense to add it. I think that it is higher priority to get tests added

Last update: Nov 25 2020 at 02:15UTC