Stream: t-compiler/cargo-bisect-rustc

Topic: Release v0.4.1


Chris Simpkins (Apr 06 2020 at 16:58, on Zulip):

@Santiago Pastorino Willing to push a release as soon as we sort out https://github.com/rust-lang/cargo-bisect-rustc/pull/73? This will include the bug fix from https://github.com/rust-lang/cargo-bisect-rustc/pull/71. I can take a look to confirm that it fixed the issue tonight and would be happy to push an updated changelog for v0.4.1

Santiago Pastorino (Apr 06 2020 at 16:59, on Zulip):

yes, we can release :)

Santiago Pastorino (Apr 06 2020 at 17:01, on Zulip):

just kicked a re-check for cargo-bisect-rustc#73

Santiago Pastorino (Apr 06 2020 at 17:02, on Zulip):

@Chris Simpkins do you want to add the changelog entries?

Chris Simpkins (Apr 06 2020 at 17:03, on Zulip):

Thoughts about creating a rustfmt matrix for the toolchains that are being tested? It looks like the PR only adds a stable fmt test

Chris Simpkins (Apr 06 2020 at 17:04, on Zulip):

Santiago Pastorino said:

Chris Simpkins do you want to add the changelog entries?

Yes, I can do this. Have you looked at the https://github.com/rust-lang/cargo-bisect-rustc/pull/71 PR? I haven't tested this to confirm that it addressed the issue yet.

Santiago Pastorino (Apr 06 2020 at 17:04, on Zulip):

the PR is merged now

Santiago Pastorino (Apr 06 2020 at 17:05, on Zulip):

Chris Simpkins said:

Santiago Pastorino said:

Chris Simpkins do you want to add the changelog entries?

Yes, I can do this. Have you looked at the https://github.com/rust-lang/cargo-bisect-rustc/pull/71 PR? I haven't tested this to confirm that it addressed the issue yet.

haven't tested it but it seems to make sense :)

Santiago Pastorino (Apr 06 2020 at 17:05, on Zulip):

would be good to try it out though

Chris Simpkins (Apr 06 2020 at 17:06, on Zulip):

Thoughts about this: https://github.com/rust-lang/cargo-bisect-rustc/pull/73#discussion_r404241338?

Santiago Pastorino (Apr 06 2020 at 17:06, on Zulip):

Chris Simpkins said:

Thoughts about creating a rustfmt matrix for the toolchains that are being tested? It looks like the PR only adds a stable fmt test

hmm, what would that mean?

Santiago Pastorino (Apr 06 2020 at 17:07, on Zulip):

you meant to check formatting with stable, beta, unstable?

Chris Simpkins (Apr 06 2020 at 17:07, on Zulip):

It is simple to define the Travis config, I am wondering if it makes sense to do so. Do we only want a stable rustfmt check?

Santiago Pastorino (Apr 06 2020 at 17:07, on Zulip):

the formatting may differ at some point

Chris Simpkins (Apr 06 2020 at 17:07, on Zulip):

Correct, we already run a matrix of tests by toolchain, do we want to add rustfmt checks using the rustfmt in those toolchains?

Chris Simpkins (Apr 06 2020 at 17:08, on Zulip):

RIght now it is stable only

Santiago Pastorino (Apr 06 2020 at 17:08, on Zulip):

but what I don't understand is how the code would be formatted at the same time in possible different ways to format the code?

Santiago Pastorino (Apr 06 2020 at 17:09, on Zulip):

I'm assuming that at some point nightly fmt could differ from stable fmt

Santiago Pastorino (Apr 06 2020 at 17:09, on Zulip):

maybe my assumption is wrong?

Chris Simpkins (Apr 06 2020 at 17:14, on Zulip):

Santiago Pastorino said:

but what I don't understand is how the code would be formatted at the same time in possible different ways to format the code?

Agree. There is nothing that you can do about it if there is a change percolating through the toolchains. It was a dumb question... :slight_smile:

Chris Simpkins (Apr 06 2020 at 17:16, on Zulip):

I'll let you know when I've looked into the bug fix and push the changelog update.

Chris Simpkins (Apr 07 2020 at 02:36, on Zulip):

Not ready to push yet. The bug fix addressed one part of the problem but it remains an issue when the GitHub API is used. https://github.com/rust-lang/cargo-bisect-rustc/issues/74

I can take a look later this week if someone else does not get to it first. (We need tests...) :slight_smile:

Chris Simpkins (Apr 11 2020 at 02:37, on Zulip):

I fixed the GitHub API git commit retrieval bug in https://github.com/rust-lang/cargo-bisect-rustc/pull/75. Updated project dependencies, bumped version to v0.4.1 in Cargo.toml, and updated CHANGELOG with v0.4.1 changes. We should be all set for this bug fix release @Santiago Pastorino .

Chris Simpkins (Apr 13 2020 at 14:57, on Zulip):

@pnkfelix I pushed the change that you requested in https://github.com/rust-lang/cargo-bisect-rustc/commit/be54918d5e80f1cccc18de0e7885a1101d74f1c2

Santiago Pastorino (Apr 13 2020 at 15:22, on Zulip):

merged and released!

Chris Simpkins (Apr 13 2020 at 16:15, on Zulip):

Santiago Pastorino said:

merged and released!

tyvm!

Last update: Jun 05 2020 at 23:15UTC