Stream: t-compiler/cargo-bisect-rustc

Topic: default nightly


lqd (Jan 09 2020 at 12:11, on Zulip):

I think there's something interesting going on when the default nightly is the same as one of the range it's trying to bisect

lqd (Jan 09 2020 at 12:12, on Zulip):

I'm on rustc 1.42.0-nightly (ef92009c1 2020-01-06) it has the default name nightly in rustup (nightly-x86_64-unknown-linux-gnu)

lqd (Jan 09 2020 at 12:13, on Zulip):

when trying to bisect something where the end range was also 2020-01-06 cargo-bisect-rustc kept saying the end range does not reproduce the regression

lqd (Jan 09 2020 at 12:13, on Zulip):

even though it does when testing manually or via --script

lqd (Jan 09 2020 at 12:13, on Zulip):

turns out there was an error running the command

lqd (Jan 09 2020 at 12:14, on Zulip):

the problem seems to be that cargo-bisect-rustc was using its "bisector" nightly name

lqd (Jan 09 2020 at 12:14, on Zulip):

which it hadn't installed since the default nightly has the same date

lqd (Jan 09 2020 at 12:16, on Zulip):

it passed the toolchain via the envRUSTUP_TOOLCHAIN: bisector-nightly-2020-01-06-x86_64-unknown-linux-gnu and rustup failed with error: toolchain 'bisector-nightly-2020-01-06-x86_64-unknown-linux-gnu' is not installed

lqd (Jan 09 2020 at 12:18, on Zulip):

all these errors happen inside cargo-bisect-rustc, for the user it's just

verifying the end of the range reproduces the regression
tested nightly-2020-01-06, got No
Santiago Pastorino (Jan 09 2020 at 14:06, on Zulip):

@lqd can you fill an issue? or well a PR would be even better :)

lqd (Jan 09 2020 at 14:06, on Zulip):

lol nice try :p

Santiago Pastorino (Jan 09 2020 at 14:07, on Zulip):

:P

lqd (Jan 09 2020 at 14:07, on Zulip):

I'll try to file an issue later yeah

lqd (Jan 09 2020 at 14:08, on Zulip):

I didn't fix it locally, only worked around it by changing the bounds on my bisection and it didn't fall on the nightly date again so it succeeded

lqd (Jan 09 2020 at 14:11, on Zulip):

I can try to fix it but I'll need to try one of your homemade beers if/when I ever visit Montevideo :p

Santiago Pastorino (Jan 09 2020 at 14:17, on Zulip):

for that you would need to implement cargo-bisect-rustc#40

Santiago Pastorino (Jan 09 2020 at 14:20, on Zulip):

and I can even take one bottle for you to All Hands if you're attending

lqd (Jan 09 2020 at 14:22, on Zulip):

(unsure about All Hands tbh)

lqd (Jan 09 2020 at 14:22, on Zulip):

(and yeah using the GH API would be nice :)

Santiago Pastorino (Jan 09 2020 at 14:24, on Zulip):

@Andrés Margalef and/or @apiraino were after that one :)

Last update: Jan 28 2020 at 01:40UTC