Stream: t-lang

Topic: Review PR #70193?


RalfJ (May 09 2020 at 11:15, on Zulip):

Can someone review #70193 (Limit maximum alignment in #[repr(align)] to 4K)? It keeps getting bounced from reviewer to reviewer and somehow ended up on my list...

RalfJ (May 09 2020 at 11:16, on Zulip):

@Amanieu says that

I believe the latest consensus is that we should emit a warning, with the intention of changing it to a hard error later.

Is that decision documented somewhere? The last I saw is @nikomatsakis asking some questions.

Amanieu (May 09 2020 at 11:17, on Zulip):

I believe it was discussed in the lang team meeting.

DPC (May 09 2020 at 11:20, on Zulip):

I guess I could reassign it to Niko for the moment. Sorry for the "reviewer juggling" :sweat_smile:

Josh Triplett (May 09 2020 at 20:28, on Zulip):

I can confirm that that was the decision. We did, however, want the limit to come from the target definition, so that targets can easily define a larger limit.

Last update: Jun 05 2020 at 22:50UTC