Stream: wg-ffi-unwind

Topic: PRs on the repo


nikomatsakis (Oct 08 2019 at 17:54, on Zulip):

Hey @Kyle Strand -- I left a few nits on your PR. Also, a suggestion re: LICENSE (mainly: let's use the same things RFCs use)

nikomatsakis (Oct 08 2019 at 17:54, on Zulip):

Sorry for the delay

nikomatsakis (Oct 08 2019 at 17:54, on Zulip):

Not sure if we feel ready to schedule another time to sync up? I'd be game btw to try and do Zulip-sync'ing in the future (vs zoom)

Adam C. Foltzer (Oct 08 2019 at 17:56, on Zulip):

I'm open to Zulip syncing, but am still getting used to the platform

nikomatsakis (Oct 08 2019 at 18:03, on Zulip):

It depends on the project but I often find Zulip sync'ing a bit "lighter weight" -- it's also more accessible, keeps an automatic log, etc

Kyle Strand (Oct 08 2019 at 18:05, on Zulip):

I like accessibility and automatic logging; the only issue I have is that I tend to multi-task when participating in text-only meetings

Kyle Strand (Oct 08 2019 at 18:06, on Zulip):

I should have checked what license the RFC repo uses!

nikomatsakis (Oct 08 2019 at 18:09, on Zulip):

I like accessibility and automatic logging; the only issue I have is that I tend to multi-task when participating in text-only meetings

heh, yeah, that can be an issue

nikomatsakis (Oct 08 2019 at 18:09, on Zulip):

on the other hand, I can play music :musical_notes:

Kyle Strand (Oct 08 2019 at 18:25, on Zulip):

I am also a fan of music!

Kyle Strand (Oct 08 2019 at 18:39, on Zulip):

Okay, I believe the concerns have been addressed. Thanks!

nikomatsakis (Oct 08 2019 at 18:52, on Zulip):

merged, great

Kyle Strand (Oct 12 2019 at 19:44, on Zulip):

I've opened a new PR based on the discussion raised in previous PRs.

Kyle Strand (Oct 12 2019 at 20:00, on Zulip):

( @nikomatsakis I was trying to notify Ralf, but I don't know if that worked)

Kyle Strand (Oct 22 2019 at 00:13, on Zulip):

@nikomatsakis I started by reading your PR on a plane using Vim, so I couldn't help but start making edits, which is making it take longer than if I just read it through. There are some bits we probably need to discuss, but I think I'll start that discussion by opening a PR against your branch.

nikomatsakis (Oct 22 2019 at 17:54, on Zulip):

I am thinking -- maybe I should merge my PR to aid in collaboration?

nikomatsakis (Oct 22 2019 at 17:54, on Zulip):

@Kyle Strand sounds great!

Kyle Strand (Oct 22 2019 at 18:00, on Zulip):

Based on discussion with @Amanieu , I am hesitant to introduce any RFC with extern "C unwind".

nikomatsakis (Oct 22 2019 at 21:33, on Zulip):

Say a bit more?

Kyle Strand (Oct 22 2019 at 21:37, on Zulip):

So, Amanieu opened the new topic 'Allow unwinding from extern "C" by default', based on their PR to the compiler

Kyle Strand (Oct 22 2019 at 21:38, on Zulip):

The suggestion is essentially like treating extern "C" the way we were planning to treat extern "C unwind"

Kyle Strand (Oct 22 2019 at 21:39, on Zulip):

I brought up the various UB issues we were concerned about, and it sounds very possible that the possible UB from the LLVM perspective is actually quite minimal.

nikomatsakis (Oct 22 2019 at 22:46, on Zulip):

@Kyle Strand maybe it makes sense to (a) move the two existing RFC PRs to a "drafts" directory and (b) create a minimal RFC that just announces this group -- since e.g. @Amanieu wasn't aware of its existence! -- and have as our first milestone to hammer out this issue of defaults.

nikomatsakis (Oct 22 2019 at 22:46, on Zulip):

this can be a pretty short RFC then

Kyle Strand (Oct 22 2019 at 22:50, on Zulip):

Kyle Strand maybe it makes sense to (a) move the two existing RFC PRs to a "drafts" directory and (b) create a minimal RFC that just announces this group -- since e.g. Amanieu wasn't aware of its existence! -- and have as our first milestone to hammer out this issue of defaults.

Absolutely.

Kyle Strand (Oct 22 2019 at 22:55, on Zulip):

Unfortunately it's hard for me to predict whether I'll have time this week to draft that. But I think our conversation in Discord is a good start

Kyle Strand (Oct 22 2019 at 22:55, on Zulip):

that plus the relevant sections in your current draft

Kyle Strand (Oct 25 2019 at 02:07, on Zulip):

@nikomatsakis were you able to take a look at my PR on your PR?

Kyle Strand (Oct 27 2019 at 19:37, on Zulip):

Quick update: I am working on the PR to _just_ announce the WG.

Kyle Strand (Oct 27 2019 at 22:08, on Zulip):

@nikomatsakis @Josh Triplett I'd like to have the RFC proposing the project-group link to the "final" location of the project-repo, i.e., /rust-lang/project-ffi-unwind rather than Niko's personal version. Can that be done soon, or is there a blocker to resolve first?

Kyle Strand (Oct 27 2019 at 22:08, on Zulip):

(And, if there's a blocker, should we wait on the RFC, or just link to Niko's repo?)

Kyle Strand (Oct 27 2019 at 22:21, on Zulip):

In any case, here's the draft of the RFC: https://github.com/nikomatsakis/project-ffi-unwind/pull/16

nikomatsakis (Oct 28 2019 at 20:41, on Zulip):

I will transfer the repo to rust-lang now

nikomatsakis (Oct 28 2019 at 20:43, on Zulip):

done

nikomatsakis (Oct 28 2019 at 20:45, on Zulip):

In any case, here's the draft of the RFC: https://github.com/nikomatsakis/project-ffi-unwind/pull/16

@Kyle Strand I dont' know of any blocker. If you want to open this RFC, it seems ok to me -- the main downside will be that we need to open a follow-up to do "C unwind". But at this point I just want to open up some RFCs.

nikomatsakis (Oct 28 2019 at 20:46, on Zulip):

I think if you open this one, I will immediately move to fcp merge :)

nikomatsakis (Oct 28 2019 at 20:46, on Zulip):

It seems fine for us to then work on the "C unwind" RFC

Kyle Strand (Oct 28 2019 at 20:58, on Zulip):

RFC opened: https://github.com/rust-lang/rfcs/pull/2797

Kyle Strand (Oct 28 2019 at 21:03, on Zulip):

I think I'll replace the entire file in our project repo with a link to that new RFC; does that sound reasonable?

Kyle Strand (Oct 28 2019 at 21:29, on Zulip):

When I get a chance I'll update my "Kyle's comments..." PR to remove the group-announcement text and replace it with links to the project repo and RFC #2797

Kyle Strand (Oct 29 2019 at 22:58, on Zulip):

@acfoltzer I should have pinged you yesterday; FYI I have opened the RFC to announce this group (link above)

Last update: Nov 15 2019 at 09:55UTC