Stream: t-compiler/wg-learning

Topic: Renaming the guide


Santiago Pastorino (Feb 25 2020 at 21:02, on Zulip):

it seems that we are in an agreement of renaming the guide and I want to proceed with it https://github.com/rust-lang/rustc-guide/issues/470

Santiago Pastorino (Feb 25 2020 at 21:02, on Zulip):

although we have a couple of options

Santiago Pastorino (Feb 25 2020 at 21:03, on Zulip):

@nikomatsakis originally suggested rustc-dev-guide

Santiago Pastorino (Feb 25 2020 at 21:04, on Zulip):

@pnkfelix then suggested rust compiler dev guide to avoid relying on a single c letter to differenciate between rust development and rust compiler development

Santiago Pastorino (Feb 25 2020 at 21:04, on Zulip):

thoughts?

Santiago Pastorino (Feb 25 2020 at 21:04, on Zulip):

mainly @nikomatsakis, @pnkfelix do you have any other thought?

nikomatsakis (Feb 25 2020 at 21:05, on Zulip):

(sorry, in #wg-traits meeting)

nikomatsakis (Feb 25 2020 at 21:05, on Zulip):

I don't have a strong opinion

Santiago Pastorino (Feb 25 2020 at 21:05, on Zulip):

me neither :P

Santiago Pastorino (Feb 25 2020 at 21:05, on Zulip):

I'm fine with both

Santiago Pastorino (Feb 25 2020 at 21:05, on Zulip):

maybe a bit more towards rustc-dev-guide

nikomatsakis (Feb 25 2020 at 21:05, on Zulip):

rustc-compiler-dev-guide seems too long

Santiago Pastorino (Feb 25 2020 at 21:05, on Zulip):

yep, that's why I'm a bit more towards the other one

Santiago Pastorino (Feb 25 2020 at 21:05, on Zulip):

but not too strong on that

Santiago Pastorino (Feb 25 2020 at 21:06, on Zulip):

:slight_smile:

amanjeev (Feb 27 2020 at 18:03, on Zulip):

Why not Rust Compiler Guide ?

amanjeev (Feb 27 2020 at 18:03, on Zulip):

I actually agree with spelling out Compiler explicitly.

Santiago Pastorino (Feb 28 2020 at 14:14, on Zulip):

cc @nikomatsakis @pnkfelix thoughts about Rust Compiler Guide?

nikomatsakis (Feb 28 2020 at 14:15, on Zulip):

I think rust compiler guide

nikomatsakis (Feb 28 2020 at 14:15, on Zulip):

hmm

nikomatsakis (Feb 28 2020 at 14:15, on Zulip):

so we have a user's guide

nikomatsakis (Feb 28 2020 at 14:15, on Zulip):

for the compiler

nikomatsakis (Feb 28 2020 at 14:15, on Zulip):

and this is not that

nikomatsakis (Feb 28 2020 at 14:15, on Zulip):

Rust Compiler Development Guide

nikomatsakis (Feb 28 2020 at 14:15, on Zulip):

rustc-dev-guide

nikomatsakis (Feb 28 2020 at 14:15, on Zulip):

something like that seems good to me

Santiago Pastorino (Feb 28 2020 at 14:15, on Zulip):

or we keep it as rustc-dev-guide

nikomatsakis (Feb 28 2020 at 14:16, on Zulip):

:ship: it

nikomatsakis (Feb 28 2020 at 14:16, on Zulip):

imo ;)

mark-i-m (Mar 02 2020 at 23:13, on Zulip):

Personally, I think rustc-dev-guide is a good balance between more explicit and too long. Alternately, we could do something like Rust Compiler Developer Guide and refer to it always as rcdg... not sure that's in improvement... I prefer rustc-dev-guide

mark-i-m (Mar 02 2020 at 23:14, on Zulip):

I think the needed changes mostly involve fixing links in rust-lang/* repos...

Santiago Pastorino (Mar 03 2020 at 01:09, on Zulip):

yeah, let's go with rustc-dev-guide going to proceed as soon as I can make the change

Chris Simpkins (Mar 03 2020 at 02:16, on Zulip):

Here is a list of all of the references to rustc-guide in the repository: https://gist.github.com/chrissimpkins/b61be20a52d209a8d0ed226a273839f5

Most of it is documentation URL but there are some source paths that will change with the git submodule update.

Chris Simpkins (Mar 03 2020 at 14:26, on Zulip):

I'd be happy to help revise the paths in the rust repo if this is decided.

Santiago Pastorino (Mar 05 2020 at 20:23, on Zulip):

hey @Chris Simpkins you want to go over this?

Santiago Pastorino (Mar 05 2020 at 20:23, on Zulip):

we can make that happen

Santiago Pastorino (Mar 05 2020 at 20:24, on Zulip):

going to check what's needed more or less because I don't remember

Santiago Pastorino (Mar 05 2020 at 20:24, on Zulip):

but it's mainly changing some urls in projects if I'm not wrong

Santiago Pastorino (Mar 05 2020 at 20:25, on Zulip):

maybe one good first step is to write out a procedure of what we would do to rename the guide and review that

Santiago Pastorino (Mar 05 2020 at 20:25, on Zulip):

and have the rest of the group reviewing it so we can be 100% safe

Chris Simpkins (Mar 05 2020 at 20:29, on Zulip):

@Santiago Pastorino said:

hey Chris Simpkins you want to go over this?

Sounds great. I posted the full set of links that I identified with a ripgrep run on the rust-lang/rust repository in https://gist.github.com/chrissimpkins/b61be20a52d209a8d0ed226a273839f5

It looks like we will need to (1) rename repository; (2) update the git submodule in rust-lang/rust; (3) revise a handful of string literal source paths; (4) update quite a few URL that point to the current rustc-guide URL

Santiago Pastorino (Mar 05 2020 at 20:31, on Zulip):

we should first prepare PRs all over the place with the rename

Chris Simpkins (Mar 05 2020 at 20:31, on Zulip):

I will be able to work on any part of this over the weekend.

Santiago Pastorino (Mar 05 2020 at 20:31, on Zulip):

in rustc-guide, rust and other places

Santiago Pastorino (Mar 05 2020 at 20:31, on Zulip):

let's build a little plan

Santiago Pastorino (Mar 05 2020 at 20:31, on Zulip):

I'm going over ...

Santiago Pastorino (Mar 05 2020 at 20:32, on Zulip):

https://github.com/search?p=2&q=org%3Arust-lang+rust-lang.github.io%2Frustc-guide&type=Code

Chris Simpkins (Mar 05 2020 at 20:34, on Zulip):

I can have a look tonight. hackmd document work to discuss it or do you want to create the plan in this thread?

Chris Simpkins (Mar 05 2020 at 20:36, on Zulip):

It looks like a checklist might be helpful :slight_smile: Maybe an issue to the tracker would work best for this?

Santiago Pastorino (Mar 05 2020 at 20:38, on Zulip):

I'm building a list

Santiago Pastorino (Mar 05 2020 at 20:38, on Zulip):

what do you meant by these two (3) revise a handful of string literal source paths; (4) update quite a few URL that point to the current rustc-guide URL in source documentation?

Santiago Pastorino (Mar 05 2020 at 20:39, on Zulip):
1. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/rustc-guide
2. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/rust
3. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/blog.rust-lang.org
4. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/const-eval
5. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/compiler-team
6. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/rust-forge
7. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/prev.rust-lang.org
7. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/reference
8. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/chalk
9. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/measureme
10. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/rust-gha
11. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/lang-team
12. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/rust-clippy
13. rename repository rust-lang/rustc-guide to rust-lang/rustc-dev-guide
14. merge PRs
15. update git submodule in rust-lang/rust
16. once everything is merged check if we lack more links in https://github.com/search?p=2&q=org%3Arust-lang+rust-lang.github.io%2Frustc-guide&type=Code
Chris Simpkins (Mar 05 2020 at 20:40, on Zulip):

Here is an example of a hard coded path in the source: https://github.com/rust-lang/rust/blob/master/src/bootstrap/test.rs#L1496

Chris Simpkins (Mar 05 2020 at 20:42, on Zulip):

and of a URL in source docs: https://github.com/rust-lang/rust/blob/master/src/librustc/lib.rs#L19

Santiago Pastorino (Mar 05 2020 at 20:43, on Zulip):

my idea was to do ...

Santiago Pastorino (Mar 05 2020 at 20:43, on Zulip):

find . -type f -exec sed -i 's,rustc-guide,rustc-dev-guide,g' {} +

Santiago Pastorino (Mar 05 2020 at 20:44, on Zulip):

but yeah we should check the result just in case

Santiago Pastorino (Mar 05 2020 at 20:44, on Zulip):

in particular [rustc guide] should be [rustc dev guide] :)

Chris Simpkins (Mar 05 2020 at 20:44, on Zulip):

There are some areas in source docs that use [rustc guide] Markdown without the hyphen

Chris Simpkins (Mar 05 2020 at 20:44, on Zulip):

^^ :slight_smile:

Santiago Pastorino (Mar 05 2020 at 20:44, on Zulip):

so that could be another expression to search and replace

Chris Simpkins (Mar 05 2020 at 20:46, on Zulip):

I can work on any part of this. Let me know if there is an area that you prefer to address

Santiago Pastorino (Mar 05 2020 at 20:47, on Zulip):

let's start providing PRs I guess

Santiago Pastorino (Mar 05 2020 at 20:47, on Zulip):

I was just running that thing on rust-lang/rust and rust-lang/rustc-guide

Santiago Pastorino (Mar 05 2020 at 20:48, on Zulip):

feel free to pick from the rest the ones you want

Santiago Pastorino (Mar 05 2020 at 20:49, on Zulip):

ok, the command was wrong :)

Chris Simpkins (Mar 05 2020 at 20:49, on Zulip):

Will do. I'll have a look at the next few on the list and try to get PR's up by tomorrow

Santiago Pastorino (Mar 05 2020 at 20:49, on Zulip):

it was modifying stuff on .git/ :)

Santiago Pastorino (Mar 05 2020 at 20:51, on Zulip):

we should exclude directories starting with .

Santiago Pastorino (Mar 05 2020 at 20:51, on Zulip):

unsure how to do that to be honest

Santiago Pastorino (Mar 05 2020 at 20:51, on Zulip):

we can just do src instead of .

Santiago Pastorino (Mar 05 2020 at 20:51, on Zulip):

and then check the top level files and all that

Chris Simpkins (Mar 05 2020 at 20:51, on Zulip):

We should mark these PR as WIP until everything is ready to go? Point to this thread to discuss it?

Chris Simpkins (Mar 05 2020 at 20:54, on Zulip):

I think better on the rustc-guide (soon to be rustc-dev-guide) tracker for discussion and linked from PR threads. I can open an issue with your list above as a checklist if you agree

Santiago Pastorino (Mar 05 2020 at 20:54, on Zulip):

find . -type d -name .git -prune -o -type f -exec sed -i 's,rustc-guide,rustc-dev-guide,g' {} +

Santiago Pastorino (Mar 05 2020 at 20:54, on Zulip):

Chris Simpkins said:

We should mark these PR as WIP until everything is ready to go? Point to this thread to discuss it?

yes, all the PRs should be WIP

Santiago Pastorino (Mar 05 2020 at 20:54, on Zulip):

maybe we can elaborate a text that we share in all the PRs

Santiago Pastorino (Mar 05 2020 at 20:55, on Zulip):

hmm still the command is wrong :)

Santiago Pastorino (Mar 05 2020 at 20:56, on Zulip):

now the problem is that we don't want to exercise submodules

Santiago Pastorino (Mar 05 2020 at 20:56, on Zulip):

maybe we can do a different thing which is just modify .rs, .txt, .md, .html files?

Santiago Pastorino (Mar 05 2020 at 20:56, on Zulip):

like list a set of extensions and go for those

Santiago Pastorino (Mar 05 2020 at 20:57, on Zulip):

submodules will be modified but we can ignore those

Santiago Pastorino (Mar 05 2020 at 20:57, on Zulip):

the first problem is to not modify files in .git directories

Santiago Pastorino (Mar 05 2020 at 20:57, on Zulip):

unsure if you have any other idea

Santiago Pastorino (Mar 05 2020 at 20:59, on Zulip):

git ls-files :)

Chris Simpkins (Mar 05 2020 at 20:59, on Zulip):

Will have a look tonight. Right in the middle of something else and can't dig into it in detail atm. Will be back in touch this evening after I take a look

Santiago Pastorino (Mar 05 2020 at 21:01, on Zulip):

:+1:

Santiago Pastorino (Mar 05 2020 at 21:10, on Zulip):

https://github.com/rust-lang/rust/pull/69747

Santiago Pastorino (Mar 05 2020 at 21:12, on Zulip):

https://github.com/rust-lang/rustc-guide/pull/601

Santiago Pastorino (Mar 05 2020 at 21:13, on Zulip):

Santiago Pastorino said:

1. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/rustc-guide
2. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/rust
3. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/blog.rust-lang.org
4. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/const-eval
5. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/compiler-team
6. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/rust-forge
7. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/prev.rust-lang.org
7. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/reference
8. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/chalk
9. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/measureme
10. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/rust-gha
11. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/lang-team
12. prepare a PR renaming rustc-guide to rustc-dev-guide on rust-lang/rust-clippy
13. rename repository rust-lang/rustc-guide to rust-lang/rustc-dev-guide
14. merge PRs
15. update git submodule in rust-lang/rust
16. once everything is merged check if we lack more links in https://github.com/search?p=2&q=org%3Arust-lang+rust-lang.github.io%2Frustc-guide&type=Code

@WG-learning please check if this procedure sounds good, we are already preparing PRs

LeSeulArtichaut (Mar 05 2020 at 21:48, on Zulip):

@Chris Simpkins Tell me if you need a hand preparing the PRs

Chris Simpkins (Mar 06 2020 at 02:43, on Zulip):

I came across references to "rustc_guide" and "Rustc Guide" in the blog.rust-lang.org repository

Chris Simpkins (Mar 06 2020 at 02:51, on Zulip):

Transition tracker IR: https://github.com/rust-lang/rustc-guide/issues/602

Chris Simpkins (Mar 06 2020 at 02:51, on Zulip):

Blog updated in https://github.com/rust-lang/blog.rust-lang.org/pull/535

Chris Simpkins (Mar 06 2020 at 03:01, on Zulip):

const-eval updated in https://github.com/rust-lang/const-eval/pull/37

Chris Simpkins (Mar 06 2020 at 03:17, on Zulip):

I came across a Zulip URL with rustc-guide in the compiler-team repository: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/rustc-guide-wg. We have to make sure that we don't update these links

Chris Simpkins (Mar 06 2020 at 03:20, on Zulip):

compiler-team repository updated in https://github.com/rust-lang/compiler-team/pull/254

Chris Simpkins (Mar 06 2020 at 03:31, on Zulip):

rust-forge repository updated in: https://github.com/rust-lang/rust-forge/pull/314

Chris Simpkins (Mar 06 2020 at 03:35, on Zulip):

prev.rust-lang.org => "NOTE: This repository will be deprecated soon. A new website is currently in Alpha Stage, and being reviewed by the Rust Teams. It will go into beta on November 29, 2018, at which point it will be linked here. The current site will remain up until the beta of the new site is over, however you should refrain from making large changes to this repository as it will soon be deprecated."

Worth updating prev.rust-lang.org?

Chris Simpkins (Mar 06 2020 at 03:53, on Zulip):

chalk repository updated in https://github.com/rust-lang/chalk/pull/344

Chris Simpkins (Mar 06 2020 at 04:20, on Zulip):

measurement repository updated in https://github.com/rust-lang/measureme/pull/113

Chris Simpkins (Mar 06 2020 at 04:33, on Zulip):

clippy repository updated in https://github.com/rust-lang/rust-clippy/pull/5277

Santiago Pastorino (Mar 06 2020 at 13:44, on Zulip):

@Chris Simpkins this is great, to be honest I need to properly check my PRs

Santiago Pastorino (Mar 06 2020 at 13:44, on Zulip):

they may have some little mistakes

Santiago Pastorino (Mar 06 2020 at 13:45, on Zulip):

did you find occurrences other than "rustc-guide", "rustc guide" and "rustc_guide"?

Santiago Pastorino (Mar 06 2020 at 13:56, on Zulip):

also ...

Santiago Pastorino (Mar 06 2020 at 13:56, on Zulip):

I have ran ...

Santiago Pastorino (Mar 06 2020 at 13:56, on Zulip):
git grep -l 'rustc_guide' | xargs sed -i 's/rustc_guide/rustc_dev_guide/g'
git grep -l 'rustc-guide' | xargs sed -i 's/rustc-guide/rustc-dev-guide/g'
git grep -l 'rustc guide' | xargs sed -i 's/rustc guide/rustc dev guide/g'
Santiago Pastorino (Mar 06 2020 at 13:56, on Zulip):

and checked the result afterwards, unsure if you did the same or something else

Chris Simpkins (Mar 06 2020 at 13:56, on Zulip):

There was "Rustc Guide" used in a few of the Markdown files out there

Chris Simpkins (Mar 06 2020 at 13:58, on Zulip):

The other issue was that the Zulip URL's with rustc-guide will either need to be updated or we need to make sure that those aren't automatically changed. Only came across this once

Santiago Pastorino (Mar 06 2020 at 14:15, on Zulip):

yep

Santiago Pastorino (Mar 06 2020 at 14:15, on Zulip):

worth checking

Santiago Pastorino (Mar 06 2020 at 14:15, on Zulip):

btw, I'm not 100% sure what will happen with https://github.com/rust-lang/rust/pull/69747/files#diff-8903239df476d7401cf9e76af0252622L34

Santiago Pastorino (Mar 06 2020 at 14:16, on Zulip):

I guess our building system handles all this gracefully but want to be 101% sure :)

Santiago Pastorino (Mar 06 2020 at 14:19, on Zulip):

something like that rg -i "rustc.guide" may helps finding left overs if any

Chris Simpkins (Mar 06 2020 at 14:31, on Zulip):

The ones that I worked on did not have a huge number of changes. I ended up using "Replace in Files" in VS Code. It gives you a pre/post diff on the changes.

Chris Simpkins (Mar 06 2020 at 14:31, on Zulip):

As I scanned what was being changed, I came across those other strings

Santiago Pastorino (Mar 06 2020 at 14:32, on Zulip):

btw, didn't understand the rust-gha thing :)

Chris Simpkins (Mar 06 2020 at 14:32, on Zulip):

Neither do I. How is that project used?

Santiago Pastorino (Mar 06 2020 at 14:34, on Zulip):

I have no idea tbh :)

Santiago Pastorino (Mar 06 2020 at 14:34, on Zulip):

cc @Pietro Albini

Santiago Pastorino (Mar 06 2020 at 14:35, on Zulip):

@Pietro Albini the question was specifically https://github.com/rust-lang/rustc-guide/issues/602#issuecomment-595775159

Pietro Albini (Mar 06 2020 at 14:35, on Zulip):

just ignore that repo

Santiago Pastorino (Mar 06 2020 at 14:36, on Zulip):

how does that works?, just curious

Pietro Albini (Mar 06 2020 at 14:37, on Zulip):

it's my playground for gha

Santiago Pastorino (Mar 06 2020 at 14:37, on Zulip):

ahh ok :)

Santiago Pastorino (Mar 06 2020 at 14:38, on Zulip):

GitHub Actions tests for rust-lang/rust made me think there were some kind of tests

Santiago Pastorino (Mar 06 2020 at 14:38, on Zulip):

maybe worth adding the word playground there, I think it makes it more clear what's about :)

Santiago Pastorino (Mar 06 2020 at 14:39, on Zulip):

Pietro's playground for GitHub Actions would be even more clear :joy:

Chris Simpkins (Mar 06 2020 at 14:48, on Zulip):

Any other repositories outside of rust-lang org that we might need to address?

Santiago Pastorino (Mar 06 2020 at 14:54, on Zulip):

may worth checking this https://github.com/search?q=rust-lang.github.io%2Frustc-guide&type=Code

Santiago Pastorino (Mar 06 2020 at 14:54, on Zulip):

but it's a lot of stuff there :P

Santiago Pastorino (Mar 06 2020 at 14:54, on Zulip):

unsure if we can avoid rust-lang org in that query

Santiago Pastorino (Mar 06 2020 at 14:55, on Zulip):

I don't think it worth

Santiago Pastorino (Mar 06 2020 at 14:55, on Zulip):

the rest can be addressed afterwards with PRs

Santiago Pastorino (Mar 06 2020 at 14:56, on Zulip):

if people find something they will fix it :)

Santiago Pastorino (Mar 06 2020 at 14:57, on Zulip):

maybe this https://github.com/search?q=org%3Arust-lang-nursery+rust-lang.github.io%2Frustc-guide&type=Code

Santiago Pastorino (Mar 06 2020 at 14:57, on Zulip):

that one should be included

Chris Simpkins (Mar 06 2020 at 15:18, on Zulip):

maybe this https://github.com/search?q=org%3Arust-lang-nursery+rust-lang.github.io%2Frustc-guide&type=Code

Added to the TODO list in https://github.com/rust-lang/rustc-guide/issues/602

Santiago Pastorino (Mar 06 2020 at 18:45, on Zulip):

can we add this https://github.com/rust-lang/rustc-guide/issues/470#issuecomment-595680655 to the TODO list?

Chris Simpkins (Mar 06 2020 at 18:54, on Zulip):

@Santiago Pastorino said:

can we add this https://github.com/rust-lang/rustc-guide/issues/470#issuecomment-595680655 to the TODO list?

Done! Who can do this?

Chris Simpkins (Mar 06 2020 at 18:57, on Zulip):

Does GH automate this for github.io links when the repository is renamed? git and repository URL are automatically forwarded

Santiago Pastorino (Mar 06 2020 at 19:00, on Zulip):

I guess what we want is to have a rustc-guide repo that just redirects to rustc-dev-guide

Santiago Pastorino (Mar 06 2020 at 19:01, on Zulip):

I meant ...

Santiago Pastorino (Mar 06 2020 at 19:02, on Zulip):

similar to this I guess https://github.com/rust-lang-nursery/rust-lang-nursery.github.io

Santiago Pastorino (Mar 06 2020 at 19:02, on Zulip):

should we proceed with the migration?

Santiago Pastorino (Mar 06 2020 at 19:04, on Zulip):

well actually we need some admin of rust-lang org, I'm not

Santiago Pastorino (Mar 06 2020 at 19:04, on Zulip):

@Pietro Albini @nikomatsakis ?

Santiago Pastorino (Mar 06 2020 at 19:04, on Zulip):

we need somebody to rename the repo rustc-guide to rustc-dev-guide

Chris Simpkins (Mar 06 2020 at 19:04, on Zulip):

tempting fate to do it on a friday pm :slight_smile:

Santiago Pastorino (Mar 06 2020 at 19:04, on Zulip):

:)

Santiago Pastorino (Mar 06 2020 at 19:05, on Zulip):

we are bold :)

Chris Simpkins (Mar 06 2020 at 19:05, on Zulip):

Ha! I like it

Santiago Pastorino (Mar 06 2020 at 19:05, on Zulip):

let's leave this for next monday

Santiago Pastorino (Mar 06 2020 at 19:05, on Zulip):

let's be wise :)

Chris Simpkins (Mar 06 2020 at 19:07, on Zulip):

I can submit the outstanding PR over the weekend unless someone else gets to it first. Anything else that you need me to do? I don't believe that I can address any of the other items on that list. Looks like we need admin level help

Santiago Pastorino (Mar 06 2020 at 19:07, on Zulip):

yeah we would need to rename the repo and to create a new rustc-guide one

Santiago Pastorino (Mar 06 2020 at 19:07, on Zulip):

another thing we need to do is to prepare the content of rustc-guide

Santiago Pastorino (Mar 06 2020 at 19:07, on Zulip):

similar to

Santiago Pastorino (Mar 06 2020 at 19:07, on Zulip):

https://github.com/rust-lang-nursery/rust-lang-nursery.github.io

Santiago Pastorino (Mar 06 2020 at 19:08, on Zulip):

basically it will be something that redirects to rustc-dev-guide

Santiago Pastorino (Mar 06 2020 at 19:09, on Zulip):

well unsure how to make all the links inside rustc-guide redirect ro rustc-dev-guide using github pages

Santiago Pastorino (Mar 06 2020 at 19:09, on Zulip):

there's probably a way I guess

Chris Simpkins (Mar 06 2020 at 19:10, on Zulip):

Hmmm... I wonder if GH supports this automatically? They do for the git and repo URL's. Not sure about pages URLs

Santiago Pastorino (Mar 06 2020 at 19:11, on Zulip):

it seems like we need to reconstruct the directory structure of the site

Santiago Pastorino (Mar 06 2020 at 19:11, on Zulip):

and add the html redirect file on every single place :S

Santiago Pastorino (Mar 06 2020 at 19:11, on Zulip):

like what's explained here https://opensource.com/article/19/7/permanently-redirect-github-pages

Santiago Pastorino (Mar 06 2020 at 19:13, on Zulip):

we could use JS otherwise

Santiago Pastorino (Mar 06 2020 at 19:13, on Zulip):

get window.location, replace it and redirect

Chris Simpkins (Mar 06 2020 at 19:14, on Zulip):

As I understand it this requires the rustc-guide repo to stay put and act as the redirect and a new (not moved) rustc-dev-guide to be set up?

Santiago Pastorino (Mar 06 2020 at 19:14, on Zulip):

I'd say rename the repo first so we save the history, issues and everything

Santiago Pastorino (Mar 06 2020 at 19:15, on Zulip):

so rustc-guide is rustc-dev-guide

Santiago Pastorino (Mar 06 2020 at 19:15, on Zulip):

after that create an empty rustc-guide

Santiago Pastorino (Mar 06 2020 at 19:15, on Zulip):

and set up there the redirects

Santiago Pastorino (Mar 06 2020 at 19:15, on Zulip):

this can be useful https://github.com/rust-lang-nursery/rust-lang-nursery.github.io/blob/master/generate_redirects.py

Chris Simpkins (Mar 06 2020 at 19:15, on Zulip):

going to quickly test if you can move a GH repo to a different name, then recreate a new one with the old name. One sec

Santiago Pastorino (Mar 06 2020 at 19:15, on Zulip):

yeap unsure if that's possible

Santiago Pastorino (Mar 06 2020 at 19:16, on Zulip):

I guess it should

Santiago Pastorino (Mar 06 2020 at 19:16, on Zulip):

because GH kind of stick with it to do the redirects

Santiago Pastorino (Mar 06 2020 at 19:16, on Zulip):

but I guess as soon as you want to create a new one you should be allowed

Chris Simpkins (Mar 06 2020 at 19:18, on Zulip):

Worked on two fresh repos

Chris Simpkins (Mar 06 2020 at 19:19, on Zulip):

Not sure how Pages links are handled with that approach if there are redirects in place. And that likely eliminates the git / repository forwarding which is probably desirable?

Santiago Pastorino (Mar 06 2020 at 19:28, on Zulip):

yeah that's the downside

Santiago Pastorino (Mar 06 2020 at 19:28, on Zulip):

but once you go to github.com/rustc-guide it would be obvious that the repo was migrated

Santiago Pastorino (Mar 06 2020 at 19:28, on Zulip):

the README and the description would say so

LeSeulArtichaut (Mar 06 2020 at 21:55, on Zulip):

As for the rust-lang/prev.rust-lang.org repo, all the matches for rustc-guide link to the README.md of rust-lang/rust

LeSeulArtichaut (Mar 06 2020 at 21:55, on Zulip):

So they don't need to be updated

Chris Simpkins (Mar 06 2020 at 21:56, on Zulip):

With @LeSeulArtichaut's PR https://github.com/rust-lang-nursery/rust-lang-nursery.github.io/pull/4, I think that all of the renaming PR's are now in place

LeSeulArtichaut (Mar 06 2020 at 21:57, on Zulip):

Let's poke @Santiago Pastorino

LeSeulArtichaut (Mar 06 2020 at 21:57, on Zulip):

:oops:

Chris Simpkins (Mar 06 2020 at 21:57, on Zulip):

LeSeulArtichaut said:

As for the rust-lang/prev.rust-lang.org repo, all the matches for rustc-guide link to the README.md of rust-lang/rust

I added a check for that box in the TODO list. Ty!

Chris Simpkins (Mar 06 2020 at 21:58, on Zulip):

These are the remaining tasks:

- [ ] add redirects from rustc-guide to rustc-dev-guide URL
- [ ] rename repository rust-lang/rustc-guide to rust-lang/rustc-dev-guide
- [ ] merge PRs
- [ ] update git submodule in rust-lang/rust
- [ ] once everything is merged check if we lack more links in https://github.com/search?p=2&q=org%3Arust-lang+rust-lang.github.io%2Frustc-guide&type=Code
Chris Simpkins (Mar 06 2020 at 22:00, on Zulip):

and here is what Santiago recommended in https://github.com/rust-lang/rustc-guide/issues/602#issuecomment-595924798:

- rename rustc-guide to rustc-dev-guide repo
- create a fresh rustc-guide repo
- adjust the description and README to note that the repo has migrate to rustc-dev-guide
- redirect all the existing links from rustc-guide to rustc-dev-guide. For that we need to recreate the directory structure of the guide with index.html files that redirect to rustc-dev-guide
LeSeulArtichaut (Mar 06 2020 at 22:08, on Zulip):

This has probably already been read, but there is a GitHub guide about renaming a repository (just in case :sweat_smile:)

Chris Simpkins (Mar 06 2020 at 22:09, on Zulip):

LeSeulArtichaut said:

This has probably already been read, but there is a GitHub guide about renaming a repository (just in case :sweat_smile:)

:thumbs_up:

If you plan to rename a repository that has a GitHub Pages site, we recommend using a custom domain for your site. This ensures that the site's URL isn't impacted by renaming the repository. For more information, see "About custom domains and GitHub Pages site."

LeSeulArtichaut (Mar 06 2020 at 22:10, on Zulip):

Gotta say I didn't really follow the progress on this. Reading 200 messages at once isn't really convenient :slight_smile:

Chris Simpkins (Mar 06 2020 at 22:11, on Zulip):

We discussed earlier that there is a tradeoff to renaming rustc-guide to rustc-dev-guide, then creating a new rustc-guide repo for forwarding links. This will break all of the automated GH git / repository URL forwarding that happens with a rename

mark-i-m (Mar 06 2020 at 22:31, on Zulip):

@Chris Simpkins I would say the old website is low-priority

mark-i-m (Mar 06 2020 at 22:36, on Zulip):

We discussed earlier that there is a tradeoff to renaming rustc-guide to rustc-dev-guide, then creating a new rustc-guide repo for forwarding links. This will break all of the automated GH git / repository URL forwarding that happens with a rename

I haven't followed super closely, but I think the automatic redirecting doesn't happen for gh pages, so we would need our own redirect page anyway, iiuc...

LeSeulArtichaut (Mar 06 2020 at 22:37, on Zulip):

That's what eddyb said here at least.

Chris Simpkins (Mar 06 2020 at 22:37, on Zulip):

mark-i-m said:

I haven't followed super closely, but I think the automatic redirecting doesn't happen for gh pages, so we would need our own redirect page anyway, iiuc...

That is our understanding too. GH will redirect git and the repository URL's. But we will break that by replacing the old rustc-guide repo with a new one.

Chris Simpkins (Mar 06 2020 at 22:38, on Zulip):

I think

Chris Simpkins (Mar 07 2020 at 15:01, on Zulip):

@LeSeulArtichaut Thanks for reviewing all of the PR's. Much appreciated!

LeSeulArtichaut (Mar 07 2020 at 15:01, on Zulip):

You're forcing me to say thanks @Chris Simpkins for writing all of the PR's :D

Chris Simpkins (Mar 07 2020 at 15:02, on Zulip):

Ha! That wasn't the intent. I really do appreciate it. You found a number of issues. I think that everything is addressed now

LeSeulArtichaut (Mar 07 2020 at 15:04, on Zulip):

No problem :heart:

Chris Simpkins (Mar 07 2020 at 15:06, on Zulip):

@Santiago Pastorino @mark-i-m I think that we are gtg on the renaming PR's. They are all open and ready to be merged. We are ready for the repo name change next week.

LeSeulArtichaut (Mar 07 2020 at 15:10, on Zulip):

We still need to

add redirects from rustc-guide to rustc-dev-guide URL

Chris Simpkins (Mar 07 2020 at 15:36, on Zulip):

Believe that repo needs to move first

Chris Simpkins (Mar 07 2020 at 16:14, on Zulip):

https://github.com/rust-lang/rustc-guide/issues/602#issuecomment-595924798

Chris Simpkins (Mar 07 2020 at 16:17, on Zulip):

@LeSeulArtichaut We will need an admin to set up the repo after the rename. Interested in setting up the redirect repo? I am not aware of anyone else who is currently planning to do this

LeSeulArtichaut (Mar 07 2020 at 16:49, on Zulip):

Alright

LeSeulArtichaut (Mar 07 2020 at 18:50, on Zulip):

Can't we just have an "empty" repo with just a README.md to redirect GitHub users to the new repo, a 404.html file to redirect Pages users? This removes the need to recreate the current structure

LeSeulArtichaut (Mar 07 2020 at 18:51, on Zulip):

I have no experience at all with GitHub pages :sweat_smile:

Chris Simpkins (Mar 07 2020 at 18:54, on Zulip):

https://github.com/rust-lang-nursery/rust-lang-nursery.github.io/blob/master/generate_redirects.py

LeSeulArtichaut (Mar 07 2020 at 18:54, on Zulip):

That's overkill :D

LeSeulArtichaut (Mar 07 2020 at 18:55, on Zulip):

The reason why they set this up was to handle different versions I guess

Chris Simpkins (Mar 07 2020 at 18:55, on Zulip):

It sounds like the plan was to replicate the directory structure and add a redirect page in each directory IIUC

LeSeulArtichaut (Mar 07 2020 at 18:55, on Zulip):

Yes, but now I wonder if that's even necessary

LeSeulArtichaut (Mar 07 2020 at 18:55, on Zulip):

We can just let one 404.html do the job

LeSeulArtichaut (Mar 07 2020 at 18:56, on Zulip):

I'm referring to

Chris Simpkins (Mar 07 2020 at 18:56, on Zulip):

That would be much easier if it works

LeSeulArtichaut (Mar 07 2020 at 18:56, on Zulip):

@Santiago Pastorino Thoughts?

LeSeulArtichaut (Mar 07 2020 at 19:18, on Zulip):

Setup works: try going to:

LeSeulArtichaut (Mar 07 2020 at 19:19, on Zulip):

Doesn't conserve the path though

Chris Simpkins (Mar 07 2020 at 19:19, on Zulip):

That must be why it needs to be done dir by dir?

Chris Simpkins (Mar 07 2020 at 19:20, on Zulip):

Good to see that it forwards though!

Chris Simpkins (Mar 07 2020 at 19:24, on Zulip):

It looks like you just have the top level redirect. Perhaps we do need to replace the entire dir structure to get the appropriate redirects?

LeSeulArtichaut (Mar 07 2020 at 19:55, on Zulip):

Or we might need JS scripting

LeSeulArtichaut (Mar 07 2020 at 19:57, on Zulip):

Anyway, the redirection part shouldn’t be a blocker IMO as it can easily be modified later

mark-i-m (Mar 07 2020 at 20:23, on Zulip):

We will need an admin to set up the repo after the rename.

I don't have sufficient permissions to do this... I'm not sure if @Santiago Pastorino does either. We might need to call in Niko to create the new repo and give WG-learning write permissions

mark-i-m (Mar 07 2020 at 20:23, on Zulip):

We can just let one index.html/404.html do the job

:+1: Simpler is better

mark-i-m (Mar 07 2020 at 20:26, on Zulip):

Personally, I would be ok with just having a static page without a redirect that says "rustc-guide has moved to here"... if we want, we could even have a quick JS script that translates the address and puts a link on the page

LeSeulArtichaut (Mar 08 2020 at 10:14, on Zulip):

Got a solution which does conserve the path using JS

LeSeulArtichaut (Mar 08 2020 at 10:14, on Zulip):

Try going to:

LeSeulArtichaut (Mar 08 2020 at 13:05, on Zulip):

@mark-i-m I think only the core team members have owner privileges in the GH org. But we could ask Mark-Simulacrum or Pietro Albini

mark-i-m (Mar 08 2020 at 13:50, on Zulip):

Thanks @LeSeulArtichaut ! And yes, I think that sounds right.

mark-i-m (Mar 08 2020 at 13:51, on Zulip):

One question: do we want an actual redirect or just a landing page that asks people where they want to go?

LeSeulArtichaut (Mar 08 2020 at 15:35, on Zulip):

IMHO, redirecting to the Rustc Book isn't necessary, so we can automatically redirect to the rustc-dev-guide.
The main point was raised by RalfJung here, and was "there already are plenty of links to rustc-guide".

LeSeulArtichaut (Mar 08 2020 at 15:35, on Zulip):

So in this mindset, we should just blindly redirect people to rustc-dev-guide

mark-i-m (Mar 09 2020 at 02:53, on Zulip):

Hmm... I guess that makes sense

Chris Simpkins (Mar 09 2020 at 13:42, on Zulip):

@Santiago Pastorino @mark-i-m @LeSeulArtichaut Are we ready to make the transition today?

LeSeulArtichaut (Mar 09 2020 at 14:17, on Zulip):

I think we are, but we still need to address @mark-i-m’s question

Chris Simpkins (Mar 09 2020 at 14:24, on Zulip):

IMO, if we can't forward to the proper page, then a landing page with an announcement of the transition (and perhaps a search box that allows you to search the content on the new site?) is the best approach. I think that forwarding all content links to the new homepage will feel broken for users. It isn't intuitive that there has been a rename (have to look at the URL to figure that out and the rename is relatively subtle) and it will break all links out there except the homepage links.

mark-i-m (Mar 09 2020 at 14:31, on Zulip):

I guess I don't have strong preferences myself. @LeSeulArtichaut's prototype seemed to work using js, so we could do that...

Chris Simpkins (Mar 09 2020 at 14:33, on Zulip):

Maybe a callout at the top of the homepage for a month or so that notifies those who land there about it? Could point to the blog post announcement?

mark-i-m (Mar 09 2020 at 14:34, on Zulip):

Also, I will be in and out of meetings today, but I do think we should do it today

mark-i-m (Mar 09 2020 at 14:34, on Zulip):

I don't know how to do this with mdbook

mark-i-m (Mar 09 2020 at 14:40, on Zulip):

Perhaps a middle ground is to have a landing page that redirects after 10 seconds or something?

LeSeulArtichaut (Mar 09 2020 at 16:13, on Zulip):

If we want to have a popup when redirected we might achieve that by setting a query flag on redirection

LeSeulArtichaut (Mar 09 2020 at 16:20, on Zulip):

Still requires to integrate that to mdBook though

LeSeulArtichaut (Mar 09 2020 at 16:22, on Zulip):

I think we coule make use of the additional-jsinstruction

LeSeulArtichaut (Mar 09 2020 at 17:11, on Zulip):

Made myself a shitty script, but... It seems to work :shrug:

LeSeulArtichaut (Mar 09 2020 at 17:13, on Zulip):

Behold! I can now insert a blockquote before the title of an article!

LeSeulArtichaut (Mar 09 2020 at 17:15, on Zulip):

Here is what it looks like

mark-i-m (Mar 09 2020 at 17:27, on Zulip):

I guess something like that could work

mark-i-m (Mar 09 2020 at 17:31, on Zulip):

Is there a preferred time when people would like to make the switch?
Also, @simulacrum would you be able to create an empty repo called rust-lang/rustc-guide-redirect and give WG-learning admin access on it. That way, we can put up the redirect (and rename the repo) at the need time without the core team needing to be present.

simulacrum (Mar 09 2020 at 18:07, on Zulip):

I'm confused how that repo would help - I would expect the redirect needs to be at the current location? Maybe I'm wrong though

mark-i-m (Mar 09 2020 at 18:08, on Zulip):

@simulacrum Yes, so we would get the repo ready now, and then rename it into place after we have renamed rustc-dev-guide

simulacrum (Mar 09 2020 at 18:08, on Zulip):

It may also be worth thinking about decoupling from GitHub and putting it at dev-guide.compiler.rust-lang.org.

simulacrum (Mar 09 2020 at 18:08, on Zulip):

Ah okay, I can create that in a bit.

simulacrum (Mar 09 2020 at 18:08, on Zulip):

Please ping me if I forget in an hour or so.

simulacrum (Mar 09 2020 at 18:13, on Zulip):

Should be done - lmk if permissions didn't work out. @mark-i-m

Yuki Okushi (Mar 09 2020 at 18:14, on Zulip):

seems fine to me

mark-i-m (Mar 09 2020 at 18:27, on Zulip):

@simulacrum Thanks! It seems to be working

It may also be worth thinking about decoupling from GitHub and putting it at dev-guide.compiler.rust-lang.org.

Seems reasonable, but how would we do that?

simulacrum (Mar 09 2020 at 18:31, on Zulip):

You ask me to setup the domain and tell me where to point it at

simulacrum (Mar 09 2020 at 18:31, on Zulip):

(I forget, but I think GitHub supports custom domains, so it should just work)

Santiago Pastorino (Mar 09 2020 at 18:37, on Zulip):

hey, I'm just catching up

Santiago Pastorino (Mar 09 2020 at 18:37, on Zulip):

a lot of messages :)

Santiago Pastorino (Mar 09 2020 at 18:38, on Zulip):

can we better condense all the things that were discussed into a set of steps?

Santiago Pastorino (Mar 09 2020 at 18:38, on Zulip):

maybe the tracking issue is a good fit

Santiago Pastorino (Mar 09 2020 at 18:38, on Zulip):

saw the things about redirect

Santiago Pastorino (Mar 09 2020 at 18:38, on Zulip):

then didn't understand either the repos idea

mark-i-m (Mar 09 2020 at 18:38, on Zulip):

Let me try to summarize:

Santiago Pastorino (Mar 09 2020 at 18:38, on Zulip):

I have my set of ideas but before discussing would be nice if you @Chris Simpkins can condense all the info into a writing, hard to understand the final picture out of 100 messages :)

Santiago Pastorino (Mar 09 2020 at 18:40, on Zulip):

simulacrum said:

It may also be worth thinking about decoupling from GitHub and putting it at dev-guide.compiler.rust-lang.org.

this is a good idea but I'd go with rustc-dev-guide.rust-lang.org so we keep using the same name everywhere

Santiago Pastorino (Mar 09 2020 at 18:42, on Zulip):

we still need the redirects for rust-lang.github.io/rustc-guide/* -> whatever we use

Chris Simpkins (Mar 09 2020 at 18:42, on Zulip):

Summary:

All renaming PR's that we've identified are open under WIP/hold until merge happens flags in titles.

We are prepared to rename the rustc-guide repository to rustc-dev-guide. Before this is performed, we'd like to sort out how it would be best to handle existing links to github.io URL out there. There are a few positions under discussion. As I understand them, (1) create separate repo to redirect ALL links to new homepage; (2) create a landing page that informs user about the transition but provides no forwarding automation; (3) some combination of 1/2

Santiago Pastorino (Mar 09 2020 at 18:42, on Zulip):

redirecting top level would loose the actual page the users intended to visit

Santiago Pastorino (Mar 09 2020 at 18:43, on Zulip):

Chris Simpkins said:

Summary:

All renaming PR's that we've identified are open under WIP/hold until merge happens flags in titles.

We are prepared to rename the rustc-guide repository to rustc-dev-guide. Before this is performed, we'd like to sort out how it would be best to handle existing links to github.io URL out there. There are a few positions under discussion. As I understand them, (1) create separate repo to redirect ALL links to new homepage; (2) create a landing page that informs user about the transition but provides no forwarding automation; (3) some combination of 1/2

yeah that's fine :)

Santiago Pastorino (Mar 09 2020 at 18:44, on Zulip):

yeah, I guess it's a matter of balancing how good we want this to be and how much do we want to work on the thing

Santiago Pastorino (Mar 09 2020 at 18:44, on Zulip):

in principle IMO the best idea is to replicate the structure and redirect so existing links keep working

Santiago Pastorino (Mar 09 2020 at 18:45, on Zulip):

the only drawback I can see to the approach is that if we rename something, let's say ty is not ty anymore now is type

Santiago Pastorino (Mar 09 2020 at 18:45, on Zulip):

we need to adjust the destination of the redirects or well they won't work

mark-i-m (Mar 09 2020 at 18:46, on Zulip):

My preference is something like #3

Santiago Pastorino (Mar 09 2020 at 18:46, on Zulip):

so in some sense if we just provide a 404.html page that says, site was moved to rustc-dev-guide.rust-lang.org the user would need to figure out

mark-i-m (Mar 09 2020 at 18:47, on Zulip):

Yes

Santiago Pastorino (Mar 09 2020 at 18:47, on Zulip):

I'm neutral to be honest

mark-i-m (Mar 09 2020 at 18:47, on Zulip):

I'm actually kind of ok with that. How often do we expect that to happen?

Santiago Pastorino (Mar 09 2020 at 18:47, on Zulip):

I think it will happen a lot

Santiago Pastorino (Mar 09 2020 at 18:47, on Zulip):

bookmarks

Santiago Pastorino (Mar 09 2020 at 18:47, on Zulip):

blog posts

Santiago Pastorino (Mar 09 2020 at 18:47, on Zulip):

projects

Santiago Pastorino (Mar 09 2020 at 18:47, on Zulip):

are right now linking to the old site

Santiago Pastorino (Mar 09 2020 at 18:48, on Zulip):

and those links will be lost

mark-i-m (Mar 09 2020 at 18:48, on Zulip):

Hmm... I see

Santiago Pastorino (Mar 09 2020 at 18:48, on Zulip):

to be honest I'm a bit more towards replicating the directory structure

Santiago Pastorino (Mar 09 2020 at 18:48, on Zulip):

won't be too much work IMO

mark-i-m (Mar 09 2020 at 18:48, on Zulip):

Hmm... let me try

Santiago Pastorino (Mar 09 2020 at 18:49, on Zulip):

so in that case the idea would be ...

Santiago Pastorino (Mar 09 2020 at 18:49, on Zulip):

first to rename the repo

mark-i-m (Mar 09 2020 at 18:49, on Zulip):

Mark created this repo: https://github.com/rust-lang/rustc-guide-redirect/ for us, which we can rename into place after we rename the guide

Santiago Pastorino (Mar 09 2020 at 18:49, on Zulip):

then to create again rustc-guide

Santiago Pastorino (Mar 09 2020 at 18:49, on Zulip):

exactly

mark-i-m (Mar 09 2020 at 18:50, on Zulip):

Let me try setting something up in that repo... and we can adjust it as needed

Santiago Pastorino (Mar 09 2020 at 18:52, on Zulip):

have adjusted https://github.com/rust-lang/rustc-guide/issues/602

Santiago Pastorino (Mar 09 2020 at 18:52, on Zulip):

check it out to see if we are in agreement then

Chris Simpkins (Mar 09 2020 at 18:53, on Zulip):

I have meetings from 3p - 5p EST and am free afterwards to pitch in here. Let me know how I can help.

mark-i-m (Mar 09 2020 at 18:54, on Zulip):

@Santiago Pastorino LGTM... also, you and I have permissions to rename rustc-guide, I think, and anyone in the WG has permission to rename the -redirect repo.

mark-i-m (Mar 09 2020 at 18:55, on Zulip):

And renaming the submodule in rust-lang/rust is just a normal PR

mark-i-m (Mar 09 2020 at 18:55, on Zulip):

One other thing: I should update the blog post to reflect our decision

mark-i-m (Mar 09 2020 at 18:55, on Zulip):

And I have a meeting in ~30 min

Santiago Pastorino (Mar 09 2020 at 18:58, on Zulip):

:+1:

Santiago Pastorino (Mar 09 2020 at 18:59, on Zulip):

@mark-i-m let me know when the rustc-guide-redirect repo work is done

Santiago Pastorino (Mar 09 2020 at 19:00, on Zulip):

mark-i-m said:

And renaming the submodule in rust-lang/rust is just a normal PR

ahh now I see why are you commenting this :), yes I know that's a normal PR

Santiago Pastorino (Mar 09 2020 at 19:01, on Zulip):

anyway, just moved that thing up because after renaming I'd need to adjust some things in rust-lang/rust existing PR

Santiago Pastorino (Mar 09 2020 at 19:01, on Zulip):

and include the submodule stuff too

mark-i-m (Mar 09 2020 at 19:07, on Zulip):

One other thing: do we want to move rustc-dev-guide.rust-lang.org or not?

mark-i-m (Mar 09 2020 at 19:08, on Zulip):

If so, we should decide that now

mark-i-m (Mar 09 2020 at 19:08, on Zulip):

And update all the PRs

Santiago Pastorino (Mar 09 2020 at 19:18, on Zulip):

@simulacrum asked us to ping him

mark-i-m (Mar 09 2020 at 19:18, on Zulip):

?

Santiago Pastorino (Mar 09 2020 at 19:18, on Zulip):

but @mark-i-m I don't think we should change the PRs

Santiago Pastorino (Mar 09 2020 at 19:18, on Zulip):

if I'm not wrong @simulacrum asked us to ping him to create that subdomain?

simulacrum (Mar 09 2020 at 19:19, on Zulip):

Yeah, I can create it in an hour or so

Santiago Pastorino (Mar 09 2020 at 19:19, on Zulip):

my guess is that we should still have rust-lang.github.io/rustc-dev-guide and that new subdomain @simulacrum will create will redirect to rustc-dev-guide.rust-lang.org

Santiago Pastorino (Mar 09 2020 at 19:19, on Zulip):

is this ^^^ right @simulacrum ?

simulacrum (Mar 09 2020 at 19:20, on Zulip):

Vice versa I think

Santiago Pastorino (Mar 09 2020 at 19:20, on Zulip):

sorry I wrote it very badly

Santiago Pastorino (Mar 09 2020 at 19:20, on Zulip):

fixed it

simulacrum (Mar 09 2020 at 19:21, on Zulip):

.rust-lang.org will be canonical

simulacrum (Mar 09 2020 at 19:21, on Zulip):

And everything redirects to that

mark-i-m (Mar 09 2020 at 19:21, on Zulip):

@Santiago Pastorino I'm not sure I understand why we would do that?

Santiago Pastorino (Mar 09 2020 at 19:22, on Zulip):

sorry, hehe I'm saying this very wrongly

Santiago Pastorino (Mar 09 2020 at 19:22, on Zulip):

yeah .rust-lang.org will be canonical

Santiago Pastorino (Mar 09 2020 at 19:22, on Zulip):

the wrong word is redirecting

Santiago Pastorino (Mar 09 2020 at 19:23, on Zulip):

it's just that we configure a cname for rustc-dev-guide.rust-lang.org to point to rust-lang.github.io/rustc-dev-guide

Santiago Pastorino (Mar 09 2020 at 19:23, on Zulip):

sorry was using a lot of imprecise words :)

Santiago Pastorino (Mar 09 2020 at 19:24, on Zulip):

so yeah, if we were doing that we need to change all the PRs

mark-i-m (Mar 09 2020 at 19:26, on Zulip):

I'm still not sure I understand (mostly because I don't understand cnames)... but anyway the question now becomes should we do it?

Santiago Pastorino (Mar 09 2020 at 19:29, on Zulip):

basically we would be visiting always the url rustc-dev-guide.rust-lang.org

Santiago Pastorino (Mar 09 2020 at 19:29, on Zulip):

all the links would point there

Santiago Pastorino (Mar 09 2020 at 19:29, on Zulip):

but the real thing would be github pages, the one that lives in rust-lang.github.io/rustc-dev-guide

Santiago Pastorino (Mar 09 2020 at 19:30, on Zulip):

it's "kind of" adding a A record to rustc-dev-guide.rust-lang.org with the IP address of rust-lang.github.io/rustc-dev-guide

mark-i-m (Mar 09 2020 at 19:31, on Zulip):

Ah, I see

mark-i-m (Mar 09 2020 at 19:31, on Zulip):

yeah, I think that would be goood

Santiago Pastorino (Mar 09 2020 at 19:33, on Zulip):

ok, anyway we need to decide if we want to use that url

Santiago Pastorino (Mar 09 2020 at 19:33, on Zulip):

I have no idea, I guess that's something that @simulacrum may have better answers

Santiago Pastorino (Mar 09 2020 at 19:34, on Zulip):

asking Niko too

Santiago Pastorino (Mar 09 2020 at 19:34, on Zulip):

I have no idea when github pages like urls are peferred and when subdomains under rust-lang.org

Santiago Pastorino (Mar 09 2020 at 19:35, on Zulip):

Niko said :+1:

Santiago Pastorino (Mar 09 2020 at 19:35, on Zulip):

given that simulacrum suggested those, pretty sure he will agree also :)

simulacrum (Mar 09 2020 at 19:36, on Zulip):

I am in favor of stable urls which don't depend on GitHub pages generally

Santiago Pastorino (Mar 09 2020 at 19:37, on Zulip):

:+1:

Santiago Pastorino (Mar 09 2020 at 19:38, on Zulip):

so I can update my PRs which basically are ... the ones in rust-lang/rustc-guide and rust-lang/rust

Santiago Pastorino (Mar 09 2020 at 19:38, on Zulip):

I guess most of the work is on @Chris Simpkins shoulders

Santiago Pastorino (Mar 09 2020 at 19:38, on Zulip):

let's see what Chris says :)

Santiago Pastorino (Mar 09 2020 at 19:39, on Zulip):

but url renames would just be running a sed command over the project so shouldn't be too bad :)

mark-i-m (Mar 09 2020 at 20:43, on Zulip):

Ok, https://github.com/rust-lang/rustc-guide-redirect is ready-ish...

mark-i-m (Mar 09 2020 at 20:44, on Zulip):

I wrote a little bash script (rename.sh) that generates the right files

mark-i-m (Mar 09 2020 at 20:44, on Zulip):

Everything is pushed

mark-i-m (Mar 09 2020 at 20:45, on Zulip):

I also updated the links to use rustc-dev-guide.rust-lang.org, but we can revert the last commit if we decide not to do that

mark-i-m (Mar 09 2020 at 20:45, on Zulip):

Could somebody take a look and verify that things look reasonable?

mark-i-m (Mar 09 2020 at 20:48, on Zulip):

Other than that, it seems like we are leaning towards:

@WG-learning shall we finalize this plan? Does somebody have an objection or concern?

Santiago Pastorino (Mar 09 2020 at 20:53, on Zulip):

this looks good

Santiago Pastorino (Mar 09 2020 at 20:53, on Zulip):

now we need to update all the PRs

Santiago Pastorino (Mar 09 2020 at 20:53, on Zulip):

would wait for @Chris Simpkins to confirm if they are able to update the PRs to point to rustc-dev-guide.rust-lang.org

Santiago Pastorino (Mar 09 2020 at 20:54, on Zulip):

@simulacrum let us know when you setup rustc-dev-guide.rust-lang.org

simulacrum (Mar 09 2020 at 20:54, on Zulip):

let me get the ball rolling on that

Yuki Okushi (Mar 09 2020 at 20:55, on Zulip):

just forked and deployed it to my github pages, seems fine: https://johntitor.github.io/rustc-guide-redirect/

mark-i-m (Mar 09 2020 at 21:00, on Zulip):

blog post has been updated

Santiago Pastorino (Mar 09 2020 at 21:01, on Zulip):

have updated steps here https://github.com/rust-lang/rustc-guide/issues/602

mark-i-m (Mar 09 2020 at 21:03, on Zulip):

update all the PRs to point links to rust-lang.github.io/rustc-dev-guide instead of rust-lang.github.io/rustc-dev-guide

@Santiago Pastorino Is it rustc-dev-guide.rlo or rlo/rustc-dev-guide? I though it was the former?

simulacrum (Mar 09 2020 at 21:03, on Zulip):

okay, rustc-dev-guide.rust-lang.org should be ready, we'll need to add a CNAME file with rustc-dev-guide.rust-lang.org in it

Santiago Pastorino (Mar 09 2020 at 21:04, on Zulip):

@simulacrum we can do that just now

mark-i-m (Mar 09 2020 at 21:04, on Zulip):

@simulacrum Thanks! We add this file in repo, right?

simulacrum (Mar 09 2020 at 21:04, on Zulip):

yes, it should go in the rustc-guide repo

mark-i-m (Mar 09 2020 at 21:05, on Zulip):

And we also update the "custom domains" setting in gh settings page, right?

Santiago Pastorino (Mar 09 2020 at 21:06, on Zulip):

mark-i-m said:

update all the PRs to point links to rust-lang.github.io/rustc-dev-guide instead of rust-lang.github.io/rustc-dev-guide

Santiago Pastorino Is it rustc-dev-guide.rlo or rlo/rustc-dev-guide? I though it was the former?

update all the PRs to point links to rustc-dev-guide.rust-lang.org instead of rust-lang.github.io/rustc-dev-guide

Santiago Pastorino (Mar 09 2020 at 21:06, on Zulip):

just updated it, I think it was a wrong copy & paste

mark-i-m (Mar 09 2020 at 21:06, on Zulip):

Thanks, I was just making sure I didn't misunderstand

simulacrum (Mar 09 2020 at 21:07, on Zulip):

(note that repository does not need to be renamed for the CNAME to work)

mark-i-m (Mar 09 2020 at 21:08, on Zulip):

@simulacrum And we also update the "custom domains" setting in gh settings page, right?

simulacrum (Mar 09 2020 at 21:08, on Zulip):

that's the same as the CNAME file

simulacrum (Mar 09 2020 at 21:08, on Zulip):

if you do it through the UI it'll add a commit updating the CNAME file

mark-i-m (Mar 09 2020 at 21:08, on Zulip):

Like this? https://github.com/rust-lang/rustc-guide/pull/606

simulacrum (Mar 09 2020 at 21:10, on Zulip):

looks correct to me

Santiago Pastorino (Mar 09 2020 at 21:11, on Zulip):

merged

Santiago Pastorino (Mar 09 2020 at 21:11, on Zulip):

now we need to update PRs and after it's done we can just rename the repo

Chris Simpkins (Mar 09 2020 at 21:12, on Zulip):

Just catching up here. As I understand it, we need to update all renaming PR's to point to https://rustc-dev-guide.rust-lang.org/?

Chris Simpkins (Mar 09 2020 at 21:17, on Zulip):

I saw Santiago's PR. It looks like my above statement is correct. Starting on the PR updates now.

mark-i-m (Mar 09 2020 at 21:18, on Zulip):

@Chris Simpkins Yes, that's correct. Thank you!

Santiago Pastorino (Mar 09 2020 at 21:18, on Zulip):

@Chris Simpkins I've just ran git grep -l 'rust-lang.github.io\/rustc-dev-guide' | xargs sed -i 's/rust-lang.github.io\/rustc-dev-guide/rustc-dev-guide.rust-lang.org/g'

Santiago Pastorino (Mar 09 2020 at 21:18, on Zulip):

on rustc-guide

Santiago Pastorino (Mar 09 2020 at 21:18, on Zulip):

doing it on rust repo

Chris Simpkins (Mar 09 2020 at 21:19, on Zulip):

Great, thank you! I'll try it on my PR's and see if this misses anything.

Santiago Pastorino (Mar 09 2020 at 21:20, on Zulip):

done over rust repo too

Santiago Pastorino (Mar 09 2020 at 21:20, on Zulip):

mine should be ready

Santiago Pastorino (Mar 09 2020 at 21:20, on Zulip):

checking rust repo, if others want to review just in case would be great :)

simulacrum (Mar 09 2020 at 21:26, on Zulip):

hm, odd that it's not yet working

simulacrum (Mar 09 2020 at 21:26, on Zulip):

maybe just propagating?

mark-i-m (Mar 09 2020 at 21:27, on Zulip):

@simulacrum I think I have had that experience in that past...

simulacrum (Mar 09 2020 at 21:27, on Zulip):

let me try setting it through the UI

Yuki Okushi (Mar 09 2020 at 21:28, on Zulip):

Santiago Pastorino said:

checking rust repo, if others want to review just in case would be great :)

left a comment on github

mark-i-m (Mar 09 2020 at 21:31, on Zulip):

@Yuki Okushi You seem to be beating me to everything today :P

simulacrum (Mar 09 2020 at 21:31, on Zulip):

hm, okay https seems broken

mark-i-m (Mar 09 2020 at 21:32, on Zulip):

The new domain seems to be working now, but SSL error: Error code: SSL_ERROR_BAD_CERT_DOMAIN

Santiago Pastorino (Mar 09 2020 at 21:32, on Zulip):

Yuki Okushi said:

Santiago Pastorino said:

checking rust repo, if others want to review just in case would be great :)

left a comment on github

ohh seems like my repo was dirty because the command I've ran shouldn't have this problem

Santiago Pastorino (Mar 09 2020 at 21:32, on Zulip):

anyway, fixing it and thanks for noticing

Chris Simpkins (Mar 09 2020 at 21:33, on Zulip):

PR's in progress. I won't post each individually. Will post when all are complete. (blog done so far...)

simulacrum (Mar 09 2020 at 21:33, on Zulip):

I think presumably the certificate needs to be reissued from let's encrypt on github's side

simulacrum (Mar 09 2020 at 21:34, on Zulip):

afaict, everything is correct on our end

Chris Simpkins (Mar 09 2020 at 21:35, on Zulip):

rustlang nursery PR is @LeSeulArtichaut 's

Santiago Pastorino (Mar 09 2020 at 21:36, on Zulip):

@mark-i-m I saw you made some suggestions here https://github.com/rust-lang/rustc-guide/pull/601#pullrequestreview-371534504

Santiago Pastorino (Mar 09 2020 at 21:36, on Zulip):

should we do that in this PR or a separate one?

Santiago Pastorino (Mar 09 2020 at 21:36, on Zulip):

well github says that it's old, maybe I've pushed meanwhile?

simulacrum (Mar 09 2020 at 21:36, on Zulip):

okay, I think that's all I need to do, will get back to other tasks. my guess is that DNS is not yet propagated to let's encrypt or (some parts of) github

mark-i-m (Mar 09 2020 at 21:36, on Zulip):

Would prefer if we could do it here since we are updating the links... I just redid the suggestions

mark-i-m (Mar 09 2020 at 21:36, on Zulip):

@simulacrum Thanks for the help!

Chris Simpkins (Mar 09 2020 at 21:37, on Zulip):

Thank you @simulacrum !

Santiago Pastorino (Mar 09 2020 at 21:37, on Zulip):

ok, applied

Santiago Pastorino (Mar 09 2020 at 21:38, on Zulip):

ok so my changes are done

Santiago Pastorino (Mar 09 2020 at 21:38, on Zulip):

I'd suggest to finish this tomorrow

Santiago Pastorino (Mar 09 2020 at 21:38, on Zulip):

I mean to rename tomorrow, it's a bit late for me now

simulacrum (Mar 09 2020 at 21:39, on Zulip):

CT logs indicate a certificate was issued https://transparencyreport.google.com/https/certificates/uvqoTXC2iG8F6LQwHkwLY5Diyr5d3rNIWT6pEaRytKs%3D

Santiago Pastorino (Mar 09 2020 at 21:39, on Zulip):

anyway, unsure how much time @Chris Simpkins needs for this but if tomorrow is ok we can rename tomorrow

Chris Simpkins (Mar 09 2020 at 21:40, on Zulip):

I will finish all of my PR's in the next hour. Working through them now

simulacrum (Mar 09 2020 at 21:41, on Zulip):

and certificate is ready

mark-i-m (Mar 09 2020 at 21:42, on Zulip):

@simulacrum Can confirm. I'm no longer getting any https errors :tada:

mark-i-m (Mar 09 2020 at 21:43, on Zulip):

I don't mind doing it tomorrow.

Yuki Okushi (Mar 09 2020 at 21:45, on Zulip):

either day works for me

mark-i-m (Mar 09 2020 at 21:45, on Zulip):

In fact, I think we can merge the PRs whenever we want, since the rustc-dev-guide.rlo site is already up

mark-i-m (Mar 09 2020 at 21:46, on Zulip):

Shall we just mark them all as ready for review in the respective repos? We can do that actual rename and release the blog post tomororw

Chris Simpkins (Mar 09 2020 at 21:47, on Zulip):

Do we want to update the "previous" repository? It looks like this is deprecated and out of commission. I don't see any updates since 2018

Chris Simpkins (Mar 09 2020 at 21:47, on Zulip):

rust-lang/prev.rust-lang.org

mark-i-m (Mar 09 2020 at 21:47, on Zulip):

prev.rlo ?

mark-i-m (Mar 09 2020 at 21:48, on Zulip):

no, i don't think so

mark-i-m (Mar 09 2020 at 21:48, on Zulip):

this is the old website

mark-i-m (Mar 09 2020 at 21:48, on Zulip):

(which interestingly is still live)

mark-i-m (Mar 09 2020 at 21:54, on Zulip):

@Chris Simpkins It looks like the const-eval PR was previously merged with the wrong links

mark-i-m (Mar 09 2020 at 21:55, on Zulip):

I can put up a new PR if you would like

Chris Simpkins (Mar 09 2020 at 21:55, on Zulip):

whoops, I will submit a new one. Forgot that Ralf merged

Santiago Pastorino (Mar 09 2020 at 21:59, on Zulip):

let's merge all the PRs actually

Santiago Pastorino (Mar 09 2020 at 21:59, on Zulip):

all but the one to rust-lang/rust

Chris Simpkins (Mar 09 2020 at 22:04, on Zulip):

OK, all of mine are updated. I added suggestions on the @LeSeulArtichaut PR https://github.com/rust-lang-nursery/rust-lang-nursery.github.io/pull/4

mark-i-m (Mar 09 2020 at 22:04, on Zulip):

Perhaps change the PR names to remove "do not merge yet" ?

Chris Simpkins (Mar 09 2020 at 22:04, on Zulip):

OK to notify threads that we are ready for merge?

mark-i-m (Mar 09 2020 at 22:05, on Zulip):

Yep SGTM

Santiago Pastorino (Mar 09 2020 at 22:05, on Zulip):

there are some checkboxes unticked here https://github.com/rust-lang/rustc-guide/issues/602

Santiago Pastorino (Mar 09 2020 at 22:05, on Zulip):

unsure why is that

Santiago Pastorino (Mar 09 2020 at 22:05, on Zulip):

in the prepare PR section

Santiago Pastorino (Mar 09 2020 at 22:06, on Zulip):

I'm still around if the rest ok, we can just rename

LeSeulArtichaut (Mar 09 2020 at 22:07, on Zulip):

Do we merge everything now?

Chris Simpkins (Mar 09 2020 at 22:07, on Zulip):

@Santiago Pastorino I unchecked so that I could go back through all of mine to update. They should be checked now. The only open one is the rustlang nursery. We will need to wait on LeSeulArtichaut on that one

LeSeulArtichaut (Mar 09 2020 at 22:07, on Zulip):

Nvm got my answer

LeSeulArtichaut (Mar 09 2020 at 22:07, on Zulip):

I changed it rn

mark-i-m (Mar 09 2020 at 22:11, on Zulip):

@Santiago Pastorino either way is ok, we don't want you to lose sleep, but we can do it now if everything is ready

LeSeulArtichaut (Mar 09 2020 at 22:14, on Zulip):

Now, good renaming everyone, I have an important meeting with my pillow ;)

mark-i-m (Mar 09 2020 at 22:14, on Zulip):

Honestly, let's just wait until tomorrow.

mark-i-m (Mar 09 2020 at 22:15, on Zulip):

We can open all the PRs and notify that they are ready to merge though

LeSeulArtichaut (Mar 09 2020 at 22:16, on Zulip):

Let me know if I can do something tomorrow, when you'll be sleeping eventually

Santiago Pastorino (Mar 09 2020 at 22:16, on Zulip):

yeah, let's do it tomorrow

Santiago Pastorino (Mar 09 2020 at 22:16, on Zulip):

here is not very late but it's time that I'm usually not around anymore :)

LeSeulArtichaut (Mar 09 2020 at 22:16, on Zulip):

No need to rush it anyway

LeSeulArtichaut (Mar 09 2020 at 22:17, on Zulip):

(I'm going to get up and have 100 unread GH notifs, I can feel it)

Chris Simpkins (Mar 09 2020 at 22:17, on Zulip):

OK, all PR's updated, all titles updated to remove the holds. All threads pinged to notify ready for review.

mark-i-m (Mar 09 2020 at 22:17, on Zulip):

Let me know if I can do something tomorrow, when you'll be sleeping eventually

I never sleep :eye:

mark-i-m (Mar 09 2020 at 22:17, on Zulip):

:P

Chris Simpkins (Mar 09 2020 at 22:18, on Zulip):

:clap: We're close

Chris Simpkins (Mar 09 2020 at 22:21, on Zulip):

I'm around and available this evening if there is anything left to do before tomorrow's moves. Don't hesitate to ping me. Otw, til tomorrow!

Chris Simpkins (Mar 10 2020 at 12:42, on Zulip):

https://rustc-dev-guide.rust-lang.org/ seems to be down. I am seeing 404 pages

Chris Simpkins (Mar 10 2020 at 12:55, on Zulip):

Yuki is addressing it https://github.com/rust-lang/rustc-guide/issues/602#issuecomment-597069198

Santiago Pastorino (Mar 10 2020 at 13:02, on Zulip):

merged

Yuki Okushi (Mar 10 2020 at 13:05, on Zulip):

okay, seems fixed

Santiago Pastorino (Mar 10 2020 at 13:05, on Zulip):

yep

Santiago Pastorino (Mar 10 2020 at 13:05, on Zulip):

ok, so what are the next steps?

Santiago Pastorino (Mar 10 2020 at 13:06, on Zulip):

I'm going to check how many PRs are already merged and which ones are missing

Chris Simpkins (Mar 10 2020 at 13:06, on Zulip):

Still a number of renaming PR's that need to be merged

Santiago Pastorino (Mar 10 2020 at 13:06, on Zulip):

there are some that shouldn't be merged like rust-lang/rust but the rest should, right?

Chris Simpkins (Mar 10 2020 at 13:08, on Zulip):

compiler-team, rust-forge, chalk need to be merged

Santiago Pastorino (Mar 10 2020 at 13:08, on Zulip):

pinging niko

Yuki Okushi (Mar 10 2020 at 13:08, on Zulip):

also blog post should be merged after renaming, I think

Santiago Pastorino (Mar 10 2020 at 13:08, on Zulip):

why after?

Santiago Pastorino (Mar 10 2020 at 13:08, on Zulip):

ahh the actual post

Santiago Pastorino (Mar 10 2020 at 13:08, on Zulip):

because there's a pr to the blog about changing the urls

Santiago Pastorino (Mar 10 2020 at 13:09, on Zulip):

https://github.com/rust-lang/blog.rust-lang.org/pull/535

Santiago Pastorino (Mar 10 2020 at 13:09, on Zulip):

this one should be merged now

Yuki Okushi (Mar 10 2020 at 13:09, on Zulip):

yeah, #535 can be merged

Chris Simpkins (Mar 10 2020 at 13:12, on Zulip):

It looks like Mark has the rustc-guide-redirect repo set to go https://github.com/rust-lang/rustc-guide-redirect

Chris Simpkins (Mar 10 2020 at 13:13, on Zulip):

Have we identified someone with Travis access? Does the site build fail until Travis is updated?

Santiago Pastorino (Mar 10 2020 at 13:15, on Zulip):

unsure I get what you meant?

Santiago Pastorino (Mar 10 2020 at 13:16, on Zulip):

which site is failing?

Chris Simpkins (Mar 10 2020 at 13:16, on Zulip):

Someone posted an item in our transition TODO list: "update travis CI configs as needed"

Santiago Pastorino (Mar 10 2020 at 13:16, on Zulip):

no idea what's that? cc @Yuki Okushi

Chris Simpkins (Mar 10 2020 at 13:17, on Zulip):

Wondering if the automated static site build fails if we don't have access to Travis dashboard for configs

Chris Simpkins (Mar 10 2020 at 13:17, on Zulip):

on new rustc-dev-guide repo

Yuki Okushi (Mar 10 2020 at 13:18, on Zulip):

I think that checkbox is for this: https://github.com/rust-lang/rustc-guide/pull/601#discussion_r389977160

Santiago Pastorino (Mar 10 2020 at 13:18, on Zulip):

right now we are waiting for someone to merge:

Santiago Pastorino (Mar 10 2020 at 13:18, on Zulip):

https://github.com/rust-lang/chalk/pull/344

Santiago Pastorino (Mar 10 2020 at 13:18, on Zulip):

https://github.com/rust-lang/rust-forge/pull/314

Santiago Pastorino (Mar 10 2020 at 13:18, on Zulip):

https://github.com/rust-lang/blog.rust-lang.org/pull/535

Santiago Pastorino (Mar 10 2020 at 13:18, on Zulip):

after that we can proceed with the renaming and the rest

Santiago Pastorino (Mar 10 2020 at 13:19, on Zulip):

Yuki Okushi said:

I think that checkbox is for this: https://github.com/rust-lang/rustc-guide/pull/601#discussion_r389977160

ok, who can do that?

Yuki Okushi (Mar 10 2020 at 13:20, on Zulip):

Santiago Pastorino said:

Yuki Okushi said:

I think that checkbox is for this: https://github.com/rust-lang/rustc-guide/pull/601#discussion_r389977160

ok, who can do that?

I guess travis will sync repository so action from our side is unneeded? let's see what's happen after renaming

Chris Simpkins (Mar 10 2020 at 13:21, on Zulip):

ok, who can do that?

It looks like there was concern that the Github token needs to be set in the Travis admin panel on the new rustc-dev-guide repository

Santiago Pastorino (Mar 10 2020 at 13:21, on Zulip):

yeap, to be honest unsure

Santiago Pastorino (Mar 10 2020 at 13:22, on Zulip):

Chris Simpkins said:

ok, who can do that?

It looks like there was concern that the Github token needs to be set in the Travis admin panel on the new rustc-dev-guide repository

cc @simulacrum

simulacrum (Mar 10 2020 at 13:23, on Zulip):

Uh, do we know where the token came from previously?

Yuki Okushi (Mar 10 2020 at 13:24, on Zulip):

it's Niko's token, I think

simulacrum (Mar 10 2020 at 13:24, on Zulip):

IIRC renaming a repository doesn't lead to travis problems though

simulacrum (Mar 10 2020 at 13:25, on Zulip):

let's proceed and if there's a problem I can generate a token if needed

Santiago Pastorino (Mar 10 2020 at 13:41, on Zulip):

@simulacrum do you have write access in any of these repos

simulacrum (Mar 10 2020 at 13:41, on Zulip):

I should have it for all of rust-lang.

simulacrum (Mar 10 2020 at 13:42, on Zulip):

(and can grant access if needed)

Santiago Pastorino (Mar 10 2020 at 13:42, on Zulip):

Santiago Pastorino said:

https://github.com/rust-lang/chalk/pull/344

starting here ^^^

Santiago Pastorino (Mar 10 2020 at 13:42, on Zulip):

we need to merge these PRs

Santiago Pastorino (Mar 10 2020 at 13:43, on Zulip):

simulacrum said:

(and can grant access if needed)

hmm some times I think it would be useful if I had write access in some repos

Santiago Pastorino (Mar 10 2020 at 13:44, on Zulip):

but still I think this was discussed and if I'm not wrong the current policy disallows

Santiago Pastorino (Mar 10 2020 at 13:44, on Zulip):

I have write access in rust-lang/rust and a couple of more places

simulacrum (Mar 10 2020 at 13:44, on Zulip):

merged 3?

Santiago Pastorino (Mar 10 2020 at 13:44, on Zulip):

yes

Santiago Pastorino (Mar 10 2020 at 13:44, on Zulip):

3

Santiago Pastorino (Mar 10 2020 at 13:44, on Zulip):

cool

simulacrum (Mar 10 2020 at 13:45, on Zulip):

I think of these forge is the only one I would feel fine giving access to but seems not too important for now

Santiago Pastorino (Mar 10 2020 at 13:45, on Zulip):

yeap

Santiago Pastorino (Mar 10 2020 at 13:45, on Zulip):

ok renaming ...

Santiago Pastorino (Mar 10 2020 at 13:47, on Zulip):

done

Santiago Pastorino (Mar 10 2020 at 13:47, on Zulip):

renamed both projects

Santiago Pastorino (Mar 10 2020 at 13:49, on Zulip):

waiting for CI https://github.com/rust-lang/rustc-dev-guide/pull/601

Santiago Pastorino (Mar 10 2020 at 13:50, on Zulip):

seems to be working as intended

Santiago Pastorino (Mar 10 2020 at 13:50, on Zulip):

gonna merge the rustc-dev-guide PR and fix the rust-lang/rust PR

Yuki Okushi (Mar 10 2020 at 13:51, on Zulip):

@Santiago Pastorino also could we update rustc-dev-guide submodule in rust-lang/rust PR?

Santiago Pastorino (Mar 10 2020 at 13:51, on Zulip):

yeah need to do all that

Santiago Pastorino (Mar 10 2020 at 13:51, on Zulip):

rustc-dev-guide PR is failing

Santiago Pastorino (Mar 10 2020 at 13:52, on Zulip):

checking what's going on

Yuki Okushi (Mar 10 2020 at 13:52, on Zulip):

hm, CI cannot find our repo yet: https://travis-ci.com/rust-lang/rustc-dev-guide

Santiago Pastorino (Mar 10 2020 at 13:53, on Zulip):

yep, trying to re-run checks

Yuki Okushi (Mar 10 2020 at 13:53, on Zulip):

could you try to rebase and push?

simulacrum (Mar 10 2020 at 13:54, on Zulip):

uh, travis IIRC doesn't change the repo name

Yuki Okushi (Mar 10 2020 at 13:54, on Zulip):

I guess pushing will make travis notice the repo

simulacrum (Mar 10 2020 at 13:54, on Zulip):

let me try to edit travis a bit

simulacrum (Mar 10 2020 at 13:56, on Zulip):

okay I think I convinced travis of reality

Yuki Okushi (Mar 10 2020 at 13:57, on Zulip):

yeah, works well :tada:

Santiago Pastorino (Mar 10 2020 at 13:57, on Zulip):

cool, I also rebased and force pushed

Santiago Pastorino (Mar 10 2020 at 14:01, on Zulip):

it's green

Santiago Pastorino (Mar 10 2020 at 14:01, on Zulip):

@Yuki Okushi can you approve?

Yuki Okushi (Mar 10 2020 at 14:01, on Zulip):

done

Santiago Pastorino (Mar 10 2020 at 14:01, on Zulip):

merged

Santiago Pastorino (Mar 10 2020 at 14:02, on Zulip):

https://github.com/rust-lang/rust/pull/69747

Santiago Pastorino (Mar 10 2020 at 14:02, on Zulip):

I don't think I need to do anything else

Santiago Pastorino (Mar 10 2020 at 14:02, on Zulip):

just re-run checks

Santiago Pastorino (Mar 10 2020 at 14:04, on Zulip):

I think for the submodule what was already done https://github.com/rust-lang/rust/pull/69747/files#diff-8903239df476d7401cf9e76af0252622L34 is enough

Yuki Okushi (Mar 10 2020 at 14:04, on Zulip):

@Santiago Pastorino submodule points to old commit, it'd be great if it would point to current master

Santiago Pastorino (Mar 10 2020 at 14:04, on Zulip):

ahh right, that's true :)

Santiago Pastorino (Mar 10 2020 at 14:06, on Zulip):

done

Santiago Pastorino (Mar 10 2020 at 14:10, on Zulip):

https://twitter.com/spastorino/status/1237380203636314112

Santiago Pastorino (Mar 10 2020 at 14:10, on Zulip):

:)

Chris Simpkins (Mar 10 2020 at 14:10, on Zulip):

Checking for links that are missing

Chris Simpkins (Mar 10 2020 at 14:11, on Zulip):

This includes reference to rustc-guide instead of rustc-dev-guide: https://github.com/rust-lang/www.rust-lang.org/blob/1999d8b2266f541911af9b5840a81617ea339df5/locales/en-US/teams.ftl#L3

Chris Simpkins (Mar 10 2020 at 14:12, on Zulip):

It looks like the rest all rust, rust-gha, or the previous website repo

Chris Simpkins (Mar 10 2020 at 14:13, on Zulip):

I will submit a PR on rust-lang/www.rust-lang.org for the rename.

Santiago Pastorino (Mar 10 2020 at 14:14, on Zulip):

:+1:

Santiago Pastorino (Mar 10 2020 at 14:14, on Zulip):

it's possible that meanwhile we pushed PRs some links were added

Santiago Pastorino (Mar 10 2020 at 14:15, on Zulip):

update travis CI configs as needed this doesn't seem to be needed then?

Chris Simpkins (Mar 10 2020 at 14:15, on Zulip):

Santiago Pastorino said:

update travis CI configs as needed this doesn't seem to be needed then?

Sorry, was away during the conversation with @simulacrum. Did we need to do something on Travis and it was done?

simulacrum (Mar 10 2020 at 14:16, on Zulip):

uh, I sync'd travis but that was it

simulacrum (Mar 10 2020 at 14:16, on Zulip):

if things are working then great :)

Santiago Pastorino (Mar 10 2020 at 14:16, on Zulip):

ok checking that item

Chris Simpkins (Mar 10 2020 at 14:17, on Zulip):

Try a test commit to see if rustc-dev-guide builds?

Chris Simpkins (Mar 10 2020 at 14:17, on Zulip):

then consider that box checked?

Yuki Okushi (Mar 10 2020 at 14:18, on Zulip):

I think it works well? https://github.com/rust-lang/rustc-dev-guide/tree/gh-pages

mark-i-m (Mar 10 2020 at 14:19, on Zulip):

Should we merge the blog post and announce on internals?

Yuki Okushi (Mar 10 2020 at 14:20, on Zulip):

yep

Santiago Pastorino (Mar 10 2020 at 14:20, on Zulip):

:+1:

Santiago Pastorino (Mar 10 2020 at 14:21, on Zulip):

hold on

Santiago Pastorino (Mar 10 2020 at 14:21, on Zulip):

@mark-i-m another thought before you post

Santiago Pastorino (Mar 10 2020 at 14:22, on Zulip):

@nikomatsakis was originally in favor of making a change also to the wg name

Santiago Pastorino (Mar 10 2020 at 14:22, on Zulip):

I think the name originally had an intention and it's now just rustc-dev-guide focused

Santiago Pastorino (Mar 10 2020 at 14:22, on Zulip):

why not calling the working group also wg-rustc-dev-guide?

mark-i-m (Mar 10 2020 at 14:23, on Zulip):

i agree, but i think that also entails a lot of renaming (though not as much) and it seems mildly orthogonal

Santiago Pastorino (Mar 10 2020 at 14:23, on Zulip):

yeah, so ...

Santiago Pastorino (Mar 10 2020 at 14:24, on Zulip):

what I meant is ... if we agree on this as it seems we do

Santiago Pastorino (Mar 10 2020 at 14:24, on Zulip):

maybe mention that in the post

Santiago Pastorino (Mar 10 2020 at 14:24, on Zulip):

we will be renaming wg-learning into wg-rustc-dev-guide

Santiago Pastorino (Mar 10 2020 at 14:24, on Zulip):

so people are already aware that zulip channel will change

Santiago Pastorino (Mar 10 2020 at 14:24, on Zulip):

etc

Chris Simpkins (Mar 10 2020 at 14:26, on Zulip):

https://github.com/rust-lang/www.rust-lang.org/pull/1029 updates names in www.rust-lang.org repo

Santiago Pastorino (Mar 10 2020 at 14:28, on Zulip):

@simulacrum can you merge? :)

simulacrum (Mar 10 2020 at 14:28, on Zulip):

I do not have the necessary knowledge to do that for www, @Pietro Albini would work though I think.

simulacrum (Mar 10 2020 at 14:29, on Zulip):

It's also not urgent AFAIK?

Pietro Albini (Mar 10 2020 at 14:30, on Zulip):

btw the move broke rust-lang/rust's CI

Pietro Albini (Mar 10 2020 at 14:30, on Zulip):

since the commit didn't exist anymore in the submodule

Santiago Pastorino (Mar 10 2020 at 14:30, on Zulip):

yeah there's a PR

Santiago Pastorino (Mar 10 2020 at 14:30, on Zulip):

the change on www it's just a change in the name, nothing fancy

Pietro Albini (Mar 10 2020 at 14:30, on Zulip):

yeah but there is also stable and the (already branched off) beta

Santiago Pastorino (Mar 10 2020 at 14:30, on Zulip):

or did I miss something?

Pietro Albini (Mar 10 2020 at 14:31, on Zulip):

oh I'm not talking about the www PR

Santiago Pastorino (Mar 10 2020 at 14:31, on Zulip):

yeah no I was answering Mark :)

Santiago Pastorino (Mar 10 2020 at 14:31, on Zulip):

my answer to you was only that it was a PR

Santiago Pastorino (Mar 10 2020 at 14:31, on Zulip):

https://github.com/rust-lang/rust/pull/69747

Santiago Pastorino (Mar 10 2020 at 14:31, on Zulip):

but yeah, you're also mentioning beta and stable

Pietro Albini (Mar 10 2020 at 14:32, on Zulip):

I pushed the website to a branch in rustc-guide called old-content and protected it

Chris Simpkins (Mar 10 2020 at 14:32, on Zulip):

Santiago Pastorino said:

the change on www it's just a change in the name, nothing fancy

correct.

Pietro Albini (Mar 10 2020 at 14:32, on Zulip):

that should "fix" the issue for stable and beta hopefully

simulacrum (Mar 10 2020 at 14:33, on Zulip):

Pietro Albini said:

since the commit didn't exist anymore in the submodule

hm, I would've expected us to not force push anything and generally speaking github forwards renames of repositories? so that surprises me.

Pietro Albini (Mar 10 2020 at 14:34, on Zulip):

@simulacrum yes but they created a new repo called rustc-guide

Pietro Albini (Mar 10 2020 at 14:34, on Zulip):

which broke all github redirects

simulacrum (Mar 10 2020 at 14:34, on Zulip):

ah, I see

Santiago Pastorino (Mar 10 2020 at 14:35, on Zulip):

should we remove that?

simulacrum (Mar 10 2020 at 14:35, on Zulip):

I did not know we were doing so and that seems very confusing to me

Santiago Pastorino (Mar 10 2020 at 14:35, on Zulip):

the intention was to fix rust-lang.github.io/rustc-guide

simulacrum (Mar 10 2020 at 14:35, on Zulip):

the ship has perhaps sailed though

Pietro Albini (Mar 10 2020 at 14:35, on Zulip):

I'm not sure if the redirect will be reinstated if we deleted the repository

Pietro Albini (Mar 10 2020 at 14:35, on Zulip):

but I lean torwards a "no"

Chris Simpkins (Mar 10 2020 at 14:35, on Zulip):

Santiago Pastorino said:

we will be renaming wg-learning into wg-rustc-dev-guide

@mark-i-m @Santiago Pastorino Can we post a new thread for this? Interested to discuss this if it is up for discussion. There are opportunities for education about the compiler that exist outside of the Guide.

simulacrum (Mar 10 2020 at 14:35, on Zulip):

ah, so you know, what we can probably do

Santiago Pastorino (Mar 10 2020 at 14:35, on Zulip):

yeah, probably

simulacrum (Mar 10 2020 at 14:36, on Zulip):

is force push the new rustc-guide repo to have all the old commits as well

Pietro Albini (Mar 10 2020 at 14:36, on Zulip):

well we can rename rustc-dev-guide back to rustc-guide and then to rustc-dev-guide

simulacrum (Mar 10 2020 at 14:36, on Zulip):

and then have a huge commit which swaps the contents out for the new one

Pietro Albini (Mar 10 2020 at 14:36, on Zulip):

@simulacrum that's what I did :)

Pietro Albini (Mar 10 2020 at 14:36, on Zulip):

but in a separate branch

simulacrum (Mar 10 2020 at 14:36, on Zulip):

ah that works too

Santiago Pastorino (Mar 10 2020 at 14:36, on Zulip):

yeah makes sense then

Pietro Albini (Mar 10 2020 at 14:36, on Zulip):

https://github.com/rust-lang/rustc-guide/tree/old-content

Santiago Pastorino (Mar 10 2020 at 14:40, on Zulip):

this https://github.com/rust-lang/rust/pull/69747 is failing

mark-i-m (Mar 10 2020 at 14:40, on Zulip):

@Santiago Pastorino IMHO I would say let's leave renaming the WG out of this set of changes... and discuss when the dust has settled a bit

Santiago Pastorino (Mar 10 2020 at 14:40, on Zulip):

is that what you meant @Pietro Albini ?

Santiago Pastorino (Mar 10 2020 at 14:40, on Zulip):

https://dev.azure.com/rust-lang/rust/_build/results?buildId=22840&view=logs&j=74054d28-c774-5fab-ecc2-352fe71b230e&t=6fac545a-db64-5c3f-de7a-e9f2d46d7eae&l=1260

Santiago Pastorino (Mar 10 2020 at 14:40, on Zulip):

mark-i-m said:

Santiago Pastorino IMHO I would say let's leave renaming the WG out of this set of changes... and discuss when the dust has settled a bit

:+1:, we can make a new announcement about the wg

Pietro Albini (Mar 10 2020 at 14:42, on Zulip):

uh, one thing at the time

Pietro Albini (Mar 10 2020 at 14:43, on Zulip):

the issue I mentioned was that, since the repo was renamed and the redirect removed, the submodules on the rust-lang/rust repo were broken, and that was fixed by creating a old-content branch on the redirect repo

mark-i-m (Mar 10 2020 at 14:43, on Zulip):

So I don't understand what's currently going on with the redirects? Did we miss some of them? I thought we submitted PRs to everything

Pietro Albini (Mar 10 2020 at 14:43, on Zulip):

your issue is that another piece of infra is expecting that submodule to be called "rustc-guide"

Santiago Pastorino (Mar 10 2020 at 14:44, on Zulip):

Pietro Albini said:

the issue I mentioned was that, since the repo was renamed and the redirect removed, the submodules on the rust-lang/rust repo were broken, and that was fixed by creating a old-content branch on the redirect repo

yeah but I meant is that this https://dev.azure.com/rust-lang/rust/_build/results?buildId=22840&view=logs&j=74054d28-c774-5fab-ecc2-352fe71b230e&t=6fac545a-db64-5c3f-de7a-e9f2d46d7eae&l=1260 error?

Pietro Albini (Mar 10 2020 at 14:44, on Zulip):

nope, that's the second error I mentioned

Santiago Pastorino (Mar 10 2020 at 14:44, on Zulip):

which one?

Pietro Albini (Mar 10 2020 at 14:46, on Zulip):

your issue is that another piece of infra is expecting that submodule to be called "rustc-guide"

Pietro Albini (Mar 10 2020 at 14:46, on Zulip):

probably toolstate

mark-i-m (Mar 10 2020 at 14:48, on Zulip):

Ah, I think we didn't really search in rust-lang-nursery, did we?

Pietro Albini (Mar 10 2020 at 14:49, on Zulip):

no that's probably an error somewhere in the rustc code

Pietro Albini (Mar 10 2020 at 14:49, on Zulip):

but imo fixing that could wait a bit

Pietro Albini (Mar 10 2020 at 14:49, on Zulip):

what I'm more concerned about is that you created a new repo called https://github.com/rust-lang/rustc-guide

Pietro Albini (Mar 10 2020 at 14:49, on Zulip):

and that means all links to PRs, issues and code snippets are broken, because github won't redirect those anymore

mark-i-m (Mar 10 2020 at 14:51, on Zulip):

The new repo is intended to be full of redirects?

mark-i-m (Mar 10 2020 at 14:51, on Zulip):

oh, i see. you mean github issues etc?

Pietro Albini (Mar 10 2020 at 14:52, on Zulip):

yep

Pietro Albini (Mar 10 2020 at 14:52, on Zulip):

what we can probably do is move all the redirects to a rust-lang/rust-lang.github.io repository

Pietro Albini (Mar 10 2020 at 14:52, on Zulip):

and then restore the rustc-guide => rustc-dev-guide github redirects by renaming the repo back to rustc-guide and then again to rustc-dev-guide

Pietro Albini (Mar 10 2020 at 14:52, on Zulip):

probably

Santiago Pastorino (Mar 10 2020 at 14:52, on Zulip):

yeah I think Pietro is right

Santiago Pastorino (Mar 10 2020 at 14:53, on Zulip):

fixing rust-lang.github.io/rustc-guide is less important than having github.com/rust-lang/rustc-guide redirecting correctly

Santiago Pastorino (Mar 10 2020 at 14:53, on Zulip):

what we can do is:

Santiago Pastorino (Mar 10 2020 at 14:53, on Zulip):
  1. remove rustc-guide (the new repo with the redirects)
mark-i-m (Mar 10 2020 at 14:53, on Zulip):

So basically:

mark-i-m (Mar 10 2020 at 14:53, on Zulip):

?

Santiago Pastorino (Mar 10 2020 at 14:53, on Zulip):
  1. rename rustc-dev-guide to rustc-guide back
Santiago Pastorino (Mar 10 2020 at 14:54, on Zulip):
  1. rename rustc-guide to rustc-dev-guide again
Santiago Pastorino (Mar 10 2020 at 14:54, on Zulip):

that should work

Santiago Pastorino (Mar 10 2020 at 14:54, on Zulip):

@Pietro Albini ?

Pietro Albini (Mar 10 2020 at 14:54, on Zulip):

yep that's my plan

mark-i-m (Mar 10 2020 at 14:55, on Zulip):

Will creating a rust-lang.github.io site break other links though?

Pietro Albini (Mar 10 2020 at 14:57, on Zulip):

no it's the default repository

Pietro Albini (Mar 10 2020 at 14:57, on Zulip):

so if there is a repo with the same name it will have precedence over rust-lang.github.io

Pietro Albini (Mar 10 2020 at 14:58, on Zulip):

ok I'll start doing the move

Santiago Pastorino (Mar 10 2020 at 15:00, on Zulip):

sure, go ahead :)

Santiago Pastorino (Mar 10 2020 at 15:01, on Zulip):

@Pietro Albini I wonder if there's a way to fix the https://rust-lang.github.io/rustc-guide problem now

Santiago Pastorino (Mar 10 2020 at 15:01, on Zulip):

because with what you're doing that will broke

Santiago Pastorino (Mar 10 2020 at 15:02, on Zulip):

there are a lot of links and bookmarks out there that point to that url

Pietro Albini (Mar 10 2020 at 15:02, on Zulip):

going into a call

mark-i-m (Mar 10 2020 at 15:02, on Zulip):

@Santiago Pastorino yes, they will break until we create a rust-lang.github.com repo and move the redirect links there

Santiago Pastorino (Mar 10 2020 at 15:03, on Zulip):

you meant, this repo https://github.com/rust-lang/rust-lang.github.io?

mark-i-m (Mar 10 2020 at 15:04, on Zulip):

yes

Santiago Pastorino (Mar 10 2020 at 15:04, on Zulip):

Pietro already did :)

Santiago Pastorino (Mar 10 2020 at 15:18, on Zulip):

wonder what's going on with https://github.com/rust-lang/rust/pull/69747

Yuki Okushi (Mar 10 2020 at 15:20, on Zulip):

Santiago Pastorino said:

wonder what's going on with https://github.com/rust-lang/rust/pull/69747

turned out, we should update this: https://github.com/rust-lang-nursery/rust-toolstate/blob/master/_data/latest.json

mark-i-m (Mar 10 2020 at 15:21, on Zulip):

toolstate needs to be updated

Yuki Okushi (Mar 10 2020 at 15:21, on Zulip):

cc @Pietro Albini that's correct?

Santiago Pastorino (Mar 10 2020 at 15:25, on Zulip):

right

Chris Simpkins (Mar 10 2020 at 15:25, on Zulip):

localizations for the www.rust-lang.org website include translations of "rustc guide" / "Rustc Guide". So for it the translation becomes "la guida rustc". Added to TODO list. Open PR thread for discussion is https://github.com/rust-lang/www.rust-lang.org/pull/1029

Santiago Pastorino (Mar 10 2020 at 15:25, on Zulip):

are you doing a PR?

Pietro Albini (Mar 10 2020 at 15:25, on Zulip):

still in the call, but I finished doing the redirect thingy

Santiago Pastorino (Mar 10 2020 at 15:25, on Zulip):

I can do it if you are not :)

Yuki Okushi (Mar 10 2020 at 15:26, on Zulip):

Santiago Pastorino said:

I can do it if you are not :)

will do, one sec!

Pietro Albini (Mar 10 2020 at 15:26, on Zulip):

so the github.com repo redirects are working correctly, and the pages redirects still work

Yuki Okushi (Mar 10 2020 at 15:29, on Zulip):

submitted: https://github.com/rust-lang-nursery/rust-toolstate/pull/16

Santiago Pastorino (Mar 10 2020 at 15:33, on Zulip):

I don't have push access there cc @mark-i-m @Pietro Albini

Yuki Okushi (Mar 10 2020 at 15:34, on Zulip):

hm, I guess it'll break other PR builders?

Pietro Albini (Mar 10 2020 at 15:37, on Zulip):

yeah we need to be careful about landing that

Pietro Albini (Mar 10 2020 at 15:37, on Zulip):

cc @centril

Pietro Albini (Mar 10 2020 at 15:38, on Zulip):

once the beta build finishes, we'll need to merge https://github.com/rust-lang-nursery/rust-toolstate/pull/16 and https://github.com/rust-lang/rust/pull/69747 at the same time

Pietro Albini (Mar 10 2020 at 15:39, on Zulip):

...but that's going to break the checks for every single person who has not rebased yet

Pietro Albini (Mar 10 2020 at 15:39, on Zulip):

ugh

mark-i-m (Mar 10 2020 at 16:24, on Zulip):

If I had realized we would cause so much breakage, I would have proposed waiting until after beta week. I hadn't realized rustc-dev-guide was so widely referred to and tied into everything

mark-i-m (Mar 10 2020 at 16:25, on Zulip):

it's a good problem to have I guess... it means that the guide is actually useful to people

Santiago Pastorino (Mar 10 2020 at 17:36, on Zulip):

@mark-i-m agreed

Santiago Pastorino (Mar 10 2020 at 17:37, on Zulip):

I guess lessons learned the hard way :)

Santiago Pastorino (Mar 10 2020 at 17:37, on Zulip):

I'd say that in general asking T-infra about this kind of things is a good practice just in case

mark-i-m (Mar 10 2020 at 19:04, on Zulip):

Should we go ahead and merge the blog post now and announce it?

Santiago Pastorino (Mar 10 2020 at 19:05, on Zulip):

hmm maybe we should wait for ...

Santiago Pastorino (Mar 10 2020 at 19:05, on Zulip):

Pietro Albini said:

once the beta build finishes, we'll need to merge https://github.com/rust-lang-nursery/rust-toolstate/pull/16 and https://github.com/rust-lang/rust/pull/69747 at the same time

:point_up:

Santiago Pastorino (Mar 10 2020 at 19:06, on Zulip):

@Pietro Albini how long it takes the beta build?

Pietro Albini (Mar 10 2020 at 19:06, on Zulip):

it failed...

Pietro Albini (Mar 10 2020 at 19:07, on Zulip):

btw I don't think that PR is the best approach

Pietro Albini (Mar 10 2020 at 19:07, on Zulip):

I'll leave feedback soonish

Santiago Pastorino (Mar 10 2020 at 19:07, on Zulip):

which one, the toolstate one or the rust one?

Pietro Albini (Mar 10 2020 at 19:11, on Zulip):

the rust one

Pietro Albini (Mar 10 2020 at 19:56, on Zulip):

@Santiago Pastorino can we split the rustc PR into two? one PR that fixes the links, and one PR that changes the submodules and toolstate

Santiago Pastorino (Mar 10 2020 at 19:56, on Zulip):

definitely

Santiago Pastorino (Mar 10 2020 at 19:58, on Zulip):

@Pietro Albini there's nothing about toolstate there

Pietro Albini (Mar 10 2020 at 19:58, on Zulip):

yes there is

Santiago Pastorino (Mar 10 2020 at 19:59, on Zulip):

ok

Santiago Pastorino (Mar 10 2020 at 19:59, on Zulip):

I guess you meant https://github.com/rust-lang/rust/pull/69747/files#diff-0642d987008f955c16affcafe3ea4a3eL92

Pietro Albini (Mar 10 2020 at 19:59, on Zulip):

you changed src/bootstrap/toolstate.rs, src/ci/docker/x86_64-gnu-tools/checktools.sh and src/tools/publish_toolstate.py

Santiago Pastorino (Mar 10 2020 at 19:59, on Zulip):

:+1:

Pietro Albini (Mar 10 2020 at 20:00, on Zulip):

basically what I'd like to see is a PR that only changes links, comments and doc blocks

Pietro Albini (Mar 10 2020 at 20:00, on Zulip):

and any actual code change in a separate PR

Pietro Albini (Mar 10 2020 at 20:01, on Zulip):

feel free to r? me on both

Santiago Pastorino (Mar 10 2020 at 20:10, on Zulip):

@Pietro Albini https://github.com/rust-lang/rust/pull/69747 ready

Santiago Pastorino (Mar 10 2020 at 20:10, on Zulip):

that's non code, the code sections are just comments

Pietro Albini (Mar 10 2020 at 20:13, on Zulip):

yep, r=me on that

Santiago Pastorino (Mar 10 2020 at 20:27, on Zulip):

@Pietro Albini https://github.com/rust-lang/rust/pull/69898

Pietro Albini (Mar 10 2020 at 20:32, on Zulip):

ugh this is hard

Chris Simpkins (Mar 11 2020 at 14:47, on Zulip):

Catching up on this thread. Are we on pause until the next beta push?

mark-i-m (Mar 12 2020 at 01:50, on Zulip):

It seems so

mark-i-m (Mar 12 2020 at 01:51, on Zulip):

I personally think we should just announce it and figure out the kinks later... people will surely start to wonder

Chris Simpkins (Mar 12 2020 at 02:03, on Zulip):

I believe that our tracking thread is current with the conversation / work complete here.

Chris Simpkins (Mar 12 2020 at 20:22, on Zulip):

https://github.com/rust-lang/rust/pull/69747 was merged

Last update: Apr 03 2020 at 18:15UTC