Stream: t-compiler/wg-learning

Topic: guide-toolstate


mark-i-m (Sep 17 2019 at 19:22, on Zulip):

I'm creating this thread to document toolstate procedures for the rustc-guide and to help with debugging them...

mark-i-m (Sep 17 2019 at 19:23, on Zulip):

1) You will get a ping from the toolstate commit. e.g. https://github.com/rust-lang-nursery/rust-toolstate/commit/8ffa0e4c30ac9ba8546b7046e5c4ccc2b96ebdd4

mark-i-m (Sep 17 2019 at 19:25, on Zulip):

2) The commit contains a link to the PR that caused the breakage. e.g. https://github.com/rust-lang/rust/pull/64321

mark-i-m (Sep 17 2019 at 19:26, on Zulip):

3) If you go to that PR's thread, there is a post from bors with a link to the CI status: https://github.com/rust-lang/rust/pull/64321#issuecomment-529763807

mark-i-m (Sep 17 2019 at 19:27, on Zulip):

4) Follow the check-azure link to get to the Azure website for that build: https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_build/results?buildId=7780

mark-i-m (Sep 17 2019 at 19:29, on Zulip):

5) There will be approximately 1 billion different jobs for the build. They are for different configurations and platforms. The rustc-guide build only runs on the Linux x86_64-gnu-tools job. So click on that job in the list, which is about 60% down in the list.

mark-i-m (Sep 17 2019 at 19:29, on Zulip):

6) Click the Run build step in the job to get the console log for the step.

mark-i-m (Sep 17 2019 at 19:30, on Zulip):

7) Click on the log and Ctrl-f to get a search box in the log

mark-i-m (Sep 17 2019 at 19:31, on Zulip):

8) Search for rustc-guide. This gets you to the place where the links are checked. It is usually ~11K lines into the log

mark-i-m (Sep 17 2019 at 19:32, on Zulip):

9) Look at the links in the log near that point in the log

mark-i-m (Sep 17 2019 at 19:33, on Zulip):

10) Fix those links in the rustc-guide

mark-i-m (Sep 17 2019 at 19:33, on Zulip):

(by making a PR in the rustc-guide repo)

mark-i-m (Sep 17 2019 at 19:34, on Zulip):

11) Make a PR on the rust-lang/rust repo to update the rustc-guide git submodule in src/docs/rustc-guide

mark-i-m (Sep 17 2019 at 19:34, on Zulip):

12) r? ehuss

mark-i-m (Sep 17 2019 at 19:34, on Zulip):

13) Wait for PR to merge

mark-i-m (Sep 17 2019 at 19:34, on Zulip):

Voila!

Amanjeev Sethi (Sep 17 2019 at 19:51, on Zulip):

This thread needs its own document in some guide?

mark-i-m (Sep 17 2019 at 19:52, on Zulip):

Perhaps it could be an appendix in the rustc-guide? How meta...

Amanjeev Sethi (Sep 17 2019 at 19:52, on Zulip):

I starred it so I hope we do not lose this thread.

mark-i-m (Sep 17 2019 at 20:03, on Zulip):

I opened https://github.com/rust-lang/rustc-guide/pull/446

mark-i-m (Sep 30 2019 at 23:55, on Zulip):

Could somebody please look into the toolstate failure with Chalk please? Usually it is a straightforward refactoring... otherwise, open an issue on the chalk repo

mark-i-m (Sep 30 2019 at 23:55, on Zulip):

Thanks!

Last update: Nov 15 2019 at 20:00UTC