Stream: t-compiler/wg-learning

Topic: FCP for toolstate change


Santiago Pastorino (Oct 02 2019 at 15:02, on Zulip):

Just to let everyone know about https://github.com/rust-lang/rust/issues/65000, in particular @mark-i-m, @Amanjeev Sethi and myself are the ones included there

Santiago Pastorino (Oct 02 2019 at 15:03, on Zulip):

to be honest, I'm not 100% sure what am I agreeing to if I click the box

Santiago Pastorino (Oct 02 2019 at 15:03, on Zulip):

I guess you agree to be pinged when the PR is reviewed?

Amanjeev Sethi (Oct 02 2019 at 15:08, on Zulip):

I was going to ask that myself. Glad you raised it

Santiago Pastorino (Oct 02 2019 at 15:09, on Zulip):

@mark-i-m is the one that is more aware/knowledgeable of these things :)

Yuki Okushi (Oct 02 2019 at 15:10, on Zulip):

IMO: As far as rustc-guide is concerned, I would agree

Amanjeev Sethi (Oct 02 2019 at 15:11, on Zulip):

Sorry what is FCP/

Yuki Okushi (Oct 02 2019 at 15:17, on Zulip):

I may be mistaken, but the topic is whether we agree or not https://github.com/rust-lang/rust/pull/64977 ?

Santiago Pastorino (Oct 02 2019 at 15:23, on Zulip):

Sorry what is FCP/

Final Comment Period

Santiago Pastorino (Oct 02 2019 at 15:23, on Zulip):

I may be mistaken, but the topic is whether we agree or not https://github.com/rust-lang/rust/pull/64977 ?

I guess it's if we agree and if we would like to be in the review process

Santiago Pastorino (Oct 02 2019 at 15:23, on Zulip):

but honestly unsure

Santiago Pastorino (Oct 02 2019 at 15:24, on Zulip):

Sorry what is FCP/

Final Comment Period

https://github.com/rust-lang/rustc-guide/blob/master/src/implementing_new_features.md

Amanjeev Sethi (Oct 02 2019 at 15:25, on Zulip):

oh thank you! I have so many acronyms at my new job and am drowning

Amanjeev Sethi (Oct 02 2019 at 15:38, on Zulip):

So we wait for @mark-i-m to enlighten us? :smiley:

Santiago Pastorino (Oct 02 2019 at 15:47, on Zulip):

I'd just tick by myself, but still I'd wait for @mark-i-m to see what they think about it

Amanjeev Sethi (Oct 02 2019 at 15:51, on Zulip):

I do not have permission to edit the comment. Should I ask you to do it ?

Santiago Pastorino (Oct 02 2019 at 15:59, on Zulip):

do you want me to tick on your name?

Amanjeev Sethi (Oct 02 2019 at 16:08, on Zulip):

Sure! I am still not sure what impact does this have for us but ok

simulacrum (Oct 02 2019 at 17:25, on Zulip):

This is agreeing to:

if we proceed with this change, submodule changes will no longer be gated when landing into master (modulo beta week). The theory behind this is that rollups can always include all toolstate-gated submodule changes, whereas currently it's pretty much impossible.

I can answer questions if you have them.

simulacrum (Oct 02 2019 at 17:26, on Zulip):

Basically it means when you or someone else updates the rustc-guide(?) the PR updating the submodule in rust-lang/rust will land faster, but possibly won't fix test failures and such if there are test failures

mark-i-m (Oct 02 2019 at 19:15, on Zulip):

I might be mistaken, but i think this is already the case for the guide.

mark-i-m (Oct 02 2019 at 19:16, on Zulip):

Personally, I agree to the change (cc @simulacrum because I can't tick my box)

simulacrum (Oct 02 2019 at 19:17, on Zulip):

That's possible, yes, I think we have several tools that are like that, though I think today it's a global thing (affects beta too). Will tick your box soon

simulacrum (Oct 02 2019 at 19:33, on Zulip):

ticked

Last update: Nov 15 2019 at 20:05UTC