Stream: t-compiler/wg-learning

Topic: meeting 2019-08-06


mark-i-m (Aug 06 2019 at 15:26, on Zulip):

@WG-learning Meeting today in ~4 hours

Santiago Pastorino (Aug 06 2019 at 19:30, on Zulip):

@WG-learning meeting time, :wave:

Santiago Pastorino (Aug 06 2019 at 19:30, on Zulip):

we have the rolling agenda here https://hackmd.io/s/SysIzeMRE but there's not much in there today

Santiago Pastorino (Aug 06 2019 at 19:30, on Zulip):

anyway

Santiago Pastorino (Aug 06 2019 at 19:30, on Zulip):

let's start with current status of things

Santiago Pastorino (Aug 06 2019 at 19:31, on Zulip):

What’s each of us working on and what’s the progress we are having?

Santiago Pastorino (Aug 06 2019 at 19:31, on Zulip):

anyone working on chapters want to give an update or something?

Amanjeev Sethi (Aug 06 2019 at 19:32, on Zulip):

I will start. I have not been able to do anything with the issue assigned to me https://github.com/rust-lang/rustc-guide/issues/372.
:sad:

Amanjeev Sethi (Aug 06 2019 at 19:32, on Zulip):

I think I might not be able to touch anything for the next 2-3 weeks as well.

Santiago Pastorino (Aug 06 2019 at 19:32, on Zulip):

@Amanjeev Sethi no worries

Santiago Pastorino (Aug 06 2019 at 19:33, on Zulip):

@mark-i-m you around?

Santiago Pastorino (Aug 06 2019 at 19:33, on Zulip):

others?

Santiago Pastorino (Aug 06 2019 at 19:34, on Zulip):

I was checking PRs and issues, in particular @Tshepang Lekhonkhobe made some grammatical fixes to some parts of the guides

Santiago Pastorino (Aug 06 2019 at 19:35, on Zulip):

there were some networking errors in the CI that @mark-i-m has fixed

mark-i-m (Aug 06 2019 at 19:35, on Zulip):

Ooop sorry... my alarm did not go off

mark-i-m (Aug 06 2019 at 19:35, on Zulip):

Hi :wave:

Santiago Pastorino (Aug 06 2019 at 19:35, on Zulip):

@mark-i-m no worries

Santiago Pastorino (Aug 06 2019 at 19:35, on Zulip):

@mark-i-m do you want to give some update?

mark-i-m (Aug 06 2019 at 19:36, on Zulip):

The CI errors have been annoying, but our hack seems to be working for now

Santiago Pastorino (Aug 06 2019 at 19:36, on Zulip):

I've also tried to encourage @Paul Faria to send some PRs, he found some things meanwhile he was reading guides

Santiago Pastorino (Aug 06 2019 at 19:36, on Zulip):

also would like to encourage @Tshepang Lekhonkhobe to be involved in the wg :)

mark-i-m (Aug 06 2019 at 19:37, on Zulip):

Also, ehuss and others have helped me get toolstate/linkcheck working properly (it turns out there were some issues that needed to be sorted out)

Santiago Pastorino (Aug 06 2019 at 19:38, on Zulip):

can you explain a bit for the rest of us how all that works :)

Santiago Pastorino (Aug 06 2019 at 19:38, on Zulip):

at least briefly, very high level

Tshepang Lekhonkhobe (Aug 06 2019 at 19:38, on Zulip):

will be sending random PRs as am trying to learn how the beast works

mark-i-m (Aug 06 2019 at 19:38, on Zulip):

The linkchecker in the rust CI is run from https://github.com/rust-lang/rust/tree/master/src/tools/rustbook

mark-i-m (Aug 06 2019 at 19:39, on Zulip):

It just runs mdbook_linkcheck as a library

Santiago Pastorino (Aug 06 2019 at 19:40, on Zulip):

will be sending random PRs as am trying to learn how the beast works

we are also summarizing lectures that some compiler experts gave

mark-i-m (Aug 06 2019 at 19:40, on Zulip):

That is called by only one linux builder from the script in src/ci/docker/<i forget which>

Santiago Pastorino (Aug 06 2019 at 19:40, on Zulip):

@Tshepang Lekhonkhobe if you are interested also on that let us know

Tshepang Lekhonkhobe (Aug 06 2019 at 19:41, on Zulip):

what does joining the wg mean... sorry, didn't read announcement and such, or don't remember

mark-i-m (Aug 06 2019 at 19:41, on Zulip):

The hack on the rustc-guide CI just checks the output of mdbook_linkcheck from stdout/err and looks for timeout errors. If timeout errors are equal to the number of errors mdbook linkcheck reported, then we let the build pass

mark-i-m (Aug 06 2019 at 19:41, on Zulip):

wg = Working Group

Tshepang Lekhonkhobe (Aug 06 2019 at 19:42, on Zulip):

yeah

Santiago Pastorino (Aug 06 2019 at 19:42, on Zulip):

what does joining the wg mean... sorry, didn't read announcement and such, or don't remember

we are trying to get people interested in contributing to the learning experience of rustc

Santiago Pastorino (Aug 06 2019 at 19:43, on Zulip):

basically, most of us are also learning and by doing that trying to improve the guides

Santiago Pastorino (Aug 06 2019 at 19:43, on Zulip):

there are two main efforts now

mark-i-m (Aug 06 2019 at 19:43, on Zulip):

The other announcement I have is we had our meeting with petrochenkov and are going to have another in a few weeks hopefully

Santiago Pastorino (Aug 06 2019 at 19:43, on Zulip):

one is watching the lectures and summarizing them as guides chapter

Santiago Pastorino (Aug 06 2019 at 19:43, on Zulip):

and the other one is triaging and paying attention to the issue tracker

Santiago Pastorino (Aug 06 2019 at 19:44, on Zulip):

this https://github.com/rust-lang/rustc-guide/projects/2 is the compiler lectures project

Tshepang Lekhonkhobe (Aug 06 2019 at 19:44, on Zulip):

kool... I been consuming it, and it's so much content, also uneven
needs much love

Santiago Pastorino (Aug 06 2019 at 19:45, on Zulip):

let me know if you want to get one of the chapters to be summarized

Santiago Pastorino (Aug 06 2019 at 19:45, on Zulip):

or if you want to be on Zulip group

Santiago Pastorino (Aug 06 2019 at 19:45, on Zulip):

@mark-i-m do you have any other status update?

mark-i-m (Aug 06 2019 at 19:45, on Zulip):

nope that's all i've got :)

Tshepang Lekhonkhobe (Aug 06 2019 at 19:46, on Zulip):

yeah, kool... make me part of the effort

Tshepang Lekhonkhobe (Aug 06 2019 at 19:46, on Zulip):

zulip is weird stuff (not complaining)

Santiago Pastorino (Aug 06 2019 at 19:46, on Zulip):

we don't have more topics on the agenda, that's why I spent most of the time trying to convince @Tshepang Lekhonkhobe :joy:

Amanjeev Sethi (Aug 06 2019 at 19:47, on Zulip):

zulip is weird stuff (not complaining)

tell me about it! i still haven't got the hang of this beast.

Santiago Pastorino (Aug 06 2019 at 19:47, on Zulip):

zulip is weird stuff (not complaining)

but it's really cool once you figure it out, mainly the threading part of it

Santiago Pastorino (Aug 06 2019 at 19:47, on Zulip):

there are some rough edges though, mainly UI/UX stuff is not awesome

Tshepang Lekhonkhobe (Aug 06 2019 at 19:48, on Zulip):

I hope it's not chasing people off these teams, and it's too happy trying to get one to reply to messages

mark-i-m (Aug 06 2019 at 19:49, on Zulip):

yes, you get the hang of it eventually... I'm not aware of anyone that left specifically because of zulip, which is good

Tshepang Lekhonkhobe (Aug 06 2019 at 19:49, on Zulip):

I like the threading... helps organise stuff nice

Amanjeev Sethi (Aug 06 2019 at 19:49, on Zulip):

oh yea I wont leave because of zulip for sure. I have dealt with Microsoft Office Communicator and I know it can get worse.

Tshepang Lekhonkhobe (Aug 06 2019 at 19:51, on Zulip):

will pick one. thanks (though concerned stuff may go over head)

Tshepang Lekhonkhobe (Aug 06 2019 at 19:51, on Zulip):

what does triaging mean in this case

Santiago Pastorino (Aug 06 2019 at 19:52, on Zulip):

I'd say going over issues and help moving them

Santiago Pastorino (Aug 06 2019 at 19:53, on Zulip):

that could be asking for status

Santiago Pastorino (Aug 06 2019 at 19:53, on Zulip):

suggesting changes

Santiago Pastorino (Aug 06 2019 at 19:53, on Zulip):

reading stuff and seeing if the issue or solution make sense

Santiago Pastorino (Aug 06 2019 at 19:53, on Zulip):

asking to the right people for help

Santiago Pastorino (Aug 06 2019 at 19:53, on Zulip):

all that stuff on issues or prs under rustc-guide repo

mark-i-m (Aug 06 2019 at 19:54, on Zulip):

or creating a list of actionable items for an issue (i.e. what is still remaining to be done)

mark-i-m (Aug 06 2019 at 19:54, on Zulip):

I thought this was a good example: https://github.com/rust-lang/rustc-guide/issues/14#issuecomment-514932385

Santiago Pastorino (Aug 06 2019 at 19:54, on Zulip):

:+1:

mark-i-m (Aug 06 2019 at 19:54, on Zulip):

Credits to @Francesco Dainese

Tshepang Lekhonkhobe (Aug 06 2019 at 19:55, on Zulip):

was wondering actually how long to wait after not activity should one check

mark-i-m (Aug 06 2019 at 19:55, on Zulip):

chough concerned stuff may go over head

@Tshepang Lekhonkhobe no worries. i think it is ok to leave TODOs where things need more detail or to ping an expert on zulip... whatever works for you

mark-i-m (Aug 06 2019 at 19:56, on Zulip):

was wondering actually how long to wait after not activity should one check

I would just sort issues by activity and start with the oldest ones... in general i would say if its more than ~2 months old it might be a bit out of date

mark-i-m (Aug 06 2019 at 19:57, on Zulip):

and there are a _lot_ of those ^^^

mark-i-m (Aug 06 2019 at 19:59, on Zulip):

Cool :) Anyone have anything else? It looks like the meeting is about over :wave:

Amanjeev Sethi (Aug 06 2019 at 20:00, on Zulip):

Nop.

Tshepang Lekhonkhobe (Aug 06 2019 at 20:01, on Zulip):

kool

mark-i-m (Aug 06 2019 at 20:10, on Zulip):

Oh, one other thing... would someone mind summarizing this thread and creating a PR for meeting notes: https://github.com/rust-lang/compiler-team/tree/master/content/working-groups/learning/minutes

Amanjeev Sethi (Aug 06 2019 at 20:12, on Zulip):

sure I can do that

Amanjeev Sethi (Aug 06 2019 at 20:13, on Zulip):

but not immediately :P

Francesco Dainese (Aug 06 2019 at 20:15, on Zulip):

:wave:

Santiago Pastorino (Aug 06 2019 at 20:40, on Zulip):

@Tshepang Lekhonkhobe saw you claimed a couple of lectures :party_ball:

Santiago Pastorino (Aug 06 2019 at 20:41, on Zulip):

may be better if you're assigned to just one, though

Santiago Pastorino (Aug 06 2019 at 20:41, on Zulip):

I mean, if you're really working on both at the same time is ok

Tshepang Lekhonkhobe (Aug 06 2019 at 20:41, on Zulip):

yeah, and it seems lots are unclaimed, so not too much pressure to do the work quick?

Santiago Pastorino (Aug 06 2019 at 20:41, on Zulip):

no no, it's not because of that

Santiago Pastorino (Aug 06 2019 at 20:41, on Zulip):

but yeah, there's a lot of unclaimed things

Santiago Pastorino (Aug 06 2019 at 20:42, on Zulip):

we are trying to get assignments as low as possible so new people that are interested in contributing can have also options to choose

Tshepang Lekhonkhobe (Aug 06 2019 at 20:43, on Zulip):

alright, let me unclaim one (how does one do that?)

Santiago Pastorino (Aug 06 2019 at 20:43, on Zulip):

it's very likely that you will finish one and you will have the other one waiting for you :)

Santiago Pastorino (Aug 06 2019 at 20:43, on Zulip):

hehe

Santiago Pastorino (Aug 06 2019 at 20:43, on Zulip):

don't remember, let me see ...

Santiago Pastorino (Aug 06 2019 at 20:44, on Zulip):

@rustbot release-assignment

Santiago Pastorino (Aug 06 2019 at 20:44, on Zulip):

for more info https://github.com/rust-lang/triagebot/wiki/Assignment

Tshepang Lekhonkhobe (Aug 06 2019 at 20:46, on Zulip):

thanks

Tshepang Lekhonkhobe (Aug 06 2019 at 20:49, on Zulip):

rustc_mir takes so forever to build

Tshepang Lekhonkhobe (Aug 06 2019 at 20:54, on Zulip):

so, looks like zulip forces you to choose a topic, which has an interesting side-effect of making one avoid polluting conversations

Tshepang Lekhonkhobe (Aug 06 2019 at 20:55, on Zulip):

... as I am doing now with this random note

Santiago Pastorino (Aug 06 2019 at 20:59, on Zulip):

the system makes it very easy to catch up

Santiago Pastorino (Aug 06 2019 at 20:59, on Zulip):

you can just jump into the things you're interested avoiding thousands of messages

Tshepang Lekhonkhobe (Aug 06 2019 at 21:00, on Zulip):

yeah, it is kool

Amanjeev Sethi (Aug 06 2019 at 21:05, on Zulip):

I agree. I have started to miss threads on Discord now. lol

Amanjeev Sethi (Aug 06 2019 at 21:06, on Zulip):

But Zulip could use a facelift or something

Amanjeev Sethi (Aug 07 2019 at 00:48, on Zulip):

PR for minutes https://github.com/rust-lang/compiler-team/pull/152

Paul Faria (Aug 07 2019 at 12:48, on Zulip):

I've also tried to encourage Paul Faria to send some PRs, he found some things meanwhile he was reading guides

I created 418, 419, and 420 from my read-through so far. If I also have a suggestion, should that be included as a PR as well, or discussed here first?

Paul Faria (Aug 07 2019 at 12:48, on Zulip):

CC @Santiago Pastorino ^

Santiago Pastorino (Aug 07 2019 at 14:06, on Zulip):

@Paul Faria opening a PR to discuss is ok

Santiago Pastorino (Aug 07 2019 at 14:06, on Zulip):

I mean, what is better for you, from time to time it's easier to discuss things based on an actual change

Santiago Pastorino (Aug 07 2019 at 14:07, on Zulip):

in other occasions the changes may be complex and could be better to discuss ideas first, but whatever you consider better is fine I think

Last update: Nov 15 2019 at 20:00UTC