Stream: t-compiler/wg-learning

Topic: meeting 2019.05.28


Santiago Pastorino (May 28 2019 at 19:30, on Zulip):

@WG-learning meeting time, :hi: everyone

Santiago Pastorino (May 28 2019 at 19:30, on Zulip):

last meeting we've talked about ...

Santiago Pastorino (May 28 2019 at 19:30, on Zulip):
    Define what’s the walkthrough section we want to add
    Triage missing rustc-guide chapters
    How do we want to keep track of who is doing what? Does github Projects works nice for this?
Santiago Pastorino (May 28 2019 at 19:31, on Zulip):

@lokalmatador was working on the walkthrough, unsure if they have something to mention about it

Santiago Pastorino (May 28 2019 at 19:32, on Zulip):

@WG-learning, @Iñaki Garay and @Amanjeev Sethi were not attending this time, who is around? :)

lokalmatador (May 28 2019 at 19:33, on Zulip):

lokalmatador was working on the walkthrough, unsure if they have something to mention about it

well, I'm done with the introductory part on rustc and the query model and started working on the walkthrough

Juan Bono (May 28 2019 at 19:33, on Zulip):

@WG-learning, Iñaki Garay and Amanjeev Sethi were not attending this time, who is around? :slight_smile:

Hi! I'm working on the lecture file for the video about coherence in chalk. I hope to have a PR with the material soon

Santiago Pastorino (May 28 2019 at 19:33, on Zulip):

ohh cool to hear from both :)

lokalmatador (May 28 2019 at 19:34, on Zulip):

now digging into the various intermediate representations (HIR, MIr, ...) for the compile walkthrough

Santiago Pastorino (May 28 2019 at 19:34, on Zulip):

@lokalmatador @Juan Bono do you need something?

Amanjeev Sethi (May 28 2019 at 19:34, on Zulip):

I am sort of hovering around but on my way to the airport. lol

My comment previously https://rust-lang.zulipchat.com/#narrow/stream/196385-t-compiler.2Fwg-learning/topic/pre-meeting.202019-05-28/near/166747993

lokalmatador (May 28 2019 at 19:34, on Zulip):

lokalmatador Juan Bono do you need something?

not for now, thanks

Santiago Pastorino (May 28 2019 at 19:34, on Zulip):

great

Santiago Pastorino (May 28 2019 at 19:34, on Zulip):

I was trying to figure out how to assign issues to you on github /cc @nikomatsakis

Juan Bono (May 28 2019 at 19:35, on Zulip):

lokalmatador Juan Bono do you need something?

not yet :slight_smile: thanks

Santiago Pastorino (May 28 2019 at 19:35, on Zulip):

but anyway, that's part of organizing a bit some things

nikomatsakis (May 28 2019 at 19:35, on Zulip):

the hope was that triagebot would be able to do it, but I think it's not ready yet

Santiago Pastorino (May 28 2019 at 19:35, on Zulip):

ok ok, should I ask infra about it?

Amanjeev Sethi (May 28 2019 at 19:35, on Zulip):

Wasn't there a new github feature to be able to assign tickets to non-members?

Santiago Pastorino (May 28 2019 at 19:35, on Zulip):

would be nice to know where it is or if it's a tracking issue for that

nikomatsakis (May 28 2019 at 19:36, on Zulip):

Wasn't there a new github feature to be able to assign tickets to non-members?

Oh?

nikomatsakis (May 28 2019 at 19:36, on Zulip):

that would be awesome

Santiago Pastorino (May 28 2019 at 19:36, on Zulip):

Wasn't there a new github feature to be able to assign tickets to non-members?

no idea, but I can't assign people from outside the org

Santiago Pastorino (May 28 2019 at 19:36, on Zulip):

just tried

Amanjeev Sethi (May 28 2019 at 19:36, on Zulip):

hmmm I think I saw someone tweet that. Let me find out and report back in a few.

Santiago Pastorino (May 28 2019 at 19:37, on Zulip):

ok

nikomatsakis (May 28 2019 at 19:38, on Zulip):

hmm so

Santiago Pastorino (May 28 2019 at 19:38, on Zulip):

@nikomatsakis we have this agenda https://hackmd.io/iamkyR_QTdSIdGjYQX_XjQ

nikomatsakis (May 28 2019 at 19:38, on Zulip):

well, the triagebot model was going to be that the issue gets assigned to a bot

nikomatsakis (May 28 2019 at 19:39, on Zulip):

and that we edit the issue header to say who it is assigned to

Santiago Pastorino (May 28 2019 at 19:39, on Zulip):

but unsure if the topics left from last meeting are the most important ones

Santiago Pastorino (May 28 2019 at 19:39, on Zulip):

and that we edit the issue header to say who it is assigned to

I see

Santiago Pastorino (May 28 2019 at 19:39, on Zulip):

how are things working now on rustc?

Santiago Pastorino (May 28 2019 at 19:40, on Zulip):

I'm not sure if I'm part of the org or not, saw some changes recently but I can do some stuff using the bot

Santiago Pastorino (May 28 2019 at 19:40, on Zulip):

is the idea to do in rustc-guide repo the same?

nikomatsakis (May 28 2019 at 19:41, on Zulip):

I used to just add everybody to the org

nikomatsakis (May 28 2019 at 19:41, on Zulip):

but there was a desire to be a bit tighter about perms

nikomatsakis (May 28 2019 at 19:41, on Zulip):

I could be out of date here

nikomatsakis (May 28 2019 at 19:41, on Zulip):

anyway let's ignore this question for a sec :)

Santiago Pastorino (May 28 2019 at 19:41, on Zulip):

yep

nikomatsakis (May 28 2019 at 19:41, on Zulip):

What did you want to talk about from that agenda?

nikomatsakis (May 28 2019 at 19:42, on Zulip):

You had mentioned the idea of scheduling another lecture

Santiago Pastorino (May 28 2019 at 19:42, on Zulip):

I think there are 2 important things

Santiago Pastorino (May 28 2019 at 19:42, on Zulip):

one of definitely scheduling lectures

Santiago Pastorino (May 28 2019 at 19:42, on Zulip):

and the other one is Define what forge should be and how that affects rustc-guide

nikomatsakis (May 28 2019 at 19:42, on Zulip):

Yeah

Santiago Pastorino (May 28 2019 at 19:43, on Zulip):

we talked a bit about that already

Santiago Pastorino (May 28 2019 at 19:43, on Zulip):

I think we wanted forge to be kind of the landing page

nikomatsakis (May 28 2019 at 19:43, on Zulip):

there isn't that much content on forge that obviously belongs in the rustc guide

Santiago Pastorino (May 28 2019 at 19:43, on Zulip):

yeah no

Santiago Pastorino (May 28 2019 at 19:44, on Zulip):

but I guess forge could be kind of a landing page with procedures, internals docs, etc

Santiago Pastorino (May 28 2019 at 19:44, on Zulip):

and link rustc-guide from there

nikomatsakis (May 28 2019 at 19:44, on Zulip):

yeah

Santiago Pastorino (May 28 2019 at 19:44, on Zulip):

and also link forge somewhere from the main rust web site

Santiago Pastorino (May 28 2019 at 19:44, on Zulip):

make it first class citizen :)

nikomatsakis (May 28 2019 at 19:44, on Zulip):

right

Santiago Pastorino (May 28 2019 at 19:45, on Zulip):

maybe I can just open some issues about that

nikomatsakis (May 28 2019 at 19:45, on Zulip):

I think rustc-guide should be pretty focused on "what you need to hack on rustc"

nikomatsakis (May 28 2019 at 19:45, on Zulip):

but it should probably not include team procdures or things like issue triage

Santiago Pastorino (May 28 2019 at 19:45, on Zulip):

yep

nikomatsakis (May 28 2019 at 19:45, on Zulip):

those things could live on forge

nikomatsakis (May 28 2019 at 19:45, on Zulip):

and the book can link to them

nikomatsakis (May 28 2019 at 19:45, on Zulip):

if needed

Santiago Pastorino (May 28 2019 at 19:45, on Zulip):

yep

Santiago Pastorino (May 28 2019 at 19:46, on Zulip):

so forge is/should be in general about team procedures?

Santiago Pastorino (May 28 2019 at 19:46, on Zulip):

or is it something more than that?

nikomatsakis (May 28 2019 at 19:46, on Zulip):

seems like it covers "infrastructure-related" things too. I guess there is some grey area like "how to run the perfbot" or whatever

nikomatsakis (May 28 2019 at 19:47, on Zulip):

I'd probably be inclined to move those things onto forge, and have the book link to them.

nikomatsakis (May 28 2019 at 19:47, on Zulip):

it feels like the book should keep the code as its focal point

Santiago Pastorino (May 28 2019 at 19:47, on Zulip):

what's the stuff that's not already in forge and you want moved?

Santiago Pastorino (May 28 2019 at 19:47, on Zulip):

sorry I didn't get that

nikomatsakis (May 28 2019 at 19:49, on Zulip):

I'm looking over the rustc-guide now. The question is about the stuff in Part 1, I guess.

nikomatsakis (May 28 2019 at 19:49, on Zulip):

There is also some stuff that is not in the book or forge now but which it would be nice to document

nikomatsakis (May 28 2019 at 19:50, on Zulip):

I'm thinking of craterbot and rustc-timer (that does benchmarking)

Santiago Pastorino (May 28 2019 at 19:50, on Zulip):

:+1:

nikomatsakis (May 28 2019 at 19:50, on Zulip):

though perhaps that would best be documented by just linking to their respective repositories

nikomatsakis (May 28 2019 at 19:51, on Zulip):

anyway, I think the stuff that's in rustc-guide feels like it belongs there -- my rule of thumb is sort of "is this something you would do while fixing a compiler bug or implementing a compiler feature" -- but I think you could also put it on forge. I guess I don't care too much, probably the biggest problem is to link forge more prominently, as you said

Santiago Pastorino (May 28 2019 at 19:51, on Zulip):

couldn't we have an appendix with things or tools or procedures inside rustc-guide

Santiago Pastorino (May 28 2019 at 19:51, on Zulip):

that are just links to READMEs or something

Santiago Pastorino (May 28 2019 at 19:52, on Zulip):

maybe similar to the Glossary, just something brief with links

nikomatsakis (May 28 2019 at 19:53, on Zulip):

right, we certainly could

Santiago Pastorino (May 28 2019 at 19:53, on Zulip):

what I can do is open an issue to add a link to forge from the website

nikomatsakis (May 28 2019 at 19:53, on Zulip):

it seems like the major action item is to firure out where to link "forge" from main web site? and probably cite it from in the rustc-guide?

Santiago Pastorino (May 28 2019 at 19:54, on Zulip):

forge links rustc-guide

Santiago Pastorino (May 28 2019 at 19:54, on Zulip):

which I think it's fine

Santiago Pastorino (May 28 2019 at 19:54, on Zulip):

we can also link forge from the rustc-guide, is that what you've said?

nikomatsakis (May 28 2019 at 19:54, on Zulip):

yep

Santiago Pastorino (May 28 2019 at 19:55, on Zulip):

what about a little paragraph here https://rust-lang.github.io/rustc-guide/about-this-guide.html ?

Santiago Pastorino (May 28 2019 at 19:55, on Zulip):

kind of ...

nikomatsakis (May 28 2019 at 19:55, on Zulip):

On the topic of lectures, I think we should do one on HAIR and MIR construction. I think I could do that, but @oli might be good for that -- I wouldn't have time this week, but maybe next week.

nikomatsakis (May 28 2019 at 19:55, on Zulip):

what about a little paragraph here https://rust-lang.github.io/rustc-guide/about-this-guide.html ?

yep, that's what I would do

Santiago Pastorino (May 28 2019 at 19:55, on Zulip):

if you want to read more supplementary documentation visit rust-forge

nikomatsakis (May 28 2019 at 19:55, on Zulip):

maybe a subsection like "other places to find information"

nikomatsakis (May 28 2019 at 19:56, on Zulip):

probably a link to the rustc API docs, too

Santiago Pastorino (May 28 2019 at 19:56, on Zulip):

On the topic of lectures, I think we should do one on HAIR and MIR construction. I think I could do that, but oli might be good for that -- I wouldn't have time this week, but maybe next week.

cool gonna do a follow up with you both about it :)

Santiago Pastorino (May 28 2019 at 19:58, on Zulip):

probably a link to the rustc API docs, too

I guess I can open a PR with these and forge link

Santiago Pastorino (May 28 2019 at 19:58, on Zulip):

@nikomatsakis do you have something else to comment on?

nikomatsakis (May 28 2019 at 20:01, on Zulip):

nope

nikomatsakis (May 28 2019 at 20:01, on Zulip):

still catching up from being away last week :)

Santiago Pastorino (May 28 2019 at 20:02, on Zulip):

:)

Santiago Pastorino (May 28 2019 at 20:02, on Zulip):

ok, I think this is over then :hi:

Last update: Nov 15 2019 at 20:00UTC