Stream: t-compiler/wg-learning

Topic: rename working group


Santiago Pastorino (Mar 20 2020 at 16:39, on Zulip):

@WG-learning now that we have renamed the guide and seeing that clearly the working group was always about the guide I'd like to propose to change the working group name to wg-rustc-dev-guide to have it focused just on that

LeSeulArtichaut (Mar 20 2020 at 16:40, on Zulip):

I have a question then. Is the documentation of the compiler internals something this WG has to worry about?

LeSeulArtichaut (Mar 20 2020 at 16:41, on Zulip):

Or is it the realm of the "main" compiler team?

Chris Simpkins (Mar 20 2020 at 16:45, on Zulip):

Will education outside of the Guide (e.g. different media formats like video series, publications other than the Guide, etc) never be in scope for this working group? IMO this constrains the WG to only the Guide. There may be other approaches for education that are valuable. If it is possible that we will expand beyond the Guide, I suggest keeping the name general and on theme with the education on the compiler. Maybe refinements like "CompEd" = compiler education , "compiler-learning" keep things open for education activitives that are not strictly Guide oriented should that become a focus in the future (if "Learning" is too broad)

mark-i-m (Mar 20 2020 at 16:48, on Zulip):

Hmm... those are good questions

mark-i-m (Mar 20 2020 at 16:49, on Zulip):

I think ideally we would do all those things, but just due to time constraints/man power, the guide tends to be what we work on...

mark-i-m (Mar 20 2020 at 16:50, on Zulip):

I'm not sure we should rule them out, though... WG-compiler-ed sounds nice

Santiago Pastorino (Mar 20 2020 at 17:00, on Zulip):

yeah those are great questions

Santiago Pastorino (Mar 20 2020 at 17:01, on Zulip):

and I liked the compiler education name too

Santiago Pastorino (Mar 20 2020 at 17:01, on Zulip):

I guess there are two things which winds down to long term vs focus

Santiago Pastorino (Mar 20 2020 at 17:01, on Zulip):

I'm not sure what's better to do but I just want to mention two approaches

Santiago Pastorino (Mar 20 2020 at 17:03, on Zulip):

one is to have a broad name and responsibility, that works like a full area of responsibility for the work, a never ending, long-term wg which is named something like compiler-ed or wg-compiler-ed

Santiago Pastorino (Mar 20 2020 at 17:03, on Zulip):

another approach is just to have a "short" term, more focused wg and nothing stops us to start new initiatives if we have the time

Santiago Pastorino (Mar 20 2020 at 17:03, on Zulip):

cc @nikomatsakis @pnkfelix

Santiago Pastorino (Mar 20 2020 at 17:05, on Zulip):

this discussion is similar to t-compiler vs wg-mir-opt or other wgs, in the sense that there's an area of responsibility t-compiler and there's a focused team that works towards a specific goal wg-mir-opt

Santiago Pastorino (Mar 20 2020 at 17:06, on Zulip):

anyway, very smart questions :)

Tshepang Lekhonkhobe (Mar 21 2020 at 12:13, on Zulip):

happy with wg-rustc-dev-guide... if focus shifts we can rename again, or another wg could be formed

Chris Simpkins (Mar 21 2020 at 20:24, on Zulip):

Is this a goal?

Ensure that API doc coverage is at least 90%

https://blog.rust-lang.org/inside-rust/2019/10/28/rustc-learning-working-group-introduction.html

TBH, after the rustc-guide to rustc-dev-guide transition experience, I'd suggest just leaving the name be...

mark-i-m (Mar 22 2020 at 22:23, on Zulip):

it was a goal that we never really got to so far

mark-i-m (Mar 22 2020 at 22:24, on Zulip):

TBH, after the rustc-guide to rustc-dev-guide transition experience, I'd suggest just leaving the name be...

That's a fair point

Santiago Pastorino (Mar 23 2020 at 04:56, on Zulip):

well but this rename does not involve renaming a code repo or anything like that, it's just the working group name

mark-i-m (Mar 24 2020 at 01:15, on Zulip):

Does something need to happen with the rust-lang org teams? infra bots? compiler-team repo? This zulip stream?

mark-i-m (Mar 24 2020 at 01:15, on Zulip):

Also, I suspect there would be a round of links to fix on internals but what would we redirect to?

LeSeulArtichaut (Mar 24 2020 at 08:49, on Zulip):

There’s at least the rust-lang org team and the team repo. I beleve that infra bot use the team repo, so there probably won’t be any problems

Santiago Pastorino (Mar 24 2020 at 18:48, on Zulip):

cc @Pietro Albini

Pietro Albini (Mar 24 2020 at 18:49, on Zulip):

which bots are you interacting with?

Santiago Pastorino (Mar 24 2020 at 18:50, on Zulip):

there's nothing in particular we are doing, I don't think we are going to have troubles other than compiler-team page links would be moved

Santiago Pastorino (Mar 24 2020 at 18:50, on Zulip):

same for team repo

Santiago Pastorino (Mar 24 2020 at 18:51, on Zulip):

maybe renaming labels and teams if we have those

Santiago Pastorino (Mar 24 2020 at 18:51, on Zulip):

we don't have wg-learning label

Santiago Pastorino (Mar 24 2020 at 18:51, on Zulip):

I guess we do have a github team

Santiago Pastorino (Mar 24 2020 at 18:52, on Zulip):

but that's synced from team repo, right?

Pietro Albini (Mar 24 2020 at 19:18, on Zulip):

so, when we merge the team repo PR the new team will be automatically created, but the old one won't be deleted

Pietro Albini (Mar 24 2020 at 19:19, on Zulip):

someone with owner access will then have to go move perms to the new team and delete the old one

Pietro Albini (Mar 24 2020 at 19:19, on Zulip):

y'all like renames too much :stuck_out_tongue:

Santiago Pastorino (Mar 24 2020 at 20:38, on Zulip):

LOL

Santiago Pastorino (Mar 24 2020 at 20:40, on Zulip):

I'd do the rename, it doesn't seem much work

Santiago Pastorino (Mar 24 2020 at 20:40, on Zulip):

@WG-learning ?

Santiago Pastorino (Mar 24 2020 at 20:40, on Zulip):

the current name is very misleading

LeSeulArtichaut (Mar 24 2020 at 21:06, on Zulip):

If the WG should focus only on the rustc-dev-guide, then I also think we should rename

LeSeulArtichaut (Mar 24 2020 at 22:53, on Zulip):

y'all like renames too much :stuck_out_tongue:

Let’s have a WG-renaming

Tshepang Lekhonkhobe (Mar 24 2020 at 22:55, on Zulip):

@Santiago Pastorino I favor a rename

mark-i-m (Mar 24 2020 at 23:36, on Zulip):

I'm personally not in favor of more renaming, but if everyone else wants to, then I won't object

mark-i-m (Mar 24 2020 at 23:36, on Zulip):

Mostly, I won't have as much time to help out with it, though

Santiago Pastorino (Mar 25 2020 at 14:53, on Zulip):

I can do the work but let's make a decision :)

Santiago Pastorino (Mar 25 2020 at 14:55, on Zulip):

Should we rename wg-learning to wg-rustc-dev-guide? :+1: or :-1:

Santiago Pastorino (Mar 25 2020 at 14:55, on Zulip):

@WG-learning :point_up:

Santiago Pastorino (Mar 25 2020 at 14:55, on Zulip):

cc @nikomatsakis and @pnkfelix if you have something to say or vote here :)

pnkfelix (Mar 25 2020 at 16:49, on Zulip):

I don't think I'm involved enough in this process to actually vote. I will state for the record that I don't personally see the motivation here. I think I understand the argument put forth by @Santiago Pastorino , but I haven't seen evidence of active confusion regarding the current activity of the WG. There might be confusion regarding its long term plans (e.g. is the scope truly limited to the guide).

pnkfelix (Mar 25 2020 at 16:50, on Zulip):

If there is active confusion that I'm unaware of (e.g. people thinking that this WG is about Rust education itself), then that may indeed be worth addressing. But even that wouldn't necessarily entail that the suggested rename makes sense.

pnkfelix (Mar 25 2020 at 17:05, on Zulip):

Having said all that, a rename is unlikely to affect anything I do, so that's why I'm abstaining.

Santiago Pastorino (Mar 27 2020 at 21:17, on Zulip):

well we couldn't reach consensus but most people prefer the rename or do not care much

Santiago Pastorino (Mar 27 2020 at 21:17, on Zulip):

also Niko is in favor https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/weekly.20meeting.202020-03-26.20.2354818/near/191896674

Santiago Pastorino (Mar 27 2020 at 21:18, on Zulip):

going to prepare an issue with renaming steps so we can all check before making a mistake :)

Santiago Pastorino (Mar 27 2020 at 21:40, on Zulip):

done

Santiago Pastorino (Mar 27 2020 at 21:40, on Zulip):

compiler-team#265

Santiago Pastorino (Mar 27 2020 at 21:40, on Zulip):

@WG-learning please check this out and provide feedback :)

LeSeulArtichaut (Mar 27 2020 at 21:42, on Zulip):

Looks good to me

Santiago Pastorino (Apr 01 2020 at 21:25, on Zulip):

going to start moving this forward

Santiago Pastorino (Apr 01 2020 at 21:25, on Zulip):

if someone wants to help more than welcome :)

Santiago Pastorino (Apr 01 2020 at 21:26, on Zulip):

by first cooking all the PRs needed

Santiago Pastorino (Apr 01 2020 at 21:36, on Zulip):

compiler-team#268

Santiago Pastorino (Apr 01 2020 at 21:42, on Zulip):

have done compiler-team and team repos PRs

Santiago Pastorino (Apr 01 2020 at 21:53, on Zulip):

team#310

Santiago Pastorino (Apr 01 2020 at 21:54, on Zulip):

and blog#556

Santiago Pastorino (Apr 01 2020 at 21:54, on Zulip):

please let me know if everything looks fine, with all this we can just start renaming the groups and things and then merge

Santiago Pastorino (Apr 02 2020 at 16:41, on Zulip):

@WG-learning thoughts about this?

Tshepang Lekhonkhobe (Apr 02 2020 at 16:42, on Zulip):

I'd say go-for-it

Chris Simpkins (Apr 02 2020 at 16:45, on Zulip):

Thoughts about rewriting history in the blog? Should we leave "Learning" there and write a new article about the name change, or just leave it to the Internals forum for the notice?

Chris Simpkins (Apr 02 2020 at 16:48, on Zulip):

Just submitted a review on the blog updates. There were a few areas where "Rustc" or "rustc" was duplicated.

mark-i-m (Apr 02 2020 at 18:22, on Zulip):

I think rewriting history is ok, but I would also be ok with a blog post

LeSeulArtichaut (Apr 02 2020 at 19:00, on Zulip):

I can write a blog post if needed

Santiago Pastorino (Apr 02 2020 at 19:00, on Zulip):

maybe a post in URLO

Santiago Pastorino (Apr 02 2020 at 19:00, on Zulip):

I'm fine with whatever

Santiago Pastorino (Apr 02 2020 at 19:00, on Zulip):

going to proceed with this

Santiago Pastorino (Apr 02 2020 at 19:01, on Zulip):

@Pietro Albini @simulacrum can any of you help us?

Santiago Pastorino (Apr 02 2020 at 19:01, on Zulip):

compiler-team#265

Pietro Albini (Apr 02 2020 at 19:01, on Zulip):

I can't today :(

Santiago Pastorino (Apr 02 2020 at 19:01, on Zulip):

what we need in case @simulacrum is able is to check if that procedure is correct

Santiago Pastorino (Apr 02 2020 at 19:01, on Zulip):

then we would need to rename the group on github

Santiago Pastorino (Apr 02 2020 at 19:02, on Zulip):

and merge the PRs we've provided

Santiago Pastorino (Apr 02 2020 at 19:02, on Zulip):

that would be all (unless the checklist is wrong)

simulacrum (Apr 02 2020 at 19:11, on Zulip):

I don't think I'll have the time, unfortunately - but it seems like the procedure isn't wrong

simulacrum (Apr 02 2020 at 19:11, on Zulip):

I suspect all the renaming can happen iteratively and as a team repo PR perhaps?

Santiago Pastorino (Apr 02 2020 at 19:17, on Zulip):

@simulacrum yeah the PRs are up and ready

Santiago Pastorino (Apr 02 2020 at 19:17, on Zulip):

we have one to team and we also need to rename the github group

Santiago Pastorino (Apr 02 2020 at 19:18, on Zulip):

what we need from you or Pietro is to merge the team PR and to rename the github group

Santiago Pastorino (Apr 02 2020 at 19:20, on Zulip):

@simulacrum there's no rush, I guess we just want to coordinate so meanwhile you change the github team and merge the PR to the team repo I can rename zulip stuff and we can merge the compiler-team PR

simulacrum (Apr 02 2020 at 19:55, on Zulip):

oh if the prs are up then please re-ping me on those

Santiago Pastorino (Apr 02 2020 at 21:38, on Zulip):

@simulacrum I'll ping you tomorrow so we do everything at once, if it sounds good to you

simulacrum (Apr 02 2020 at 22:34, on Zulip):

To be clear I meant just to get it in my queue, not sure if I'll have time tomorrow

Santiago Pastorino (Apr 03 2020 at 15:36, on Zulip):

@Pietro Albini @simulacrum when any of you have time for this just let me know

Santiago Pastorino (Apr 03 2020 at 15:36, on Zulip):

there's no rush

Santiago Pastorino (Apr 03 2020 at 15:37, on Zulip):

to be maybe more clear, we need you to rename the github wg to @rust-lang/wg-rustc-dev-guide and merge the team PR

Santiago Pastorino (Apr 03 2020 at 15:37, on Zulip):

and would be nice if you ping us so we also do the rest at the same time

Pietro Albini (Apr 03 2020 at 16:17, on Zulip):

left a comment

Pietro Albini (Apr 03 2020 at 16:17, on Zulip):

on the team repo PR

Santiago Pastorino (Apr 03 2020 at 16:18, on Zulip):

facepalm

Santiago Pastorino (Apr 03 2020 at 16:19, on Zulip):

addressed

Last update: Apr 03 2020 at 18:15UTC