Stream: t-compiler/wg-learning

Topic: meeting 2019.06.11


mark-i-m (Jun 11 2019 at 17:01, on Zulip):

Hi all :)

Meeting in 2.5 hours :time_ticking:

mark-i-m (Jun 11 2019 at 17:15, on Zulip):

Agenda doc is here: https://hackmd.io/s/SysIzeMRE
Feel free to add to it

mark-i-m (Jun 11 2019 at 17:21, on Zulip):

cc @WG-learning

selfmover (Jun 11 2019 at 18:45, on Zulip):

how do I join?

mark-i-m (Jun 11 2019 at 18:50, on Zulip):

The meeting is in this thread in about 40 minutes (we don't have a separate conference call/video chat or anything)

selfmover (Jun 11 2019 at 19:14, on Zulip):

I see!

Santiago Pastorino (Jun 11 2019 at 19:22, on Zulip):

@selfmover do you want to be added to @WG-learning? when that group is mentioned you will receive a notification

selfmover (Jun 11 2019 at 19:23, on Zulip):

sure

Santiago Pastorino (Jun 11 2019 at 19:24, on Zulip):

done

Santiago Pastorino (Jun 11 2019 at 19:27, on Zulip):

@WG-learning meeting in 3 mins

Santiago Pastorino (Jun 11 2019 at 19:30, on Zulip):

@WG-learning :hi: everyone, meeting time :)

Santiago Pastorino (Jun 11 2019 at 19:30, on Zulip):

so, during the last meeting we've talked about ...

Santiago Pastorino (Jun 11 2019 at 19:30, on Zulip):

Triaging rustc-guide repo

Santiago Pastorino (Jun 11 2019 at 19:30, on Zulip):

Forge

Santiago Pastorino (Jun 11 2019 at 19:30, on Zulip):

and

Santiago Pastorino (Jun 11 2019 at 19:30, on Zulip):

Lectures

Santiago Pastorino (Jun 11 2019 at 19:30, on Zulip):

the triaging task was not finished

Santiago Pastorino (Jun 11 2019 at 19:31, on Zulip):

that's one of the things we may start tackling

Santiago Pastorino (Jun 11 2019 at 19:31, on Zulip):

but before that

Santiago Pastorino (Jun 11 2019 at 19:31, on Zulip):

does someone has something to share about their tasks?

Santiago Pastorino (Jun 11 2019 at 19:32, on Zulip):

@Amanjeev Sethi @Iñaki Garay @lokalmatador @Juan Bono ?

Amanjeev Sethi (Jun 11 2019 at 19:32, on Zulip):

I want to ask here if it is ok to ping the lecturer again in case they missed something?

lokalmatador (Jun 11 2019 at 19:32, on Zulip):

hm, making steady progress, about to finish up the part on HIR and moving on to MIR

Santiago Pastorino (Jun 11 2019 at 19:32, on Zulip):

I want to ask here if it is ok to ping the lecturer again in case they missed something?

I think so

lokalmatador (Jun 11 2019 at 19:32, on Zulip):

I also changed the example to bubblesort in the meantime using some mutable borrows

Iñaki Garay (Jun 11 2019 at 19:32, on Zulip):

I have made no progress whatsoever on the transcription of the representing types lecture, but have not dropped it. On the plus side, we've organized a conference which includes a rust talk ;)

Santiago Pastorino (Jun 11 2019 at 19:33, on Zulip):

I want to ask here if it is ok to ping the lecturer again in case they missed something?

I think so

I mean, do you see something missing on the debugging lecture?

lokalmatador (Jun 11 2019 at 19:33, on Zulip):

and I have a quick question: when taking about trait solving, I stick to the old style in rustc, right?

mark-i-m (Jun 11 2019 at 19:33, on Zulip):

@Amanjeev Sethi I think tromey is likely to be busy and thus slow to answer. My inclination is to review your chapter as is and get it merged with TODOs. Then we can iterate from there

Santiago Pastorino (Jun 11 2019 at 19:33, on Zulip):

@lokalmatador good question, I think so, /cc @nikomatsakis

Amanjeev Sethi (Jun 11 2019 at 19:33, on Zulip):

I had a couple of more comments on https://github.com/rust-lang/rustc-guide/pull/316 for @Tom Tromey

nikomatsakis (Jun 11 2019 at 19:34, on Zulip):

I want to ask here if it is ok to ping the lecturer again in case they missed something?

please do

nikomatsakis (Jun 11 2019 at 19:34, on Zulip):

oh, but yeah I think @Tom Tromey prob won't have much time

nikomatsakis (Jun 11 2019 at 19:34, on Zulip):

and I have a quick question: when taking about trait solving, I stick to the old style in rustc, right?

not sure what this means -- you mean the current trait solver?

Santiago Pastorino (Jun 11 2019 at 19:34, on Zulip):

I have made no progress whatsoever on the transcription of the representing types lecture, but have not dropped it. On the plus side, we've organized a conference which includes a rust talk ;)

:party_ball:

nikomatsakis (Jun 11 2019 at 19:35, on Zulip):

I guess the answer would be yes :)

Amanjeev Sethi (Jun 11 2019 at 19:35, on Zulip):

Otherwise I think I will pick another video soon from the list. What is the process now? Comment on the github issue with the list?

nikomatsakis (Jun 11 2019 at 19:35, on Zulip):

@lokalmatador this is for the kind of "overview of rustc" section?

lokalmatador (Jun 11 2019 at 19:35, on Zulip):

lokalmatador this is for the kind of "overview of rustc" section?

yup

Santiago Pastorino (Jun 11 2019 at 19:35, on Zulip):

Otherwise I think I will pick another video soon from the list. What is the process now? Comment on the github issue with the list?

there is a tracking issue, I guess you can comment there and me or @mark-i-m can modify the text of the issue to say that you're on it

Amanjeev Sethi (Jun 11 2019 at 19:35, on Zulip):

@mark-i-m works for me, I would rather have it merged and iterate as well

Santiago Pastorino (Jun 11 2019 at 19:36, on Zulip):

Otherwise I think I will pick another video soon from the list. What is the process now? Comment on the github issue with the list?

there is a tracking issue, I guess you can comment there and me or mark-i-m can modify the text of the issue to say that you're on it

I may move this to a github project but for now that's the procedure :)

nikomatsakis (Jun 11 2019 at 19:37, on Zulip):

yup

@lokalmatador then yes I guess I would stick to old trait solver for now :)

nikomatsakis (Jun 11 2019 at 19:37, on Zulip):

(is there a WIP we can look at?)

lokalmatador (Jun 11 2019 at 19:38, on Zulip):

(is there a WIP we can look at?)

yeah , wait a sec

mark-i-m (Jun 11 2019 at 19:38, on Zulip):

@Juan Bono Are you there? Did you have any updates on your chapter

Santiago Pastorino (Jun 11 2019 at 19:38, on Zulip):

@selfmover btw, if you want to get involved one of the things that we are doing is going over some of the lectures (we have videos of technical talks) and transcribing them as part of rustc-guide

mark-i-m (Jun 11 2019 at 19:38, on Zulip):

?

Santiago Pastorino (Jun 11 2019 at 19:38, on Zulip):

I guess @Juan Bono is more or less on the same page as @Iñaki Garay, they work together and are organizing a conf

Iñaki Garay (Jun 11 2019 at 19:39, on Zulip):

affirmative

mark-i-m (Jun 11 2019 at 19:39, on Zulip):

@selfmover See https://github.com/rust-lang/rustc-guide/issues/319 if you are interested

lokalmatador (Jun 11 2019 at 19:39, on Zulip):

(is there a WIP we can look at?)

it's on dropbox paper so i guess i have to invite you...

Santiago Pastorino (Jun 11 2019 at 19:39, on Zulip):

selfmover See https://github.com/rust-lang/rustc-guide/issues/319 if you are interested

comment there and we can assign you something

lokalmatador (Jun 11 2019 at 19:39, on Zulip):

or can i share it just here?

lokalmatador (Jun 11 2019 at 19:39, on Zulip):

total noob

lokalmatador (Jun 11 2019 at 19:39, on Zulip):

https://paper.dropbox.com/doc/A-first-glance-at-rustc--AexZRkGI1D_0C_eqE5ZBqmgjAQ-Mk45wFbBKBT9C8e9rPaCd

Santiago Pastorino (Jun 11 2019 at 19:40, on Zulip):

I guess we can move to the next thing, right?

Santiago Pastorino (Jun 11 2019 at 19:40, on Zulip):

which is ...

Santiago Pastorino (Jun 11 2019 at 19:40, on Zulip):

How to triage the rustc-guide repo (cont’d)
triagebot or github assignment or what?

mark-i-m (Jun 11 2019 at 19:40, on Zulip):

actually first

selfmover (Jun 11 2019 at 19:40, on Zulip):

@mark-i-m OK I will take a look at those lectures

lokalmatador (Jun 11 2019 at 19:41, on Zulip):

https://paper.dropbox.com/doc/A-first-glance-at-rustc--AexZRkGI1D_0C_eqE5ZBqmgjAQ-Mk45wFbBKBT9C8e9rPaCd

and yeah, early WIP, not proofread for now :wink:

mark-i-m (Jun 11 2019 at 19:41, on Zulip):

@Santiago Pastorino did you have any updates on scheduling lectures for MIR, HAIR, codegen, or macros?

selfmover (Jun 11 2019 at 19:41, on Zulip):

should it be a word for word transcription or lecture notes?

Santiago Pastorino (Jun 11 2019 at 19:41, on Zulip):

Santiago Pastorino did you have any updates on scheduling lectures for MIR, HAIR, codegen, or macros?

yes, @oli is going to do something about it :)

Santiago Pastorino (Jun 11 2019 at 19:41, on Zulip):

he needs some time to prepare, but the idea was to do it this month

Santiago Pastorino (Jun 11 2019 at 19:42, on Zulip):

that's what we talked here https://rust-lang.zulipchat.com/#narrow/stream/196385-t-compiler.2Fwg-learning/topic/hair.20and.20mir.20construction.20lecture

Santiago Pastorino (Jun 11 2019 at 19:42, on Zulip):

How to triage the rustc-guide repo (cont’d)
triagebot or github assignment or what?

@nikomatsakis do you have something new to say about this?

mark-i-m (Jun 11 2019 at 19:42, on Zulip):

And for my part,
- I need to investigate some dependency issues in https://github.com/rust-lang/rust/pull/59772, which adds rustc-guide to toolstate so we can see breakage more easily
- I'm thinking of merging https://github.com/blitzerr/rustc-guide/pull/1 and iterating from there

nikomatsakis (Jun 11 2019 at 19:43, on Zulip):

I'm not quite sure what you mean @Santiago Pastorino

Santiago Pastorino (Jun 11 2019 at 19:44, on Zulip):

so, we can't assign issues to people outside the org

mark-i-m (Jun 11 2019 at 19:44, on Zulip):

Is there an objection to adding the WG members as non-admin contributors on the rustc-guide repo?

mark-i-m (Jun 11 2019 at 19:44, on Zulip):

then we could just assign people

nikomatsakis (Jun 11 2019 at 19:44, on Zulip):

Oh, that

nikomatsakis (Jun 11 2019 at 19:45, on Zulip):

I think if it's blocking you, just add them to the repo

nikomatsakis (Jun 11 2019 at 19:45, on Zulip):

we can sort it out later :P

nikomatsakis (Jun 11 2019 at 19:45, on Zulip):

and anyway it might be the right thing to do

mark-i-m (Jun 11 2019 at 19:45, on Zulip):

is there a distinct benefit to using triagebot? are there features over what github provides?

Santiago Pastorino (Jun 11 2019 at 19:45, on Zulip):

yeah, I wouldn't say is blocking but it's something that I guess we would like to fix at some point

nikomatsakis (Jun 11 2019 at 19:46, on Zulip):

is there a distinct benefit to using triagebot? are there features over what github provides?

the main thing is that we didn't want to have random folks listed as members of the org

nikomatsakis (Jun 11 2019 at 19:46, on Zulip):

also, it takes effort to let people assign themselves

nikomatsakis (Jun 11 2019 at 19:46, on Zulip):

like @Santiago Pastorino has to add them to the repo etc

mark-i-m (Jun 11 2019 at 19:46, on Zulip):

ah isee

nikomatsakis (Jun 11 2019 at 19:46, on Zulip):

the main thing is that we didn't want to have random folks listed as members of the org

this applies more to the case where the bot lets you add yourself

Santiago Pastorino (Jun 11 2019 at 19:47, on Zulip):

so ... given that is not a blocker, what are the options?

nikomatsakis (Jun 11 2019 at 19:47, on Zulip):

afaik triagebot is not yet doing the assignment

Santiago Pastorino (Jun 11 2019 at 19:47, on Zulip):

we can add people to the org or the other option is to have ... exactly

mark-i-m (Jun 11 2019 at 19:47, on Zulip):

I don't think they need to be added to the org

nikomatsakis (Jun 11 2019 at 19:47, on Zulip):

so I would say you can either (a) add triagebot as a user and assign issues to it, and edit the header, or (b) just invite people to the repo with read perms and assign things to them

Santiago Pastorino (Jun 11 2019 at 19:48, on Zulip):

having triagebot working on rustc-guide or in general in rust-lang/ project is something that somebody is working on?

mark-i-m (Jun 11 2019 at 19:48, on Zulip):

They can just be added as non-admin on the repo

mark-i-m (Jun 11 2019 at 19:48, on Zulip):

e.g. I am not in the rust-lang org

nikomatsakis (Jun 11 2019 at 19:48, on Zulip):

having triagebot working on rustc-guide or in general in rust-lang/ project is something that somebody is working on?

@Pietro Albini is working on it, I think, but I don't know how actively

Santiago Pastorino (Jun 11 2019 at 19:49, on Zulip):

ok, I can ask @Pietro Albini and if they can have something soon I'd wait otherwise I guess we can add people to the org with read perms only

Santiago Pastorino (Jun 11 2019 at 19:49, on Zulip):

and fix that at some point

Santiago Pastorino (Jun 11 2019 at 19:49, on Zulip):

cool

Santiago Pastorino (Jun 11 2019 at 19:49, on Zulip):

the next thing is How/where to link to the forge and the rustc-guide

mark-i-m (Jun 11 2019 at 19:50, on Zulip):

i still think that we should have a rlo/contributing page

Santiago Pastorino (Jun 11 2019 at 19:50, on Zulip):

there's an issue open and somebody, I think it was Florian pointed to that ... yeah, the contributing page

mark-i-m (Jun 11 2019 at 19:50, on Zulip):

that links to all resources (e.g. forge, rustc-guide, etc)

Santiago Pastorino (Jun 11 2019 at 19:50, on Zulip):

there's a proposal from @Manish Goregaokar

Santiago Pastorino (Jun 11 2019 at 19:50, on Zulip):

to have a contributing page

Santiago Pastorino (Jun 11 2019 at 19:51, on Zulip):

so this https://github.com/rust-lang/www.rust-lang.org/issues/843 is the issue I've opened

Santiago Pastorino (Jun 11 2019 at 19:52, on Zulip):

and as @Florian Gilcher pointed out, we have the contribution landing page proposal here https://github.com/rust-lang/www.rust-lang.org/issues/440

mark-i-m (Jun 11 2019 at 19:52, on Zulip):

is there any progress on that

mark-i-m (Jun 11 2019 at 19:52, on Zulip):

?

Santiago Pastorino (Jun 11 2019 at 19:52, on Zulip):

so I guess or either we help them build that page or we just mark that thing as waiting for :)

mark-i-m (Jun 11 2019 at 19:52, on Zulip):

should we try to take on pushing that forward?

Santiago Pastorino (Jun 11 2019 at 19:53, on Zulip):

is there any progress on that

no idea

Santiago Pastorino (Jun 11 2019 at 19:53, on Zulip):

should we try to take on pushing that forward?

I guess if someone has time to help on building that page it would be probably appreciated, I guess ?

mark-i-m (Jun 11 2019 at 19:53, on Zulip):

it looks like the last activity on that thread is from December 2018

Santiago Pastorino (Jun 11 2019 at 19:54, on Zulip):

I'm not sure what else to say about this one

Santiago Pastorino (Jun 11 2019 at 19:55, on Zulip):

but yeah, if any of us have time I guess building the page or doing something about it will help a lot :)

Santiago Pastorino (Jun 11 2019 at 19:55, on Zulip):

next add people to rustc toolstate when available

Santiago Pastorino (Jun 11 2019 at 19:55, on Zulip):

@mark-i-m did you add that one?

mark-i-m (Jun 11 2019 at 19:55, on Zulip):

yep

mark-i-m (Jun 11 2019 at 19:55, on Zulip):

https://github.com/rust-lang/rust/pull/59772 adds rustc guide to toolstate

mark-i-m (Jun 11 2019 at 19:56, on Zulip):

then when people change the compiler, the linkchecker will run

nikomatsakis (Jun 11 2019 at 19:56, on Zulip):

I just subscribed @Florian Gilcher (sorry florian!) in case they have any thoughts about the contributor page idea

mark-i-m (Jun 11 2019 at 19:56, on Zulip):

there is a list of people here: https://github.com/rust-lang/rust/pull/59772/files#diff-cc999bf51e313e1dc34a936abc30a10dR30

mark-i-m (Jun 11 2019 at 19:57, on Zulip):

the list is who should be pinged in case of link breakage

mark-i-m (Jun 11 2019 at 19:57, on Zulip):

it would be great if once that gets merged, others could be added to the list

Santiago Pastorino (Jun 11 2019 at 19:57, on Zulip):

:+1:

Santiago Pastorino (Jun 11 2019 at 19:58, on Zulip):

if that's the thing completely agree

mark-i-m (Jun 11 2019 at 19:58, on Zulip):

any volunteers? (it generally doesn't require technical knowledge)

Santiago Pastorino (Jun 11 2019 at 19:58, on Zulip):

I can be added yeah

Santiago Pastorino (Jun 11 2019 at 19:59, on Zulip):

ok, so 1 minute to finish, is there something else somebody want to say? :)

Amanjeev Sethi (Jun 11 2019 at 19:59, on Zulip):

ok, so 1 minute to finish, is there something else somebody want to say? :slight_smile:

Thank you :smile:

Santiago Pastorino (Jun 11 2019 at 20:00, on Zulip):

ok, so 1 minute to finish, is there something else somebody want to say? :)

Thank you :smile:

no, thank you for your work on the debugging guide ;)

mark-i-m (Jun 11 2019 at 20:00, on Zulip):

That was a productive meeting I think

Santiago Pastorino (Jun 11 2019 at 20:00, on Zulip):

alright, so :hi: everyone!!!

mark-i-m (Jun 11 2019 at 20:01, on Zulip):

i will write up some notes

Last update: Nov 15 2019 at 21:05UTC