hey @nikomatsakis, @Pietro Albini raised a discussion about what level of access do we want to give to people belonging to this wg
and I guess that is a general discussion that may apply to all wgs
@Pietro Albini can you describe the different levels and what each level is allowed to do?
for rustc-guide, tbh giving write access with branch protection enabled for master shouldn't be an issue
you can require an approval from another wg member to be present before they'd be able to merge PRs
I guess that could work :+1:
@nikomatsakis ? would that be ok ?
FWIW, I have had branch protection on for master for a couple months now, requiring a passing travis build before merging. github also supports requiring a approval review from another WG member too
Any updates on this? I think it'd be nice we can merge minor PRs (e.g. updating links, fixing typo, etc.)
/cc @Pietro Albini I don't remember exactly
write access was not given yet
Is there any plan to give it?
dunno, y'all need to decide it
What about? @Santiago Pastorino
:+1: from me /cc @mark-i-m
So the repo is currently set up to require 1 approved review + passing CI
I think it would be good to give access to merge PRs
Currently, spastorino and I are acting as bors :P
@Pietro Albini can you make that happen?
or how do we?
@Santiago Pastorino go to repo settings -> collaborators
and switch wg-learning from triage to write
done, @WG-learning the ones on the wg-learning team on github should have write access
be aware that there's this @WG-learning group but there's also the one on github and those not necessarily match
ask for permission if you are not in any of those
hmm how do we know we are in it?
here you can check on settings and github you can check on rust-lang/team
https://github.com/rust-lang/team/blob/master/people/amanjeev.toml !! :slight_smile: