Stream: t-compiler/wg-learning

Topic: github access for wg


Santiago Pastorino (Sep 12 2019 at 14:04, on Zulip):

hey @nikomatsakis, @Pietro Albini raised a discussion about what level of access do we want to give to people belonging to this wg

Santiago Pastorino (Sep 12 2019 at 14:04, on Zulip):

and I guess that is a general discussion that may apply to all wgs

Santiago Pastorino (Sep 12 2019 at 14:05, on Zulip):

@Pietro Albini can you describe the different levels and what each level is allowed to do?

Pietro Albini (Sep 12 2019 at 14:05, on Zulip):

https://help.github.com/en/articles/repository-permission-levels-for-an-organization

Pietro Albini (Sep 12 2019 at 14:08, on Zulip):

for rustc-guide, tbh giving write access with branch protection enabled for master shouldn't be an issue

Pietro Albini (Sep 12 2019 at 14:09, on Zulip):

you can require an approval from another wg member to be present before they'd be able to merge PRs

Santiago Pastorino (Sep 12 2019 at 14:14, on Zulip):

I guess that could work :+1:

Santiago Pastorino (Sep 12 2019 at 14:14, on Zulip):

@nikomatsakis ? would that be ok ?

mark-i-m (Sep 13 2019 at 16:44, on Zulip):

FWIW, I have had branch protection on for master for a couple months now, requiring a passing travis build before merging. github also supports requiring a approval review from another WG member too

Yuki Okushi (Oct 16 2019 at 10:51, on Zulip):

Any updates on this? I think it'd be nice we can merge minor PRs (e.g. updating links, fixing typo, etc.)

Santiago Pastorino (Oct 16 2019 at 13:50, on Zulip):

/cc @Pietro Albini I don't remember exactly

Pietro Albini (Oct 16 2019 at 13:52, on Zulip):

write access was not given yet

Yuki Okushi (Oct 16 2019 at 14:00, on Zulip):

Is there any plan to give it?

Pietro Albini (Oct 16 2019 at 14:01, on Zulip):

dunno, y'all need to decide it

Yuki Okushi (Oct 16 2019 at 14:02, on Zulip):

What about? @Santiago Pastorino

Santiago Pastorino (Oct 16 2019 at 14:17, on Zulip):

:+1: from me /cc @mark-i-m

mark-i-m (Oct 16 2019 at 19:36, on Zulip):

So the repo is currently set up to require 1 approved review + passing CI

mark-i-m (Oct 16 2019 at 19:37, on Zulip):

I think it would be good to give access to merge PRs

mark-i-m (Oct 16 2019 at 19:37, on Zulip):

Currently, spastorino and I are acting as bors :P

Santiago Pastorino (Oct 16 2019 at 20:38, on Zulip):

@Pietro Albini can you make that happen?

Santiago Pastorino (Oct 16 2019 at 20:39, on Zulip):

or how do we?

Pietro Albini (Oct 16 2019 at 20:39, on Zulip):

@Santiago Pastorino go to repo settings -> collaborators

Pietro Albini (Oct 16 2019 at 20:39, on Zulip):

and switch wg-learning from triage to write

Santiago Pastorino (Oct 16 2019 at 20:41, on Zulip):

done, @WG-learning the ones on the wg-learning team on github should have write access

Santiago Pastorino (Oct 16 2019 at 20:41, on Zulip):

be aware that there's this @WG-learning group but there's also the one on github and those not necessarily match

Santiago Pastorino (Oct 16 2019 at 20:42, on Zulip):

ask for permission if you are not in any of those

Amanjeev Sethi (Oct 16 2019 at 20:47, on Zulip):

hmm how do we know we are in it?

Santiago Pastorino (Oct 16 2019 at 20:48, on Zulip):

here you can check on settings and github you can check on rust-lang/team

Amanjeev Sethi (Oct 16 2019 at 20:49, on Zulip):

https://github.com/rust-lang/team/blob/master/people/amanjeev.toml !! :slight_smile:

Last update: Nov 15 2019 at 20:50UTC