Stream: t-compiler/wg-learning

Topic: new issues to tackle on rustc-guide


Santiago Pastorino (Aug 07 2019 at 14:56, on Zulip):

@Paul Faria has opened a couple of issues https://github.com/rust-lang/rustc-guide/issues/418, https://github.com/rust-lang/rustc-guide/issues/419 and https://github.com/rust-lang/rustc-guide/issues/420

Santiago Pastorino (Aug 07 2019 at 14:57, on Zulip):

I've checked what he is mentioning and commented accordingly with some ideas

Santiago Pastorino (Aug 07 2019 at 14:57, on Zulip):

I wanted to mention a couple of things

Santiago Pastorino (Aug 07 2019 at 14:57, on Zulip):

I think, this is a great and very light way to help :), just checking things quickly and giving an opinion

Santiago Pastorino (Aug 07 2019 at 14:58, on Zulip):

would be great to hear from others but if someone in the @WG-learning group wants to help with little time, this is great help

Santiago Pastorino (Aug 07 2019 at 15:00, on Zulip):

and also, I think that trying to fix the issues that @Paul Faria has opened is also another great way to help and learn and it's not like writing a full rustc-chapter

Santiago Pastorino (Aug 07 2019 at 15:00, on Zulip):

the issues seems more like smaller tasks in case someone is interested

Paul Faria (Aug 15 2019 at 03:39, on Zulip):

and also, I think that trying to fix the issues that Paul Faria has opened is also another great way to help and learn and it's not like writing a full rustc-chapter

I very much agree. My first PR to the rust repo was fixing a typo in documentation. Maybe get this in This week in rust under the "Call for Participation" section?

Santiago Pastorino (Aug 15 2019 at 14:10, on Zulip):

that's a good idea :)

mark-i-m (Aug 16 2019 at 19:50, on Zulip):

@Paul Faria There is a thread on users.rust-lang.org for Call To Participation. If you post there, it will be included in the next issue

Paul Faria (Aug 17 2019 at 15:43, on Zulip):

Is there a typo in https://rust-lang.github.io/rustc-guide/traits/implied-bounds.html#computing-implied-bounds-with-fromenv within this sample:

forall<T> { Implemented(T: A) :- FromEnv(T: A). }

forall<T> { Implemented(T: B) :- FromEnv(T: B). }
forall<T> { FromEnv(T: A) :- FromEnv(T: B). }

forall<T> { Implemented(T: C) :- FromEnv(T: C). }
forall<T> { FromEnv(T: C) :- FromEnv(T: C). }

Shouldn't the last line read forall<T> { FromEnv(T: B) :- FromEnv(T: C). }?

Paul Faria (Aug 17 2019 at 15:43, on Zulip):

Paul Faria There is a thread on users.rust-lang.org for Call To Participation. If you post there, it will be included in the next issue

I'll post there :)

Paul Faria (Aug 17 2019 at 15:48, on Zulip):

https://users.rust-lang.org/t/twir-call-for-participation/4821/250?u=nashenas88 done

Santiago Pastorino (Aug 18 2019 at 04:56, on Zulip):

Is there a typo in https://rust-lang.github.io/rustc-guide/traits/implied-bounds.html#computing-implied-bounds-with-fromenv within this sample:

forall<T> { Implemented(T: A) :- FromEnv(T: A). }

forall<T> { Implemented(T: B) :- FromEnv(T: B). }
forall<T> { FromEnv(T: A) :- FromEnv(T: B). }

forall<T> { Implemented(T: C) :- FromEnv(T: C). }
forall<T> { FromEnv(T: C) :- FromEnv(T: C). }

Shouldn't the last line read forall<T> { FromEnv(T: B) :- FromEnv(T: C). }?

I think so too :)

Paul Faria (Sep 05 2019 at 12:39, on Zulip):

Sorry for the lack of response lately. The hurricane and work kind of kept me extra busy. I'll try to tackle these issues tonight.

Santiago Pastorino (Sep 05 2019 at 13:41, on Zulip):

@Paul Faria great

Santiago Pastorino (Sep 07 2019 at 23:33, on Zulip):

@WG-learning please all the ones that want to be part of WG-learning team on github comment here with your github handle :)

Tshepang Lekhonkhobe (Sep 07 2019 at 23:36, on Zulip):

what are the implications of being part of a github team

Santiago Pastorino (Sep 07 2019 at 23:37, on Zulip):

you can receive notifications when the group is pinged

Santiago Pastorino (Sep 07 2019 at 23:37, on Zulip):

you can help with toolstate

Santiago Pastorino (Sep 07 2019 at 23:38, on Zulip):

and have the rights that the group has, unsure what those are but would be great if we can manage the issue tracker

Santiago Pastorino (Sep 07 2019 at 23:38, on Zulip):

/cc @Pietro Albini

Santiago Pastorino (Sep 07 2019 at 23:38, on Zulip):

can you explain a bit better the implications of being part of a wg on the team repo?

Tshepang Lekhonkhobe (Sep 07 2019 at 23:39, on Zulip):

helping with toolstate would include updating clippy and rustfmt (which are currently broken)?

Tshepang Lekhonkhobe (Sep 07 2019 at 23:40, on Zulip):

my github handle is "tshepang" btw

Pietro Albini (Sep 08 2019 at 10:28, on Zulip):

helping with toolstate would include updating clippy and rustfmt (which are currently broken)?

only updating the rustc-guide when it breaks

Santiago Pastorino (Sep 08 2019 at 13:49, on Zulip):

@Pietro Albini can you explain in general the implications of being part of a wg on the team repo?

Santiago Pastorino (Sep 08 2019 at 13:50, on Zulip):

I've mentioned some things but unsure of those are all the implications

Pietro Albini (Sep 08 2019 at 16:26, on Zulip):

so, being on the team repo on its own doesn't do anything

Pietro Albini (Sep 08 2019 at 16:27, on Zulip):

the team repo just defines the list of members, and allows integrations to be configured

Pietro Albini (Sep 08 2019 at 16:27, on Zulip):

https://github.com/rust-lang/team/blob/a2977c7caf7e93722c19dc13ed43798711caf2cb/teams/wg-learning.toml

Pietro Albini (Sep 08 2019 at 16:27, on Zulip):

here the integrations configured are the website and github

Pietro Albini (Sep 08 2019 at 16:27, on Zulip):

so your github avatar will show up on www.rust-lang.org, and you'll be added as a member of the wg-learning team on github

Pietro Albini (Sep 08 2019 at 16:28, on Zulip):

as for the github team, which perms it will have it will depends on what y'all need

Amanjeev Sethi (Sep 08 2019 at 17:45, on Zulip):

My github handle is amanjeev

Tshepang Lekhonkhobe (Sep 08 2019 at 18:20, on Zulip):

here the integrations configured are the website and github

we be famous then :yum:

Sergey Togi Dashnyam (Sep 08 2019 at 18:27, on Zulip):

My GitHub handle is togiberlin :)

Sergey Togi Dashnyam (Sep 08 2019 at 19:23, on Zulip):

@Santiago Pastorino && @Tshepang Lekhonkhobe
Is this repo: https://github.com/rust-lang/rustc-guide a rewrite/carve-out of the RustC book?

Until now, I thought that this is the official RustC book: https://doc.rust-lang.org/rustc/index.html

Tshepang Lekhonkhobe (Sep 08 2019 at 19:24, on Zulip):

I also confused them at some point, but it's separate... it's about understanding the compiler, while the other is about using the compiler

Sergey Togi Dashnyam (Sep 08 2019 at 19:28, on Zulip):

Thanks for clarification :)

mark-i-m (Sep 08 2019 at 23:45, on Zulip):

I'm mark-i-m and i would hugely appreciate the help fixing rustc-guide itwhitwitwhititwhitwitwhititwhitwitwhititwhitwitwhi

mark-i-m (Sep 08 2019 at 23:46, on Zulip):

when it breaks (sorry mobile zulip is buggy) itwhitwitwhititwhitwitwhit

Santiago Pastorino (Sep 09 2019 at 02:08, on Zulip):

@Sergey Togi Dashnyam you're not part of the zulip group, right?

Santiago Pastorino (Sep 09 2019 at 02:08, on Zulip):

would you like to join to everything?

Santiago Pastorino (Sep 09 2019 at 02:10, on Zulip):

now that you know that is about contributing to rustc-guide, which objective is helping people learning how rustc works, are you still interested in participating? :)

Sergey Togi Dashnyam (Sep 09 2019 at 07:40, on Zulip):

@Santiago Pastorino Hello Santiago, sorry. I forgot to introduce myself =)
My name is Togi, I am a webdev with background in Node/TS and RoR.
I was a bit frustrated with runtime/type errors and yeah, here I am^^
I attended RustConf '19 and heard from Florian and Niko,
that the Rust team (esp. RustC) needs help for documenting stuff.

TLDR: Yes. I would like to join =)

Santiago Pastorino (Sep 09 2019 at 13:59, on Zulip):

@WG-learning for now I've members = ["nikomatsakis", "spastorino", "mark-i-am", "amanjeev", "tshepang"], just in case, I'm going to add the ones that explicitly say so

Santiago Pastorino (Sep 09 2019 at 13:59, on Zulip):

anyway, people can be added later

Santiago Pastorino (Sep 09 2019 at 14:00, on Zulip):

in any case people can be added later, feel free to let me know

Pietro Albini (Sep 09 2019 at 14:02, on Zulip):

@Santiago Pastorino did you fix the comment I made?

Santiago Pastorino (Sep 09 2019 at 14:02, on Zulip):

yes

Pietro Albini (Sep 09 2019 at 14:02, on Zulip):

uh didn't receive a notification yet

Santiago Pastorino (Sep 09 2019 at 14:02, on Zulip):

anyway, do not merge it, I'm going to ping you tomorrow :)

Pietro Albini (Sep 09 2019 at 14:03, on Zulip):

:thumbs_up:

Amanjeev Sethi (Sep 09 2019 at 16:50, on Zulip):

@Santiago Pastorino you have my vote. :slight_smile:

Yuki Okushi (Sep 09 2019 at 20:07, on Zulip):

@Santiago Pastorino I've contributed to rustc-guide and would like to join wg-learning! Are there any seats left? My GitHub username is JohnTitor.

Santiago Pastorino (Sep 09 2019 at 20:39, on Zulip):

@Yuki Okushi sure, adding you on Zulip and to that github PR

mark-i-m (Sep 10 2019 at 23:02, on Zulip):

btw my github handle is mark-i-m _not_ mark-i-am (not the a)

Santiago Pastorino (Sep 11 2019 at 02:46, on Zulip):

ahh ya, don't worry the PR is right

Last update: Nov 15 2019 at 20:00UTC