it seems <https://github.com/rust-lang/rust/pull/60006> was merged without my proposed change (or an argument against) but I think GitHub may be to blame for my comment being lost, heh (and I didn't see the further notifications, oops)
@nnethercote @Alex Crichton would you be against me preparing a PR that emits an uniform JSON message on any file output, as a sort of "output progress"?
oh god I'm trying to load the 19 hidden comments on the PR and it's killing my laptop
@eddyb the thinking on my end at least was that this is all unstable and forwards compatible with that
in the sense that the goal here is to get data about speeding up builds thorugh pipelining
rather than designing a general system of notifications coming out of the compiler
(but leaving room for that to exist of course)
my point is that we have a bad history of accidentally stabilizing some temporary implementation :P
so I'd rather have the dumbest/simplest/most general thing here, and let Cargo use it for pipelining
perhaps, but I also feel like we have a bad history of getting hung up on driving to a "pure" solution while obvious wins are left on the table
sccache for picking out files, etc.
the most simple thing for now is what's already there?
(which we haven't committed to stabilizing at all yet)
I suspect it would be easier to replace all
fs::rename calls, but I guess I can wait until I've actually attempted it, to say that (and not risk eating my own words)
moving metadata emission earlier would be more of an endeavor, I suspect
@nnethercote how was this comment resolved? I see no reply to it https://github.com/rust-lang/rust/pull/60006#discussion_r278147115
@eddyb I have vague YAGNI concerns about doing it before there's an explicit need, but I'm not against it.
@eddyb: ugh, I wrote a reply but must have failed to submit it. I have rewritten it now.
hmm, I probably clicked "resolve conversation", thinking that would post the comment I wrote
so I finally has a chance to take a look at this: the original PR removed some
out_filenames.push(out_filename); lines! that's pretty much where I'd expect something to be emitted
with something like
--crate-type=rlib,dylib, you might spend a little while linking one then the other, so they would be separated in time, I think?
and it's actually only 1 other call site
okay I opened https://github.com/rust-lang/rust/pull/60464
now I can forget about it :P