Stream: t-compiler/wg-rls-2.0/chalk

Topic: Ty


Florian Diebold (Mar 17 2019 at 18:41, on Zulip):

This already looks a lot closer to Chalk, doesn't it: https://github.com/rust-analyzer/rust-analyzer/blob/1ffe23e67462ce4959ee93714405331aeb956540/crates/ra_hir/src/ty.rs#L98

matklad (Mar 17 2019 at 19:38, on Zulip):

Question to chalk folks: why is it TypeName and not TypeConstructor/TypeCtor?

nikomatsakis (Mar 18 2019 at 17:58, on Zulip):

Nice

nikomatsakis (Mar 18 2019 at 17:58, on Zulip):

Re: naming, I don't know. I guess I just think of (e.g.) Vec as being the "name" of the type :)

matklad (Mar 18 2019 at 18:14, on Zulip):

I see Name to be slightly problematic, as it might conflict with other uses of Name (primarily, the hygienic name of item), so I would prefer to name it TypeCtor, both in RLS2 and in chalk :D

nikomatsakis (Mar 18 2019 at 20:12, on Zulip):

I could live with that, although I am not wild about the 'contraction' to Ctor -- I guess it's fairly obvious

matklad (Mar 18 2019 at 20:14, on Zulip):

to be fair, while TypeName is not scary, it's fairly non-obvious what it does :)

Florian Diebold (Mar 21 2019 at 20:34, on Zulip):

I'll call it TypeCtor for now, I'm not a fan of the contraction either but it's used a lot and TypeConstructor is really long...

Last update: Nov 15 2019 at 11:10UTC