Stream: t-compiler/wg-rls-2.0/chalk

Topic: upgrading to the new salsa


nikomatsakis (Mar 22 2019 at 20:34, on Zulip):

So i'm trying to upgrade chalk to the latest salsa and I'm still failing to build with the latest nightly. I guess I need to try and figure this out :/

nikomatsakis (Mar 22 2019 at 20:35, on Zulip):

Ah, I guess that @Florian Diebold's work to make chalk build on stable will be quite useful here

nikomatsakis (Mar 22 2019 at 20:35, on Zulip):

Hmm, it fails on stable too

nikomatsakis (Mar 22 2019 at 20:36, on Zulip):

oh

nikomatsakis (Mar 22 2019 at 20:36, on Zulip):

chalk is not rust 2018

nikomatsakis (Mar 22 2019 at 20:36, on Zulip):

oh, it is

nikomatsakis (Mar 22 2019 at 20:37, on Zulip):

ah, but not the chalk-macros crate

nikomatsakis (Mar 22 2019 at 20:37, on Zulip):

(nope, that's .. not it)

nikomatsakis (Mar 22 2019 at 20:38, on Zulip):

which is good, I guess,

nikomatsakis (Mar 22 2019 at 20:38, on Zulip):

since that would be weird

matklad (Mar 22 2019 at 20:40, on Zulip):

@nikomatsakis re compiler bugs, https://github.com/rust-lang/rust/issues/58291 is driving me crazy :) Who would be the right person to poke? Or .... should I dig this myself? It could be fun, but I need some pointers :)

nikomatsakis (Mar 22 2019 at 20:40, on Zulip):

Ah, yeah, I heard about that before

nikomatsakis (Mar 22 2019 at 20:41, on Zulip):

Hmm. Maybe @mw -- maybe (I hate to say it) me.. looks like it might be related to trait matching stuff specifically

nikomatsakis (Mar 22 2019 at 20:46, on Zulip):

@matklad I'm going to add to my list to try and investigate, perhaps while traveling or at Rust LATAM next week -- one question is, do you know if this is a regression?

nikomatsakis (Mar 22 2019 at 20:46, on Zulip):

since rust-analyzer builds on stable I guess you should be able to bisect a bit?

nikomatsakis (Mar 22 2019 at 20:46, on Zulip):

if it is a regression, then using cargo-bisect-rustc to find the problem and pin it down to a specific PR is always good

matklad (Mar 22 2019 at 20:47, on Zulip):

I am not sure it is a regression. I've observed it for the first time at rust all hands

matklad (Mar 22 2019 at 20:47, on Zulip):

I think that might be related to salsa update, but I'll check

nikomatsakis (Mar 22 2019 at 21:04, on Zulip):

I am not sure it is a regression. I've observed it for the first time at rust all hands

ok. it'd be nice if it was :)

Last update: Nov 15 2019 at 09:45UTC