Stream: t-compiler/wg-rfc-2229

Topic: sync 2019-03-26


blitzerr (Mar 26 2019 at 03:14, on Zulip):

@nikomatsakis @csmoe @ange we can use it for tomorrow's meeting. @csmoe can read async if they get too tired and cannot stay up that late

blitzerr (Mar 26 2019 at 03:18, on Zulip):

Roadmap if we need a link to it

blitzerr (Mar 26 2019 at 03:19, on Zulip):

RFC

blitzerr (Mar 26 2019 at 18:00, on Zulip):

@WG-rfc-2229 :wave:

blitzerr (Mar 26 2019 at 18:01, on Zulip):

@nikomatsakis :wave:

nikomatsakis (Mar 26 2019 at 18:01, on Zulip):

Hey y'all :)

nikomatsakis (Mar 26 2019 at 18:01, on Zulip):

BTW, I should say -- next week i'll be on vacation

nikomatsakis (Mar 26 2019 at 18:02, on Zulip):

this week, i'm a bit busy because i've been working on preparing for an upcoming conference

ange (Mar 26 2019 at 18:02, on Zulip):

hello

nikomatsakis (Mar 26 2019 at 18:02, on Zulip):

so I haven't e.g. had time to catch up on stuff :)

nikomatsakis (Mar 26 2019 at 18:02, on Zulip):

( I see @ange you left some notes, I can try to catch up with those later on )

ange (Mar 26 2019 at 18:03, on Zulip):

@nikomatsakis whatever you can manage :-)

nikomatsakis (Mar 26 2019 at 18:05, on Zulip):

@blitzerr regarding the test failures, did you ever get any chance to look into what's going on?

nikomatsakis (Mar 26 2019 at 18:05, on Zulip):

I sort of forget where we left it, I think we were trying to "bisect" and figure out why the error went away?

blitzerr (Mar 26 2019 at 18:05, on Zulip):

So how we would like to begin the sync today ? We rundown the roadmap and see where we land or we ask everyone how far along they have got and where are they stuck or some other way ?

blitzerr (Mar 26 2019 at 18:05, on Zulip):

I tried for a little bit last night.

blitzerr (Mar 26 2019 at 18:06, on Zulip):

I think disabling none of the test fixing commits (i.e. returning false in all cases), solves the problem

blitzerr (Mar 26 2019 at 18:07, on Zulip):

Now I will try to bisect through the actual code commits to see which one introduced it.

nikomatsakis (Mar 26 2019 at 18:07, on Zulip):

So how we would like to begin the sync today ?

In general, i've found a good pattern is to have a list of tasks that you knid of carry over from week to week, and go down task-by-task to check-in on how things are going

nikomatsakis (Mar 26 2019 at 18:07, on Zulip):

in this case, tasks kind of align closely to people ..

nikomatsakis (Mar 26 2019 at 18:07, on Zulip):

I think disabling none of the test fixing commits (i.e. returning false in all cases), solves the problem

hmm, I didn't observe that, but maybe I was missing something

nikomatsakis (Mar 26 2019 at 18:08, on Zulip):

anyway, @blitzerr, I'll let you drive if you dont mind :)

nikomatsakis (Mar 26 2019 at 18:08, on Zulip):

well I guess we're discussing the test failures anyway. I still think that "bisecting" is sort of the way to get a clue what the problem is

blitzerr (Mar 26 2019 at 18:09, on Zulip):

Sure @nikomatsakis I will bisect. Sometimes you just have your way to eyeball the problem :D

blitzerr (Mar 26 2019 at 18:09, on Zulip):

So I was thinking if this is one such case.

nikomatsakis (Mar 26 2019 at 18:09, on Zulip):

Yeah .. I didn't see it.

blitzerr (Mar 26 2019 at 18:10, on Zulip):

To be fair, I have a little shift with some of my day to day, and so I have been distracted from rustc. I will get back to it

blitzerr (Mar 26 2019 at 18:10, on Zulip):

Okay, guys. So where do we stand.

blitzerr (Mar 26 2019 at 18:10, on Zulip):

Update from me:

blitzerr (Mar 26 2019 at 18:11, on Zulip):

I am still looking at the test failures from fix the error messages around trait selection as in the roadmap

blitzerr (Mar 26 2019 at 18:11, on Zulip):

I can update for @csmoe

blitzerr (Mar 26 2019 at 18:12, on Zulip):

@nikomatsakis They did this part (Make a list of code that uses with_freevars) as on the roadmap

nikomatsakis (Mar 26 2019 at 18:12, on Zulip):

Ah, yes, right

nikomatsakis (Mar 26 2019 at 18:12, on Zulip):

so now they need some feedback on how to handle those cases

blitzerr (Mar 26 2019 at 18:12, on Zulip):

They are probably waiting for your feedback on this. Did you get a chance to look at that or have some thoughts ?

blitzerr (Mar 26 2019 at 18:13, on Zulip):

right

nikomatsakis (Mar 26 2019 at 18:13, on Zulip):

I didn't do that but I can add it to my to do list for next day or two

nikomatsakis (Mar 26 2019 at 18:13, on Zulip):

shouldn't take that long

nikomatsakis (Mar 26 2019 at 18:13, on Zulip):

well, at least for some of the cases :)

blitzerr (Mar 26 2019 at 18:13, on Zulip):

Sure.

blitzerr (Mar 26 2019 at 18:14, on Zulip):

We can start with the easy ones and get to the more involved changes later.

blitzerr (Mar 26 2019 at 18:14, on Zulip):

Hopefully if I get the test errors fixed, I can take some and parallelize that.

blitzerr (Mar 26 2019 at 18:14, on Zulip):

@ange you want to tell us where you are ?

ange (Mar 26 2019 at 18:15, on Zulip):

fwiw if anyone wants an extra pair of eyes or would find explaining their problem to someone else helpful, maybe I could be of use

ange (Mar 26 2019 at 18:15, on Zulip):

sure

ange (Mar 26 2019 at 18:16, on Zulip):

my current status is that I've done all my exploratory (and kind of hack-through) coding by extending the cmt_ machinery

nikomatsakis (Mar 26 2019 at 18:16, on Zulip):

fwiw if anyone wants an extra pair of eyes or would find explaining their problem to someone else helpful, maybe I could be of use

this is a good point, @blitzerr if you're busy, seems plausible that @ange could help revert the last couple commits etc

blitzerr (Mar 26 2019 at 18:16, on Zulip):

@nikomatsakis sure

ange (Mar 26 2019 at 18:17, on Zulip):

I'm sure that I could find implementation solutions, but some higher-level feedback on the implementation strategy (e.g. what use cases we'd want to worry about in a post-AST-borrowck) would be great at this stage

blitzerr (Mar 26 2019 at 18:17, on Zulip):

@ange you cool with that ?

ange (Mar 26 2019 at 18:17, on Zulip):

more details in my large-ish message on the upvar path topic here in this stream

ange (Mar 26 2019 at 18:18, on Zulip):

@blitzerr sure, I'm interested in seeing this move forward sooner rather than later too :-)

blitzerr (Mar 26 2019 at 18:19, on Zulip):

@ange I can tell you about the branch I am working off of and then we can talk about what else is required

blitzerr (Mar 26 2019 at 18:19, on Zulip):

thank you ! :slight_smile:

ange (Mar 26 2019 at 18:19, on Zulip):

I think I'm going to try and push forward even in the absence of feedback though (so no pressure to @nikomatsakis ), it's just that it might be a better use of everyone's time if I don't have too many false starts

ange (Mar 26 2019 at 18:19, on Zulip):

@blitzerr sure thing!

blitzerr (Mar 26 2019 at 18:20, on Zulip):

@ange I would request you to put down your thoughts and ways of solving in a doc, just bullet points. Such that if this does not go through completion by May end, someone else can refer to it and take it forward

ange (Mar 26 2019 at 18:21, on Zulip):

@blitzerr np, I have extensive notes

blitzerr (Mar 26 2019 at 18:21, on Zulip):

Do people think that's a good idea ?

blitzerr (Mar 26 2019 at 18:21, on Zulip):

@ange Awesome

blitzerr (Mar 26 2019 at 18:22, on Zulip):

@nikomatsakis anything else on your mind today, you would like to discuss ?

nikomatsakis (Mar 26 2019 at 18:22, on Zulip):

So yeah it seems like for me the two things to do are to try and get back to @ange a bit, and to look over the list @csmoe compiled

csmoe (Mar 26 2019 at 18:22, on Zulip):

here i am :slight_smile:

nikomatsakis (Mar 26 2019 at 18:22, on Zulip):

Nothing else on my mind in particular :)

blitzerr (Mar 26 2019 at 18:23, on Zulip):

nikomatsakis They did this part (Make a list of code that uses with_freevars) as on the roadmap

@csmoe this is what I updated from your side. Please add if I missed something

csmoe (Mar 26 2019 at 18:24, on Zulip):

that's all

blitzerr (Mar 26 2019 at 18:24, on Zulip):

If no one else have anything more for today, then we can give back 5 minutes of their lives back to people :D

ange (Mar 26 2019 at 18:25, on Zulip):

next sync? one week from now?

blitzerr (Mar 26 2019 at 18:25, on Zulip):

yup.

blitzerr (Mar 26 2019 at 18:25, on Zulip):

same time

blitzerr (Mar 26 2019 at 18:26, on Zulip):

@WG-rfc-2229 have a great rest of your day/night/morning :wave:

ange (Mar 26 2019 at 18:26, on Zulip):

@blitzerr thanks for hosting ;-)

nikomatsakis (Mar 26 2019 at 18:27, on Zulip):

Indeed, thanks! Sorry I've been distracted today.

blitzerr (Mar 26 2019 at 18:27, on Zulip):

My pleasure, didn' t have the wine but :wine: this will have to do for now

blitzerr (Mar 26 2019 at 18:28, on Zulip):

:wave:

blitzerr (Mar 26 2019 at 18:30, on Zulip):

@nikomatsakis I see that the meeting is not a recurring one. Do we want to make it recurring or we shall have it ad hoc ?

blitzerr (Mar 26 2019 at 18:31, on Zulip):

I don't think I can make changes to the calendar

nikomatsakis (Apr 08 2019 at 17:50, on Zulip):

I don't think I can make changes to the calendar

whoops, sorry, made it recurring now

Last update: Nov 17 2019 at 07:00UTC