Stream: t-compiler/wg-rfc-2229

Topic: sync 2019-04-30


nikomatsakis (Apr 30 2019 at 18:00, on Zulip):

Hi @WG-rfc-2229 =)

nikomatsakis (Apr 30 2019 at 18:00, on Zulip):

I've done nothing this week however I am hoping to get on top of @csmoe's PR, now that I've cleared out some other things from my review queue

ange (Apr 30 2019 at 18:02, on Zulip):

Cool. Guessing the tentative planning mentioned in the compliler meeting mostly holds?

blitzerr (Apr 30 2019 at 18:02, on Zulip):

HI everyone :wave:

blitzerr (Apr 30 2019 at 18:04, on Zulip):

@ange What was the tentative planning ? Can you summarize for me ?

blitzerr (Apr 30 2019 at 18:04, on Zulip):

Sorry about that. I missed it

ange (Apr 30 2019 at 18:05, on Zulip):

@blitzerr traveling, on mobile; in short, perhaps working on your PR and maybe pausing afterwards. Do look up the log though, in case I'm misremembering

blitzerr (Apr 30 2019 at 18:06, on Zulip):

@ange Thanks I do remember that part as it came with my mention. Was wondering if something else

nikomatsakis (Apr 30 2019 at 18:07, on Zulip):

planning from compiler team meeting: https://github.com/rust-lang/compiler-team/blob/master/working-groups/rfc-2229/README.md

blitzerr (Apr 30 2019 at 18:07, on Zulip):

@nikomatsakis can you point me to @csmoe 's PR. I would like to gloss over it too.

nikomatsakis (Apr 30 2019 at 18:07, on Zulip):

oops, wrong link

nikomatsakis (Apr 30 2019 at 18:07, on Zulip):

https://github.com/rust-lang/compiler-team/blob/master/minutes/triage-meeting/2019-04-25.md#wg-rfc-2229

nikomatsakis (Apr 30 2019 at 18:08, on Zulip):

nikomatsakis can you point me to csmoe 's PR. I would like to gloss over it too.

https://github.com/rust-lang/rust/pull/60227

blitzerr (Apr 30 2019 at 18:08, on Zulip):

Thanks a lot @nikomatsakis

nikomatsakis (Apr 30 2019 at 18:10, on Zulip):

just gave it a quick read, and it looks good

nikomatsakis (Apr 30 2019 at 18:10, on Zulip):

not complete yet I don't think

blitzerr (Apr 30 2019 at 18:11, on Zulip):

So on the compiler error regression that my PR caused, have we made much progress ?

nikomatsakis (Apr 30 2019 at 18:11, on Zulip):

No, I was thinking I'd try to investigate that for the next few minut :)

nikomatsakis (Apr 30 2019 at 18:11, on Zulip):

the one thing I would say more generally is

nikomatsakis (Apr 30 2019 at 18:11, on Zulip):

@ange and I had a good conversation about how to handle the next few steps

nikomatsakis (Apr 30 2019 at 18:12, on Zulip):

I think the first step is going to be refactoring and simplifying the ExprUseVisitor to be more targeted at this use case

blitzerr (Apr 30 2019 at 18:12, on Zulip):

ange and I had a good conversation about how to handle the next few steps

nice.

nikomatsakis (Apr 30 2019 at 18:12, on Zulip):

well, probably making a clone of it, since the EUV will be going away

nikomatsakis (Apr 30 2019 at 18:12, on Zulip):

if we do this design, I'd like to make use of the new compiler team "design meeting" plans

blitzerr (Apr 30 2019 at 18:12, on Zulip):

We have it added in the roadmap paperdoc ?

nikomatsakis (Apr 30 2019 at 18:12, on Zulip):

to try and write-up the plan

nikomatsakis (Apr 30 2019 at 18:12, on Zulip):

We have it added in the roadmap paperdoc ?

that's a very smart question :) I'm not sure how much we noted down

blitzerr (Apr 30 2019 at 18:12, on Zulip):

:D

nikomatsakis (Apr 30 2019 at 18:13, on Zulip):

our conversation was here on Zulip

nikomatsakis (Apr 30 2019 at 18:13, on Zulip):

(for the record)

nikomatsakis (Apr 30 2019 at 18:13, on Zulip):

@ange also has a paper doc with extensive notes

nikomatsakis (Apr 30 2019 at 18:13, on Zulip):

the big question for me is how to prioritize this work -- but actually turning it into "code cleanup and refactoring", in a way, ups the priority for me mildly, since I think that cleaning up rustc is also quite important

blitzerr (Apr 30 2019 at 18:14, on Zulip):

Looks like @ange has made some great progress. Great work !!

ange (Apr 30 2019 at 18:14, on Zulip):

I don't think we have enough info for someone to do the EUV rewrite yet though?

blitzerr (Apr 30 2019 at 18:14, on Zulip):

the big question for me is how to prioritize this work -- but actually turning it into "code cleanup and refactoring", in a way, ups the priority for me mildly, since I think that cleaning up rustc is also quite important

I am very much in tune with that thought.

blitzerr (Apr 30 2019 at 18:16, on Zulip):

This is ignorant of me, what is EUV ?

nikomatsakis (Apr 30 2019 at 18:16, on Zulip):

The ExprUseVisitor--

nikomatsakis (Apr 30 2019 at 18:16, on Zulip):

it's a bit of code that walks the HIR and figures out which paths are borrowed, which are moved, etc

blitzerr (Apr 30 2019 at 18:16, on Zulip):

Ahh !

nikomatsakis (Apr 30 2019 at 18:16, on Zulip):

we use it as part of figuring out what a closure does

nikomatsakis (Apr 30 2019 at 18:16, on Zulip):

i.e., how it uses its upvars

blitzerr (Apr 30 2019 at 18:16, on Zulip):

I remember that part.

nikomatsakis (Apr 30 2019 at 18:16, on Zulip):

it is also used from borrowck (which was the bit of code it was invented for)

nikomatsakis (Apr 30 2019 at 18:17, on Zulip):

but borrowck has been rewritten to operate on MIR, which no longer needs such a thing since it's not hard to figure out

blitzerr (Apr 30 2019 at 18:17, on Zulip):

Not well versed with the acronyms yet :slight_smile:

nikomatsakis (Apr 30 2019 at 18:17, on Zulip):

and so I have been hoping to rewrite the MC (mem-categorization) / EUV (expr-user-visitor) code for a while now

blitzerr (Apr 30 2019 at 18:17, on Zulip):

We can do that cleanup as well.

nikomatsakis (Apr 30 2019 at 18:18, on Zulip):

yeah, it's just that it'll take some planning

blitzerr (Apr 30 2019 at 18:18, on Zulip):

My take away from earlier cleanup is that it makes people like me understand the underpinnings of the compiler before making a meaty change

nikomatsakis (Apr 30 2019 at 18:18, on Zulip):

right

nikomatsakis (Apr 30 2019 at 18:18, on Zulip):

it's a good opportunity to "do it right" --

nikomatsakis (Apr 30 2019 at 18:18, on Zulip):

i.e., I'd like to have a kind of plan, and then add some rustc-guide docs, etc

nikomatsakis (Apr 30 2019 at 18:19, on Zulip):

anyway, let me take a look at these tests :)

blitzerr (Apr 30 2019 at 18:19, on Zulip):

thanks a lot.

blitzerr (Apr 30 2019 at 18:19, on Zulip):

@WG-rfc-2229 Will that be all for today ?

Last update: Nov 17 2019 at 07:00UTC