Stream: t-compiler/wg-rfc-2229

Topic: expr-use-visitor refactoring


nikomatsakis (Apr 25 2019 at 14:52, on Zulip):

So in the meeting today, @oli mentioned that clippy makes a lot of use of the ExprUseVisitor. We should probably take a look at those uses, as I am contemplating proposing a rewrite as part of this WG, and if so we would want to make sure those uses are accommodated.

blitzerr (Apr 25 2019 at 14:53, on Zulip):

:wave:

blitzerr (Apr 25 2019 at 14:54, on Zulip):

@nikomatsakis any code you have in mind that we can look at to get an idea ?

oli (Apr 25 2019 at 14:55, on Zulip):

Well, these are our use sites: https://github.com/rust-lang/rust-clippy/search?q=ExprUseVisitor&unscoped_q=ExprUseVisitor

oli (Apr 25 2019 at 15:26, on Zulip):

I'm certain some of these could be written differently (e.g. as a MIR-lint), so if that's preferrable, I'd be happy to rewrite some of these

blitzerr (Apr 25 2019 at 15:27, on Zulip):

Thanks for the links @oli

Last update: Nov 17 2019 at 07:30UTC