Stream: t-compiler/wg-self-profile

Topic: meta data in crox events


andjo403 (Nov 09 2019 at 22:17, on Zulip):

have made the first part of supporting showing multiple rustc invocations in one json file by setting the timestamp to duration from unix_epoch and the process_id in the crox events from the metadata.

andjo403 (Nov 09 2019 at 22:31, on Zulip):

as the PR is now is possible to merge with trace2html my giving multiple json files to convert to html.
but for measureme I do not know how we want to specify that we want to merge multiple rustc invocations.
shall there be an crox parameter only point to a directory where all logs is stored or shall we allow multiple file_prefixes?
when merging the logs the minimum_duration is maybe needed but it can be an long and a short log that shall be merged is the same minimum_duration is used the short maybe is removed, how shall that be handled?

andjo403 (Nov 10 2019 at 17:48, on Zulip):

have added a dir parameter and also supports multiple file_prefix to merge.
do not think that the minimum-duration is a problem when profiling compiling rustc with minimum-duration=50us i get a log file on 139M
but the minimum-duration parameter is needed at least for merging all crates in rustc when tried without I got a 2.6G large file :)

mw (Nov 11 2019 at 13:51, on Zulip):

Here is the current (rough) idea for a tool that will make using profiling more user-friendly: https://internals.rust-lang.org/t/compiler-profiling-survey/10969/18

mw (Nov 11 2019 at 13:51, on Zulip):

what I had in mind there was that the tool would create a whole new directory for each cargo session

mw (Nov 11 2019 at 13:52, on Zulip):

so that postprocessing would happen on an entire directory

mw (Nov 11 2019 at 13:54, on Zulip):

but some way of explicitly filtering file-prefixes (or listing them explicitly) is definitely a good idea.

mw (Nov 11 2019 at 13:55, on Zulip):

@andjo403 I'm not sure I understand the minimum duration question.

andjo403 (Nov 11 2019 at 14:00, on Zulip):

I was thinking that maybe we needed to have the minimum duration per crate but think it works with one common

Last update: Dec 12 2019 at 00:50UTC