Stream: t-compiler/wg-self-profile

Topic: integrating measureme into rustc


mw (Mar 28 2019 at 12:15, on Zulip):

@Wesley Wiser, you mentioned that you already have a prototype of this. Are there any blockers or issues that we should address?

mw (Mar 28 2019 at 12:17, on Zulip):

For clarifying issues around how to do things in rustc concretely, I suggest that we do the usual: You open PR whenever you feel ready and we discuss specifics there.

Wesley Wiser (Mar 28 2019 at 13:10, on Zulip):

It's just unfinished

Wesley Wiser (Mar 28 2019 at 13:11, on Zulip):

I'm hoping to have it done in the next few days or maybe this weekend

Wesley Wiser (Mar 28 2019 at 13:13, on Zulip):

I do have a question around how to handle the QueryCacheHit and QueryCount events though (here)

Wesley Wiser (Mar 28 2019 at 13:13, on Zulip):

Did you have an idea around how to handle serializing that data?

mw (Mar 28 2019 at 13:34, on Zulip):

QueryCacheHit should just be a single event that is generated instead of a (QueryStart, QueryEnd) pair, I'd say

mw (Mar 28 2019 at 13:34, on Zulip):

I don't remember what QueryCount is :)

mw (Mar 28 2019 at 13:36, on Zulip):

Oh, it's just the total number of query results for a given query

mw (Mar 28 2019 at 13:37, on Zulip):

that information is implicit in the stream of events

mw (Mar 28 2019 at 13:37, on Zulip):

e.g. just count all the QueryStart events for a given query to get the total number

Wesley Wiser (Mar 28 2019 at 13:41, on Zulip):

Hmm... that's true. I'll just remove that event.

Last update: Nov 17 2019 at 08:00UTC