Stream: t-compiler/wg-self-profile

Topic: new version


andjo403 (Nov 11 2019 at 19:24, on Zulip):

a new version of measureme to merge in to rustc is needed as now it is not possible to used the latest of the tools due to new file format

andjo403 (Nov 11 2019 at 19:28, on Zulip):

shall we maybe depend on a published version of merasureme in all the tools? to avoid having to select an old commit to build a tool from that works with the currently used measureme version in rustc.

Wesley Wiser (Nov 12 2019 at 01:23, on Zulip):

Yeah, that was the issue I hit testing your PR (#84). I built a copy of rustc locally with a patch to use my local measureme checkout.

Wesley Wiser (Nov 12 2019 at 01:23, on Zulip):

Really good work on that btw!

andjo403 (Nov 12 2019 at 07:19, on Zulip):

thank you

andjo403 (Nov 14 2019 at 11:23, on Zulip):

Is there anything I can do to help with releasing a new version?

Wesley Wiser (Nov 14 2019 at 11:28, on Zulip):

@mw Do you concur we should release a new version and bump rustc's dependency?

Wesley Wiser (Nov 14 2019 at 11:28, on Zulip):

I can handle the actual work if need be.

mw (Nov 14 2019 at 13:35, on Zulip):

Well, I wanted to do some more changes to the file format before releasing the next version

mw (Nov 14 2019 at 13:35, on Zulip):

most notably make RawEvent more compact

mw (Nov 14 2019 at 13:35, on Zulip):

but also making the string table more compact

mw (Nov 14 2019 at 13:36, on Zulip):

the former should be pretty quick to do

mw (Nov 14 2019 at 13:36, on Zulip):

I can try to do a PR to measureme later today and one to rustc tomorrow

mw (Nov 14 2019 at 13:38, on Zulip):

I'd like to avoid releasing two or three new versions in close succession because we need to update perf.rlo each time

mw (Nov 14 2019 at 13:40, on Zulip):

@Wesley Wiser did you ever get to looking into making measureme a rustup component? that would make releasing new versions simpler.

andjo403 (Nov 14 2019 at 15:04, on Zulip):

Or also possible that we do the new work on an branch and reset master to the commit before we changed the file format. Only feels bad that the master do not work with what rustc generates

Wesley Wiser (Nov 14 2019 at 15:28, on Zulip):

@Wesley Wiser did you ever get to looking into making measureme a rustup component? that would make releasing new versions simpler.

I haven't yet, no. I got nerd-sniped by some mir-opt stuff.

Wesley Wiser (Nov 14 2019 at 15:28, on Zulip):

Let's wait until @mw thinks the format is relatively stable again.

Last update: Dec 12 2019 at 01:05UTC