Stream: t-compiler/wg-self-profile

Topic: `codegen_crate_metadata` event does not show up on perf.rlo


mw (Oct 24 2019 at 15:35, on Zulip):

E.g. here: https://perf.rust-lang.org/detailed-query.html?commit=4a8c5b20c7772bc5342b83d4b0696ea216ef75a7&benchmark=regex-debug&run_name=clean

mw (Oct 24 2019 at 15:35, on Zulip):

need to investigate if other events are missing too and why...

simulacrum (Oct 24 2019 at 16:38, on Zulip):

@mw are you sure that the events were added prior to that commit?

simulacrum (Oct 24 2019 at 16:38, on Zulip):

we don't do anything special I think so if they're not in summarize output that would mean we don't see them

mw (Oct 25 2019 at 09:01, on Zulip):

I haven't investigated at all yet. I am pretty sure that the event is already part of that commit (because it was the newest on available). But maybe the event is in the wrong code path or something.

mw (Oct 28 2019 at 10:06, on Zulip):

Turns out the event was just placed in a weird code path.

mw (Oct 28 2019 at 10:06, on Zulip):

I opened to https://github.com/rust-lang/rust/pull/65891 to fix this.

mw (Oct 28 2019 at 10:08, on Zulip):

The naming and comments around https://github.com/rust-lang/rust/blob/61c451c51e1210a7d907f9919da8b0a08ff6915e/src/librustc_codegen_ssa/base.rs#L575-L593 could need some improvement though.

Last update: Nov 15 2019 at 21:20UTC