Stream: t-compiler/wg-self-profile

Topic: crate structure (and names)


mw (Nov 07 2019 at 08:47, on Zulip):

A recent PR by @andjo403 has created the tools_lib, which I think is a good idea. In fact, I'd like to go even further and move all the code that is used for reading profiles into this library (i.e. things like ProfilingData). That would leave only writing parts (Profiler, StringTableBuilder, etc) in the measureme crate.

mw (Nov 07 2019 at 08:49, on Zulip):

It would also make it easier to depend on crates.io stuff for the reading/processing stuff because I want to keep the measureme crate as lean as possible but don't care if tools_lib and the tools depend on lots of upstream things.

mw (Nov 07 2019 at 08:50, on Zulip):

I do think we should change the name of tools_lib though. Possibly to something that has measureme in the name.

mw (Nov 07 2019 at 08:51, on Zulip):

Suggestions welcome!

andjo403 (Nov 09 2019 at 18:47, on Zulip):

maybe simply measureme_tools_lib

andjo403 (Nov 09 2019 at 18:49, on Zulip):

have also made a PR with the split https://github.com/rust-lang/measureme/pull/83

mw (Nov 11 2019 at 13:37, on Zulip):

I just gave a review, thanks @andjo403 !

mw (Nov 11 2019 at 13:37, on Zulip):

let's discuss the name for tools_lib (cc @WG-self-profile )

simulacrum (Nov 11 2019 at 13:38, on Zulip):

profile_reader perhaps? (per your earlier comment)

mw (Nov 11 2019 at 13:38, on Zulip):

some candidates:

simulacrum (Nov 11 2019 at 13:39, on Zulip):

afaict, it has nothing to do with "tools" perse, it's just "I want to read a measureme profile" -- right?

mw (Nov 11 2019 at 13:39, on Zulip):

it depends. right now there is flamegraph related code in there (shared by two tools)

mw (Nov 11 2019 at 13:43, on Zulip):

I think something with "postprocess(ing)" or "analysis" or something similar in the name captures the role of this crate best (assuming that this crate is where more general purpose post-processing stuff will end up in).

simulacrum (Nov 11 2019 at 13:45, on Zulip):

hm, okay

simulacrum (Nov 11 2019 at 13:45, on Zulip):

analyzeme then to go with postprocessme but shorter

simulacrum (Nov 11 2019 at 13:46, on Zulip):

I don't have strong opinions though

mw (Nov 11 2019 at 13:46, on Zulip):

@simulacrum, would you prefer having a very targeted crate just for the reading stuff and a bigger, catch-all "tools_lib"?

simulacrum (Nov 11 2019 at 13:46, on Zulip):

probably a catch-all

simulacrum (Nov 11 2019 at 13:46, on Zulip):

I don't really care too much for splitting up crates in general

simulacrum (Nov 11 2019 at 13:47, on Zulip):

e.g. collector in perf.rlo has like ~300 dependencies today

simulacrum (Nov 11 2019 at 13:47, on Zulip):

so there's essentially no advantage to adding or losing a couple :)

mw (Nov 11 2019 at 13:47, on Zulip):

:)

andjo403 (Nov 11 2019 at 13:52, on Zulip):

analyzeme or postprocessme was good maybe more postpocessme was better

Wesley Wiser (Nov 11 2019 at 15:04, on Zulip):

I like analyzeme :)

andjo403 (Nov 11 2019 at 17:00, on Zulip):

selected analyzeme as all felt ok with it

Last update: Nov 15 2019 at 20:15UTC