Stream: t-compiler/wg-self-profile

Topic: thread ids

simulacrum (Sep 21 2019 at 15:01, on Zulip):

The current logic calls thread::current().id() on every event afaict, which is actually somewhat expensive -- it's a TLS lookup, then an Arc::clone -- neither of which is particularly cheap, though I haven't profiled. I suspect we might be able to recoup some performance if we were to not collect thread IDs; afaict for perf.rlo we don't need them (they're not represented in summarize output)

mw (Sep 23 2019 at 08:33, on Zulip):

for multithreaded rustc they will be important. but maybe we could make recording them opt-in? we should profile though, if that really makes a difference,

Last update: Jul 03 2020 at 16:45UTC