@mw What do you think about making it a bit easier to turn on query key recording for self-profile? We could do something like enable that option if the
-Z --verboseis also enabled.
I'm not particularly fond of the current option either
I'm not sure if tying to
-Zverbose is a good idea though
-Z self-profile-record-query-keys would be better as I cannot remember how turn it on without looking at the source code
would an alias help
/me has to go to the source code in order to come up with example :P
I'd be fine with that
-Zself-profile-events=all would already work
Oh, I forgot about all
Although, the cache hit events bloat the output a lot and aren't usually very interesting
but that would also include everything else
-Zself-profile-events=default,query-keys would also work?
Ah, that should work
It would be nice if there was a shorter option but perhaps just documenting that in
-Z help would be enough
Then I wouldn't have to go look at the source code :laughter_tears:
yeah, it's definitely annoying
Just documenting it would be helpful
I think that's sufficient for now
I'd be happy to r+ PR that does that
Ok, I'll do that tonight
I've also been thinking it might be nice to a blog post that shows off a complete profiling session and what our tools can do
This would be a good thing to incorporate in that
Especially now that the data shows in
-Zself-profile-events=crox as alias?
that _would_ be a nice blog post!
I'd still like to have a tool like described here at some point: https://internals.rust-lang.org/t/compiler-profiling-survey/10969/18
I think the curses-ui might be the next thing to work on
Now that we have the query keys, I think summarize should let you drill into a particular query and see all of the invocations with query keys ordered by self-time (or something)
It would also be nice to just point it at a directory and let it intelligently pick up on the event trace(s) within it
it might be a good start to collect cases where one thought "I wish it would do that automatically"