Stream: t-compiler/wg-llvm

Topic: D60846


dlrobertson (May 02 2019 at 01:13, on Zulip):

@Nikita Popov what did you run to get the test failure due to the D60846 patch?

Nikita Popov (May 02 2019 at 07:17, on Zulip):

Something like build/bin/llvm-lit test/Transforms/LICM

Nikita Popov (May 02 2019 at 07:22, on Zulip):

Here's the diff over regenerated checks: https://gist.github.com/nikic/c446e525eb5968e1323ca756bf342ef0

dlrobertson (May 03 2019 at 02:00, on Zulip):

Hmmm I must be doing something wrong... I didn't get that diff... I'll tinker some more

dlrobertson (May 03 2019 at 03:08, on Zulip):

Clean build seems to have done the trick. I get the same result you got from opt now

dlrobertson (May 07 2019 at 00:46, on Zulip):

Should I wait for spatel to re-review the patch before I commit it?

Luqman Aden (May 07 2019 at 05:30, on Zulip):

They did say "we should be set after that" and @Nikita Popov has also already approved. I would also argue it isn't a particularly controversial change.

Nikita Popov (May 07 2019 at 07:21, on Zulip):

@dlrobertson Should be okay to commit.

dlrobertson (May 07 2019 at 11:11, on Zulip):

:+1:

Nikita Popov (May 09 2019 at 19:43, on Zulip):

So, looks like this isn't as simple as it looked...

Nikita Popov (May 09 2019 at 19:44, on Zulip):

I feel like there should be a way to make the phi threading in instsimplify miscompile independently of this patch (there are other things depending on the context instruction), but I can't really come up with anything.

Nikita Popov (May 23 2019 at 19:35, on Zulip):

@dlrobertson Do you need help with fixing up the patch?

dlrobertson (May 23 2019 at 19:36, on Zulip):

@Nikita Popov hey, I honestly haven't had time to work on it.

dlrobertson (May 23 2019 at 19:36, on Zulip):

I'm mostly not going to be around for another month or so

dlrobertson (May 23 2019 at 19:37, on Zulip):

Just started a new job and my wife is due this week :smile:

dlrobertson (May 23 2019 at 19:38, on Zulip):

If we need to hand it off to someone else, in the meantime... I'm totally okay with that

nagisa (May 23 2019 at 21:14, on Zulip):

(Early) congrats @dlrobertson!

Last update: Nov 15 2019 at 10:30UTC