Stream: t-compiler/wg-parallel-rustc

Topic: pending PRs


mw (Mar 01 2019 at 16:18, on Zulip):

@Zoxc I'll try to do some reviewing early next week!

Zoxc (Jun 17 2019 at 22:00, on Zulip):

With my latest set of PRs , I think parallel rustc performs well enough to turn on.

The PRs are:

Here's a perf run with these PRs applied: https://perf.rust-lang.org/compare.html?start=f1dee7b53e8053afc315b500a514d7c013745acd&end=4a5841a15e0c47e1c5f0c6a67145599db7499a7a&stat=wall-time

Some of these PRs need a reviewer ;)

There one failing tests though (ui/traits/cycle-cache-err-60010.rs), which should be investigated. It recently broke, so https://github.com/rust-lang/rust/pull/61754 is probably a good suspect.

nikomatsakis (Jun 21 2019 at 00:12, on Zulip):

@Zoxc awesome! I am talking to @Aaron Turon about taking this up!

nikomatsakis (Jun 21 2019 at 00:12, on Zulip):

What is that perf run comparing?

Zoxc (Jun 21 2019 at 00:14, on Zulip):

[rust] parallel-compiler on / off, both the with PRs applied

Aaron Turon (Jun 25 2019 at 18:32, on Zulip):

hey @Zoxc! I'm returning from work leave and will be focused 100% on the compiler. My first orders are to get up to speed on the parallelization work you've been doing, which will include reviewing these PRs and working together on a plan for roll-out, blog announcements, etc. I'll also be writing up docs on how it works in the rustc guide. Looking forward to working with you to help get this out to the world!

nikomatsakis (Jun 25 2019 at 18:35, on Zulip):

Also, @lwshang, I was telling @Aaron Turon that you were pretty keen to help out and that I've been leaving you hanging

nikomatsakis (Jun 25 2019 at 18:35, on Zulip):

(For which I apologize :)

Zoxc (Jul 12 2019 at 16:22, on Zulip):

@Aaron Turon Feel free to ask me questions about stuff if that will help

Aaron Turon (Jul 15 2019 at 17:52, on Zulip):

thanks @Zoxc, will do! i just got back from conference travel etc, so digging back into this stuff this week. my immediate priority is going through the PR history to get a high level view (and collect things to audit for atomicity etc), once i've done that i'll dig into the pending PRs. thanks for your patience; i know this has been a long haul

Aaron Turon (Jul 19 2019 at 19:23, on Zulip):

hey @Zoxc, just a quick update that unfortunately i had some major family stuff happen this week and haven't been able to do much here yet, but i'm working my way to it

Zoxc (Aug 30 2019 at 15:01, on Zulip):

@nikomatsakis You're probably needed to review this PR if mw is too busy - https://github.com/rust-lang/rust/pull/62038

nikomatsakis (Aug 30 2019 at 15:02, on Zulip):

hmm, ok. you can re-assign to me. I'll try to get on that.

Last update: Nov 17 2019 at 07:40UTC