Stream: wg-async-foundations

Topic: #63376


centril (Aug 19 2019 at 17:40, on Zulip):

@nikomatsakis @Taylor Cramer Should we go ahead and land https://github.com/rust-lang/rust/pull/63376 ?

centril (Aug 19 2019 at 17:41, on Zulip):

(aside from my nit)

nikomatsakis (Aug 19 2019 at 17:41, on Zulip):

I think we should

nikomatsakis (Aug 19 2019 at 17:41, on Zulip):

I can add a check-pass variant of the test

nikomatsakis (Aug 19 2019 at 17:41, on Zulip):

Do you think you can open a PR against the root regression? I also can, I'm just in an airport right now

nikomatsakis (Aug 19 2019 at 17:42, on Zulip):

oh, I see https://github.com/paritytech/soketto/pull/1 now

centril (Aug 19 2019 at 17:42, on Zulip):

@nikomatsakis @Caio already kindly filed a PR which... that ^-- :D

nikomatsakis (Aug 19 2019 at 17:43, on Zulip):

I see it also needs rebase

centril (Aug 19 2019 at 17:43, on Zulip):

Alright so let's land this with the check-pass test added then; idk if Taylor wants to re-review the code

nikomatsakis (Aug 19 2019 at 17:43, on Zulip):

let's see if Ican get this done before boarding starts :)

centril (Aug 19 2019 at 17:43, on Zulip):

No rush :P

nikomatsakis (Aug 19 2019 at 17:44, on Zulip):

it's easier than working on the slides for this event I'm supposed to speak at :P

centril (Aug 19 2019 at 17:46, on Zulip):

Yes indeed :slight_smile:

centril (Aug 19 2019 at 17:58, on Zulip):

Thanks for the quick update; I'll look at the PR in a bit and r=cramertj-it if bors agrees

Taylor Cramer (Aug 19 2019 at 19:21, on Zulip):

landing it is fine by me

Taylor Cramer (Aug 19 2019 at 19:22, on Zulip):

r=me stands :)

Taylor Cramer (Aug 19 2019 at 19:22, on Zulip):

(sorry for the delayed response-- I need to figure out how to get reasonably-paced notifications from zulip)

centril (Aug 19 2019 at 19:23, on Zulip):

np, timely enough =P

I'll go ahead and rebase the stabilization PR after this one lands

nikomatsakis (Aug 19 2019 at 19:37, on Zulip):

marked as r=cramertj (I'm in the air now =)

Last update: Nov 18 2019 at 01:50UTC