Stream: wg-async-foundations

Topic: weekly meeting 2019.06.25


nikomatsakis (Jun 25 2019 at 17:03, on Zulip):

Hey @WG-async-foundations -- should we meet?

Also cc @Nathan Corbyn, who I was saw was working on #61076 -- do you want me to add you to the user group alias above so you receive pings like this one?

nikomatsakis (Jun 25 2019 at 17:03, on Zulip):

(I guess I should've checked if somebody else has already done so)

Nathan Corbyn (Jun 25 2019 at 17:04, on Zulip):

Yeah that would be great!

Taylor Cramer (Jun 25 2019 at 17:05, on Zulip):

o/

nikomatsakis (Jun 25 2019 at 17:05, on Zulip):

Quick status updates? Else I'll start going through the triage links

nikomatsakis (Jun 25 2019 at 17:05, on Zulip):

For my part I've been addressing comments and things on https://github.com/rust-lang/rust/pull/61775

davidtwco (Jun 25 2019 at 17:06, on Zulip):

I submitted #62090 which addresses #55872 after some help from @nikomatsakis.

nikomatsakis (Jun 25 2019 at 17:06, on Zulip):

I added various tests and I also created a rustc-guide chapter that describes how region inference works

nikomatsakis (Jun 25 2019 at 17:06, on Zulip):

including the new additions

nikomatsakis (Jun 25 2019 at 17:07, on Zulip):

I'm curious @centril and @Taylor Cramer whether "test case creation" has made much headway

centril (Jun 25 2019 at 17:08, on Zulip):

A bit; @Taylor Cramer has https://github.com/rust-lang/rust/pull/62106 up, which should be good to go aside from nits

davidtwco (Jun 25 2019 at 17:08, on Zulip):

I added various tests and I also created a rustc-guide chapter that describes how region inference works

Is there a way to read this rendered?

nikomatsakis (Jun 25 2019 at 17:08, on Zulip):

(not that I know of, @davidtwco, which is annoying)

nikomatsakis (Jun 25 2019 at 17:10, on Zulip):

the only "uncategorized issue" that I see is

async fn + rustfmt don't "just work" inside of RLS #61072

which is.. maybe.. just not a bug at this point? Seems like it can just be closed, right @Igor Matuszewski?

nikomatsakis (Jun 25 2019 at 17:10, on Zulip):

I'm closing anyway since that's how it appears to me

centril (Jun 25 2019 at 17:10, on Zulip):

@nikomatsakis also, you have some tests in your PR :slight_smile:

centril (Jun 25 2019 at 17:10, on Zulip):

so that's nice

nikomatsakis (Jun 25 2019 at 17:11, on Zulip):

Checking in on our overall plans, the list of blocking issues remains stubbornly long.

nikomatsakis (Jun 25 2019 at 17:11, on Zulip):

Though some of those are fixed by some of the pending PRs, which need reviews -- not sure what percentage.

Nathan Corbyn (Jun 25 2019 at 17:13, on Zulip):

I'm working on the two related to ICEs in non-async bodies (#62009 and #61685)

Nathan Corbyn (Jun 25 2019 at 17:13, on Zulip):

I don't have a PR yet, as the fix I thought I had turns out to introduce a few other issues, but I should have one in the next couple of days if all goes to plan

nikomatsakis (Jun 25 2019 at 17:13, on Zulip):

Oh, you are @doctorn :)

nikomatsakis (Jun 25 2019 at 17:13, on Zulip):

I just noticed that

nikomatsakis (Jun 25 2019 at 17:14, on Zulip):

can you maybe claim #61685?

nikomatsakis (Jun 25 2019 at 17:14, on Zulip):

great!

nikomatsakis (Jun 25 2019 at 17:16, on Zulip):

Sorry, i've been skimming issues to try and get up to date

centril (Jun 25 2019 at 17:16, on Zulip):

@Nathan Corbyn A general note re. the PR -- feel free to include many test cases which may duplicate some stuff. A bit of redundancy is good here. Tho it is good to have one canonical test case for documentation purposes

Nathan Corbyn (Jun 25 2019 at 17:17, on Zulip):

Ok I'll try to get a few in

nikomatsakis (Jun 25 2019 at 17:17, on Zulip):

Should probably leave a stream but it seems like @Matthew Jasper's PR https://github.com/rust-lang/rust/pull/61872 affects a lot

nikomatsakis (Jun 25 2019 at 17:17, on Zulip):

I just went and assigned things to them

nikomatsakis (Jun 25 2019 at 17:17, on Zulip):

that their PR claims to close :)

nikomatsakis (Jun 25 2019 at 17:18, on Zulip):

similarly @Aaron Hill's PR

nikomatsakis (Jun 25 2019 at 17:18, on Zulip):

which means that basically everythign is assigned but for that mismatched diag

nikomatsakis (Jun 25 2019 at 17:18, on Zulip):

that's great

nikomatsakis (Jun 25 2019 at 17:19, on Zulip):

which I think @davidtwco you wanted to claim? (#60424?)

nikomatsakis (Jun 25 2019 at 17:19, on Zulip):

is there tracking state of tests, @centril?

davidtwco (Jun 25 2019 at 17:19, on Zulip):

which I think davidtwco you wanted to claim? (#60424?)

If it is the same fix as #54326 then yeah.

centril (Jun 25 2019 at 17:20, on Zulip):

@nikomatsakis there's https://paper.dropbox.com/doc/async.await-Call-for-Tests--AfAM6cvO2yAxLYrwSNNpS0zTAg-nMyZGrra7dz9KcFRMLKJy

centril (Jun 25 2019 at 17:20, on Zulip):

but nothing beyond that in terms of tracking

nikomatsakis (Jun 25 2019 at 17:21, on Zulip):

If it is the same fix as #54326 then yeah.

ah, different number. I suspect they are indeed the same.

nikomatsakis (Jun 25 2019 at 17:21, on Zulip):

nikomatsakis there's https://paper.dropbox.com/doc/async.await-Call-for-Tests--AfAM6cvO2yAxLYrwSNNpS0zTAg-nMyZGrra7dz9KcFRMLKJy

ok let's open an issue just to have something

nikomatsakis (Jun 25 2019 at 17:22, on Zulip):

Regarding the overall schedule, i'm not sure if we'll make 1.37 or not, but it seems like we're doing pretty well. I guess I should compare the tests in my branch against the master test list.

nikomatsakis (Jun 25 2019 at 17:22, on Zulip):

The branch date for 1.37 may be moved a bit earlier than normal

nikomatsakis (Jun 25 2019 at 17:23, on Zulip):

for "operations" reasons

nikomatsakis (Jun 25 2019 at 17:23, on Zulip):

but I'm not 100% sure about that

centril (Jun 25 2019 at 17:23, on Zulip):

The branch date for 1.37 may be moved a bit earlier than normal

That's for 1.36 beta => stable promotion

nikomatsakis (Jun 25 2019 at 17:23, on Zulip):

( @Alex Crichton might know more )

nikomatsakis (Jun 25 2019 at 17:23, on Zulip):

Yeah, ok, that makes sense

nikomatsakis (Jun 25 2019 at 17:23, on Zulip):

So never mind, probably won't affect this.

centril (Jun 25 2019 at 17:24, on Zulip):

1.37 master branches normally on July 2th 2019 (in 7 days)

nikomatsakis (Jun 25 2019 at 17:24, on Zulip):

1.38 looks more likely to me then.

nikomatsakis (Jun 25 2019 at 17:25, on Zulip):

I was writing a blog post to generally update people on what's been going on

nikomatsakis (Jun 25 2019 at 17:25, on Zulip):

I'll try to clean that up and post a draft here in a bit to see what people think

centril (Jun 25 2019 at 17:25, on Zulip):

@nikomatsakis I can make an issue if you want later tonight

centril (Jun 25 2019 at 17:25, on Zulip):

for the tests

nikomatsakis (Jun 25 2019 at 17:25, on Zulip):

I can do it right now

nikomatsakis (Jun 25 2019 at 17:25, on Zulip):

You can edit the text :)

centril (Jun 25 2019 at 17:26, on Zulip):

I'll do that

nikomatsakis (Jun 25 2019 at 17:27, on Zulip):

https://github.com/rust-lang/rust/issues/62121

nikomatsakis (Jun 25 2019 at 17:27, on Zulip):

OK, almost out of time, any last updates? Anybody looking for a job?

lqd (Jun 25 2019 at 17:39, on Zulip):

Is there a way to read this rendered?

@davidtwco somewhat sub-par but you can still read them rendered file by file (there's a "view file" entry in the "..." menu on each file of the PR when looking in the GH PR's files tab), e.g. this member_constraints.md file

Igor Matuszewski (Jun 25 2019 at 17:40, on Zulip):

@nikomatsakis yeah, I think we can close the async fn RLS issue.

Taylor Cramer (Jun 25 2019 at 17:42, on Zulip):

@nikomatsakis what's the status of your review of https://github.com/rust-lang/rust/pull/61872 ?

Taylor Cramer (Jun 25 2019 at 17:42, on Zulip):

i see @Matthew Jasper responded to the comments

nikomatsakis (Jun 25 2019 at 17:51, on Zulip):

@Taylor Cramer status was that I planned to go read those responses right now :)

Taylor Cramer (Jun 25 2019 at 17:51, on Zulip):

@nikomatsakis wonderful :)

nikomatsakis (Jun 25 2019 at 17:53, on Zulip):

Now I have to go review @Aaron Hill's PR...

nikomatsakis (Jun 25 2019 at 17:53, on Zulip):

although I think I saw @varkor was on that

lqd (Jun 25 2019 at 17:57, on Zulip):

if it's #61572 it's been merged

nikomatsakis (Jun 25 2019 at 17:59, on Zulip):

yep that's the one

Last update: Nov 18 2019 at 01:00UTC