Stream: wg-async-foundations

Topic: tls interface


Steven Fackler (Nov 11 2019 at 17:25, on Zulip):

The temporary TLS interface for smuggling the context around generated futures causes stack traces to get a bit "polluted" with a bunch of extra frames. It'd be nice to change that over to an unsafe API that returns the RAII guards directly rather than using closures. Does that seem plausible? Dunno if removing the TLS requirement entirely is close enough that this wouldn't be worth it

csmoe (Nov 11 2019 at 17:29, on Zulip):

(@Steven Fackler sorry for a stupid question, what is tls here? is it the crypto tls?)

Steven Fackler (Nov 11 2019 at 17:29, on Zulip):

thread local storage - the unstable APIs down here: https://doc.rust-lang.org/src/std/future.rs.html#50-122

nikomatsakis (Nov 11 2019 at 23:40, on Zulip):

@Steven Fackler we were hoping to remove the RLS hack altogether

nikomatsakis (Nov 11 2019 at 23:40, on Zulip):

ah, I see you anticipated that

nikomatsakis (Nov 11 2019 at 23:41, on Zulip):

I'm not sure how close it is tbh, seems like it could be fairly easy

Steven Fackler (Nov 12 2019 at 00:21, on Zulip):

maybe I'll just throw together a PR making the change and see how people feel

nikomatsakis (Nov 12 2019 at 15:09, on Zulip):

I think if it's easy to land such a PR, seems ok to do as a stopgap

Steven Fackler (Nov 14 2019 at 01:23, on Zulip):

https://github.com/rust-lang/rust/pull/66398

Last update: Dec 12 2019 at 00:45UTC