Stream: wg-async-foundations

Topic: sync up


nikomatsakis (Aug 12 2019 at 16:09, on Zulip):

Hey @Taylor Cramer -- let me know when you're around

Taylor Cramer (Aug 12 2019 at 19:26, on Zulip):

o/

nikomatsakis (Aug 12 2019 at 19:28, on Zulip):

@Taylor Cramer ohai =)

nikomatsakis (Aug 12 2019 at 19:28, on Zulip):

so I've been trying to close the various issues, as you've probably noticed.

nikomatsakis (Aug 12 2019 at 19:28, on Zulip):

The lifetime elision one (https://github.com/rust-lang/rust/issues/63388) has me the most worried, though

nikomatsakis (Aug 12 2019 at 19:29, on Zulip):

the current behavior is definitely incorrect

Taylor Cramer (Aug 12 2019 at 19:32, on Zulip):

indeed

Taylor Cramer (Aug 12 2019 at 19:33, on Zulip):

what you described is what the code does (looking for exactly one unnamed lifetime parameter, and using that as the elided lifetime)

nikomatsakis (Aug 12 2019 at 19:34, on Zulip):

yes

nikomatsakis (Aug 12 2019 at 19:34, on Zulip):

I'm not sure how to fix that

nikomatsakis (Aug 12 2019 at 19:34, on Zulip):

I mean obviously we need to change the approach

nikomatsakis (Aug 12 2019 at 19:35, on Zulip):

well I'd say @centril's desire for lots of tests is clearly validated :)

nikomatsakis (Aug 12 2019 at 19:36, on Zulip):

where is the other lifetime elision code to be found...

nikomatsakis (Aug 12 2019 at 19:37, on Zulip):

answer: middle/resolve_lifetime.rs, around line 2100

nikomatsakis (Aug 12 2019 at 19:38, on Zulip):

it seems...not entirely implausible that code could be factored out

nikomatsakis (Aug 12 2019 at 19:38, on Zulip):

well, maybe kinda implausible, as it uses a visitor I think

nikomatsakis (Aug 12 2019 at 19:39, on Zulip):

I am not happy to be down to the wire like this :(

nikomatsakis (Aug 12 2019 at 19:39, on Zulip):

ah well I guess a HIR visitor doesn't require a tcx

Last update: Nov 18 2019 at 01:50UTC