Stream: wg-async-foundations

Topic: syntax PR


nikomatsakis (Apr 30 2019 at 17:30, on Zulip):

One thing we could discuss, @Taylor Cramer, is the syntax PR. As you know, I'm in favor of landing it (with any syntax, your choice as implementor), under the explicit proviso that the final syntax is not stable (we can cite the internals thread). But maybe we should just wait at this point and discuss it in the lang team meeting. (I moved this to its own topic)

Taylor Cramer (Apr 30 2019 at 17:31, on Zulip):

Yup, I'd prefer to get lang-team sign-off before doing this

Taylor Cramer (May 07 2019 at 18:59, on Zulip):

{} here instead of ()

Taylor Cramer (May 07 2019 at 19:00, on Zulip):

@centril @eddyb @oli did you literally mean to have an empty block expr?

Taylor Cramer (May 07 2019 at 19:00, on Zulip):

(checking to make sure I understood the ask)

Taylor Cramer (May 07 2019 at 19:01, on Zulip):

where the actual block has no expression

centril (May 07 2019 at 19:11, on Zulip):

@Taylor Cramer yea, take a look at https://github.com/rust-lang/rust/pull/59288/files#diff-64b696b0ef6ad44140e973801ed82b25

centril (May 07 2019 at 19:12, on Zulip):

you can just copy my fn expr_block_empty(&mut self, span: Span) -> hir::Expr { from there into your PR and the PR that merges second will rebase :P

centril (May 07 2019 at 19:13, on Zulip):

@nikomatsakis I was hoping to land the PR before the meeting to speed up the tests n stuff

centril (May 07 2019 at 19:13, on Zulip):

but I suppose thursday isn't that far off

centril (May 07 2019 at 19:14, on Zulip):

oh wait; this is from 30th april -- never mind, we already signed off :D

Last update: Nov 18 2019 at 01:30UTC