Stream: wg-async-foundations

Topic: feature gating issue


Taylor Cramer (Apr 18 2019 at 18:24, on Zulip):

@varkor did I see that you were working on a fix to the feature gating bug?

varkor (Apr 18 2019 at 18:25, on Zulip):

https://github.com/rust-lang/rust/pull/60088

centril (Apr 18 2019 at 18:27, on Zulip):

taking a look

centril (Apr 18 2019 at 18:32, on Zulip):

@varkor looks good to me, you can r? me if you like

centril (Apr 18 2019 at 18:32, on Zulip):

or Taylor can do it... :P

varkor (Apr 18 2019 at 18:33, on Zulip):

@centril: feel free to review it

varkor (Apr 18 2019 at 18:33, on Zulip):

it's a straightforward change, so I don't think there are any subtleties

centril (Apr 18 2019 at 18:33, on Zulip):

@varkor already reviewed ;)

varkor (Apr 18 2019 at 18:33, on Zulip):

haha, bors did not like that

centril (Apr 18 2019 at 18:34, on Zulip):

@Taylor Cramer btw, if you do r+ you don't need to also r=@cramertj

centril (Apr 18 2019 at 18:34, on Zulip):

just write: r? @cramertj @bors r+

centril (Apr 18 2019 at 18:34, on Zulip):

@varkor did you test this locally?

varkor (Apr 18 2019 at 18:35, on Zulip):

yes; it passes all UI tests locally

centril (Apr 18 2019 at 18:35, on Zulip):

OK; rolling up then

Taylor Cramer (Apr 18 2019 at 18:40, on Zulip):

@centril yeah, I typo'd and wrote r= instead of r?

Last update: Nov 18 2019 at 02:05UTC