Stream: t-compiler/wg-polonius

Topic: meeting 2019.12.03


lqd (Dec 03 2019 at 20:02, on Zulip):

oops, hello :)

lqd (Dec 03 2019 at 20:03, on Zulip):

hi @WG-polonius :)

lqd (Dec 03 2019 at 20:05, on Zulip):

this week has been short on time so I wasn't able to do much but

Albin Stjerna (Dec 03 2019 at 20:05, on Zulip):

Me neither :(

lqd (Dec 03 2019 at 20:06, on Zulip):

(and also I'm not sure Niko's fully back from vacation)

Albin Stjerna (Dec 03 2019 at 20:06, on Zulip):

Honestly, I've done literally nothing on Polonius since last week

lqd (Dec 03 2019 at 20:06, on Zulip):

it's ok :)

lqd (Dec 03 2019 at 20:06, on Zulip):

you have a lot on your plate elsewhere already

lqd (Dec 03 2019 at 20:07, on Zulip):

1) we've managed to at least merge the version bumps so that we can use placeholder loans in rustc

lqd (Dec 03 2019 at 20:07, on Zulip):

unfortunately, I think only niko can release so it's not yet completely usable

lqd (Dec 03 2019 at 20:07, on Zulip):

2) I've been using the git rev to rebase my https://github.com/lqd/rust/commits/placeholder_loans branch, so as soon as we have a release, it should be quick to make a PR

lqd (Dec 03 2019 at 20:08, on Zulip):

I wasn't sure about the testing part, as most of it is done in the compare-mode

lqd (Dec 03 2019 at 20:08, on Zulip):

but I've added some simple smoke tests in the regular ui suite just in case

lqd (Dec 03 2019 at 20:09, on Zulip):

I don't know if @Matthew Jasper has ideas about that, or if it'd be enough

nikomatsakis (Dec 03 2019 at 20:09, on Zulip):

Argh wsorry

nikomatsakis (Dec 03 2019 at 20:09, on Zulip):

So I'm here now :)

nikomatsakis (Dec 03 2019 at 20:09, on Zulip):

Please direct me at what I can do be of max use

lqd (Dec 03 2019 at 20:09, on Zulip):

I think it's enough but hey I dunno :p

nikomatsakis (Dec 03 2019 at 20:09, on Zulip):

I'm pretty confused about current state :)

nikomatsakis (Dec 03 2019 at 20:09, on Zulip):

Still getting brain back in gear from vacation

lqd (Dec 03 2019 at 20:09, on Zulip):

hello @nikomatsakis welcome back from ICE-land :)

nikomatsakis (Dec 03 2019 at 20:10, on Zulip):

lol

lqd (Dec 03 2019 at 20:10, on Zulip):

current state for you: could you publish a new polonius release ?

lqd (Dec 03 2019 at 20:10, on Zulip):

we've done the versions bump et al (correctly, we think)

nikomatsakis (Dec 03 2019 at 20:10, on Zulip):

I could -- do you not have the privs to do it?

nikomatsakis (Dec 03 2019 at 20:10, on Zulip):

should I merge any PRs first?

lqd (Dec 03 2019 at 20:10, on Zulip):

but couldn't publish as none of us are owners on crates.io IIUC

nikomatsakis (Dec 03 2019 at 20:11, on Zulip):

oh dear, we should fix that

lqd (Dec 03 2019 at 20:11, on Zulip):

should I merge any PRs first?

I don't think so no

nikomatsakis (Dec 03 2019 at 20:11, on Zulip):

my desktop is still dead, so I actually have to set that stuff up on my WSL instance I guess

lqd (Dec 03 2019 at 20:11, on Zulip):

it's not urgent or anything

lqd (Dec 03 2019 at 20:11, on Zulip):

as soon as we have that I can rebase my branch and open the subset errors PR on the rustc side

Matthew Jasper (Dec 03 2019 at 20:12, on Zulip):

Please direct me at what I can do be of max use

#65232 :wink:

lqd (Dec 03 2019 at 20:12, on Zulip):

haha

Matthew Jasper (Dec 03 2019 at 20:13, on Zulip):

but I've added some simple smoke tests in the regular ui suite just in case

That sounds fine. I think the main thing that needs to be tested is that the integration works at all (which was the motivation behind the original test that I added).

lqd (Dec 03 2019 at 20:14, on Zulip):

as soon as the release is done, I'll open the PR and r? you Niko ? (since you've already read the branch) or would you rather someone else take it to have more time do the important things such as the universe PR :p

lqd (Dec 03 2019 at 20:15, on Zulip):

That sounds fine. I think the main thing that needs to be tested is that the integration works at all (which was the motivation behind the original test that I added).

yeah I think we're good on that side, I had added some more of those last time when we were fixing the killed fact gen bugs for example

lqd (Dec 03 2019 at 20:16, on Zulip):

and 3) I spent some time looking at https://github.com/nikomatsakis/borrowck/tree/master/test to have more ideas to help with Albin's testing

lqd (Dec 03 2019 at 20:16, on Zulip):

I wasn't able to get to anything concrete yet tho

Albin Stjerna (Dec 03 2019 at 20:17, on Zulip):

Did you get to anything non-concrete?

lqd (Dec 03 2019 at 20:17, on Zulip):

yeah, like wishing for more time to work on this for example :p

lqd (Dec 03 2019 at 20:18, on Zulip):

4) ah I did take a quick look at Niko's chalk+polonius branch

lqd (Dec 03 2019 at 20:18, on Zulip):

and that's about all from me

Albin Stjerna (Dec 03 2019 at 20:18, on Zulip):

chalonius

Albin Stjerna (Dec 03 2019 at 20:18, on Zulip):

polk?

Albin Stjerna (Dec 03 2019 at 20:19, on Zulip):

Ok I'll show myself out

lqd (Dec 03 2019 at 20:19, on Zulip):

chalkonius sounds acceptable

nikomatsakis (Dec 03 2019 at 20:19, on Zulip):

/me got distracted

nikomatsakis (Dec 03 2019 at 20:19, on Zulip):

/me reads backscroll

Albin Stjerna (Dec 03 2019 at 20:19, on Zulip):

Jokes aside, I didn't know there was one!

nikomatsakis (Dec 03 2019 at 20:19, on Zulip):

@lqd for the release, all the version updates are already done?

lqd (Dec 03 2019 at 20:19, on Zulip):

yep

lqd (Dec 03 2019 at 20:20, on Zulip):

maybe take a ganderjust in case

lqd (Dec 03 2019 at 20:20, on Zulip):

there was some weirdness in releases.md

lqd (Dec 03 2019 at 20:20, on Zulip):

there were version numbers but no cargo.toml version bumps associated to those numbers

nikomatsakis (Dec 03 2019 at 20:21, on Zulip):

hmm well

nikomatsakis (Dec 03 2019 at 20:21, on Zulip):

so crates.io has a 0.10.0

nikomatsakis (Dec 03 2019 at 20:21, on Zulip):

ok ok I see that master is 0.11.0

nikomatsakis (Dec 03 2019 at 20:21, on Zulip):

publishing now

lqd (Dec 03 2019 at 20:21, on Zulip):

@Albin Stjerna https://github.com/nikomatsakis/chalk-ndm/tree/outlives that's "vacation" for you :)

nikomatsakis (Dec 03 2019 at 20:22, on Zulip):

also, wg-polonius is an owner of the crate

nikomatsakis (Dec 03 2019 at 20:22, on Zulip):

and I think both of you belong to that

lqd (Dec 03 2019 at 20:22, on Zulip):

I did try to publish and crates.io didn't let me cause I wasn't an owner

lqd (Dec 03 2019 at 20:23, on Zulip):

this week I'd like to be able to open the subset errors PR (that should be likely to happen) at the very least

lqd (Dec 03 2019 at 20:23, on Zulip):

Niko you mentioned wanting us to have some kind of "sprint report" for Inside Rust ?

lqd (Dec 03 2019 at 20:24, on Zulip):

(https://crates.io/crates/polonius-engine/owners lists only Niko, and no wg-polonius)

nikomatsakis (Dec 03 2019 at 20:24, on Zulip):

@lqd published

lqd (Dec 03 2019 at 20:24, on Zulip):

yay, thanks a lot :)

Albin Stjerna (Dec 03 2019 at 20:24, on Zulip):

Yay!

Albin Stjerna (Dec 03 2019 at 20:25, on Zulip):

Once @lqd's branch lands, I'll rebase on that and try to wrap up my PR, which includes some testing

lqd (Dec 03 2019 at 20:25, on Zulip):

@nikomatsakis do you a have a preference for https://rust-lang.zulipchat.com/#narrow/stream/186049-t-compiler.2Fwg-polonius/topic/meeting.202019.2E12.2E03/near/182490449 ? I'm sure Matthew can review it when I open it (if they have time ofc, it's not urgent at all)

nikomatsakis (Dec 03 2019 at 20:27, on Zulip):

mmm I don't mind r? but I am sort of behind --

lqd (Dec 03 2019 at 20:27, on Zulip):

@Albin Stjerna remind me, besides some of the testing we mentioned (and which should mostly be tackled by rustc's tests), and some reviewing, this PR is 99% ready right ?

nikomatsakis (Dec 03 2019 at 20:27, on Zulip):

I'd be happy for @Matthew Jasper to review

lqd (Dec 03 2019 at 20:28, on Zulip):

(it's pretty small, and mostly follows the implementation steps in the hackmd)

Matthew Jasper (Dec 03 2019 at 20:28, on Zulip):

What the size of the diff?

lqd (Dec 03 2019 at 20:29, on Zulip):

around +600/-30 including blessed tests and long comments

Matthew Jasper (Dec 03 2019 at 20:30, on Zulip):

Doesn't sound that bad then.

lqd (Dec 03 2019 at 20:30, on Zulip):

https://github.com/rust-lang/rust/compare/master...lqd:placeholder_loans?expand=1 for a quick look

lqd (Dec 03 2019 at 20:30, on Zulip):

yeah

lqd (Dec 03 2019 at 20:30, on Zulip):

again not at all urgent if you have better things to do, which I assume you do :)

lqd (Dec 03 2019 at 20:30, on Zulip):

(and I'll open it tomorrow)

Albin Stjerna (Dec 03 2019 at 20:31, on Zulip):

Albin Stjerna remind me, besides some of the testing we mentioned (and which should mostly be tackled by rustc's tests), and some reviewing, this PR is 99% ready right ?

Yes I think so!

lqd (Dec 03 2019 at 20:31, on Zulip):

great!

lqd (Dec 03 2019 at 20:32, on Zulip):

alright, seems like we're about done

lqd (Dec 03 2019 at 20:33, on Zulip):

thanks a lot everyone :) :wave:

nikomatsakis (Dec 03 2019 at 20:34, on Zulip):

we should figure out @lqd why you can't publish

lqd (Dec 03 2019 at 20:35, on Zulip):

I'm not versed at all in crates.io publishing, like does it have a notion of "wg-polonius" and all. the website only lists you as the owner :thinking:

lqd (Dec 03 2019 at 20:36, on Zulip):

I do wonder if that could also happen with chalk, datafrog, or similar crates worked on by other working groups

nikomatsakis (Dec 03 2019 at 21:56, on Zulip):

wait

nikomatsakis (Dec 03 2019 at 21:56, on Zulip):

@lqd so the polonius crate

nikomatsakis (Dec 03 2019 at 21:56, on Zulip):

well actually both polonius and polonius-engine have https://crates.io/teams/github:rust-lang:wg-polonius listed as an owner

lqd (Dec 03 2019 at 21:57, on Zulip):

wow, and https://crates.io/crates/polonius-engine/owners doesn't

nikomatsakis (Dec 03 2019 at 21:58, on Zulip):

https://github.com/orgs/rust-lang/teams/wg-polonius

nikomatsakis (Dec 03 2019 at 21:58, on Zulip):

you are a member there

nikomatsakis (Dec 03 2019 at 21:58, on Zulip):

weird

lqd (Dec 03 2019 at 21:58, on Zulip):

yeah

lqd (Dec 03 2019 at 21:59, on Zulip):

I did the login and setup, the dry-run publishing, it tested and compiled and all

lqd (Dec 03 2019 at 21:59, on Zulip):

and then failed with saying I wasn't an owner

lqd (Dec 03 2019 at 22:00, on Zulip):

oh wow

lqd (Dec 03 2019 at 22:00, on Zulip):

https://crates.io/crates/polonius-engine now lists 4 owners in the lower right

lqd (Dec 03 2019 at 22:01, on Zulip):

3 for https://crates.io/crates/polonius

lqd (Dec 03 2019 at 22:01, on Zulip):

and only you for https://crates.io/crates/polonius-parser/

lqd (Dec 03 2019 at 22:04, on Zulip):

maybe some kind of desynchronisation with github; I'll try it next time (eg for Albin's move errors) to check if the now-listed wg-polonius owner can indeed publish :)

lqd (Dec 03 2019 at 22:05, on Zulip):

thanks if you did something ! (and also for publishing)

lqd (Dec 04 2019 at 11:47, on Zulip):

PR is posted https://github.com/rust-lang/rust/pull/67016

lqd (Dec 05 2019 at 10:51, on Zulip):

though I have a feeling https://github.com/rust-lang/rust/pull/66815 is going to conflict with it

lqd (Dec 07 2019 at 19:24, on Zulip):

thanks for the review @Matthew Jasper

Last update: Jan 28 2020 at 02:05UTC