Stream: t-compiler/wg-polonius

Topic: illegal subset relations polonius#99

lqd (Mar 20 2019 at 11:00, on Zulip):

@nikomatsakis thanks for the initial review on polonius#99, as mentioned in the PR I opened it for discussion around how we expect errors to work (since these are a different kind of error than before, and it's the first such new kind) in polonius itself and in communicating them with rustc; if this was an acceptable way to do so for this new kind; how would we expect to organize tests for the different kinds of errors (we talked about reorganizing them before, providing higher levels assertions to check for facts, reducing duplication, and more).

lqd (Mar 20 2019 at 11:02, on Zulip):

I'm also unsure about the plan for these errors, especially that they can be "duplicated" per cfg point where the regions in error are live (I forget the details, handwaving here)

lqd (Mar 20 2019 at 11:06, on Zulip):

but if the PR is good enough (modulo the "Relation" comment ofc which I'll fix ASAP) I can also just add tests as we've been writing them (might also be interesting to accept the lack of a relation facts file as an empty relation + a warning or something: a tiny bit more backwards compatibility with old facts generated by rustc)

lqd (Mar 20 2019 at 11:08, on Zulip):

and also I forgot: discussion about this kind of errors in 1) datafrogopt, and whether they matter in 2) the location insensitive analysis, 3) ofc the hybrid analysis

lqd (Mar 20 2019 at 11:09, on Zulip):

(and ofc then I'll need to make rustc emit these facts)

nikomatsakis (Apr 23 2019 at 19:27, on Zulip):

hmm I think I missed these comments

nikomatsakis (May 07 2019 at 19:19, on Zulip):

OK, so, my thoughts here:

nikomatsakis (May 07 2019 at 19:19, on Zulip):

1. I think it's fine to just have multiple output relations, one per sort of error

nikomatsakis (May 07 2019 at 19:20, on Zulip):

2. We may however want to be careful about the duplicates. I wonder if polonius would be a good place to "suppress" them

nikomatsakis (May 07 2019 at 19:20, on Zulip):

I'm just imagining it'll be tedious to test with a ton of duplicates

nikomatsakis (May 07 2019 at 19:20, on Zulip):

datafrog doesn't currently have any kind of "aggregate" operator I guess (e.g., to take the "minimum" or something)

Last update: Jun 20 2021 at 01:30UTC