I'm not sure if anyone else is there :) :wave:
I myself have very little to update: still with the laptop troubles, but was able to read over Vytautas' awesome contribution
I've been too swamped with spinning up and down my courses to do much of anything though, including my own reasearch
@Albin Stjerna good evening, how's it going ?
@lqd Good evening! Well, I think it's going to be all right soon
But I don't have anything to report :(
remind me, in what order did you want to do your move errors work to continue ?
was a review needed in polonius before the one in rustc or something like that ?
Hmm, I'm not sure anymore
But I'm working on rebasing my changes to rustc
/me neither :)
So I guess I'm doing that...first?
I assume this PR would refer to one of your polonius branches, right ?
Anyway, disregarding ordering, we need some changes to the fact generation code, and also some code to test the new changes to Polonius, including fixing some now broken old tests
(I guess it's the open both PRs in lockstep dance we have to do)
Since I renamed virtually all facts, or at least it feels that way
Ok, no wait, now I remember; I think it's a better idea to do the Polonius changes first, because rustc needs a new Polonius release
ah yes, that must be also a reason rebasing is going to be a pain
In order to have the correct fact names etc
And to do the release we should have tests
do you happen to remember whether the rustc PR passed rustc's tests ?
(the polonius compare-mode tests)
It never has when I run it locally
But if I recall correctly the errors looked spurious
(they always do)
ah from the OOMs ?
I don't think so
It's just...some completely unrelated code crashing
I don't remember, it's been months
ok that's weird :)
Yes, but it's been that way since the first time I ran them
Once I get my changes to compile at all I'll look into it more closely
I don't know what kind of time I'll have but I'll try to look at the PR, to see if maybe I can help with the rebase or just check if the tests do pass locally
@Albin Stjerna thanks for the info, talk to you soon :) good evening :wave:
It's not really complicated, it's just...a lot of details
Follow-up: rebase complete, my laptop is currently cooking my lap recompiling Rust on the train. I'll report how compiletest's working whenever it finishes! WIP PR for fact extension & rehaul: rust#68993
rustfmt on it would make it test on CI -- not completely of course, as you're more interested in the polonius compare-mode results, but there are some smoke tests ran by default
It shouldn’t compile; it needs a new Polonius