Stream: t-compiler/wg-polonius

Topic: meeting 2020.02.04


lqd (Feb 04 2020 at 20:04, on Zulip):

I'm not sure if anyone else is there :) :wave:

Albin Stjerna (Feb 04 2020 at 20:05, on Zulip):

I am!

lqd (Feb 04 2020 at 20:05, on Zulip):

I myself have very little to update: still with the laptop troubles, but was able to read over Vytautas' awesome contribution

Albin Stjerna (Feb 04 2020 at 20:05, on Zulip):

I've been too swamped with spinning up and down my courses to do much of anything though, including my own reasearch

lqd (Feb 04 2020 at 20:05, on Zulip):

@Albin Stjerna good evening, how's it going ?

lqd (Feb 04 2020 at 20:06, on Zulip):

ah yes

Albin Stjerna (Feb 04 2020 at 20:06, on Zulip):

@lqd Good evening! Well, I think it's going to be all right soon

Albin Stjerna (Feb 04 2020 at 20:07, on Zulip):

But I don't have anything to report :(

lqd (Feb 04 2020 at 20:07, on Zulip):

remind me, in what order did you want to do your move errors work to continue ?

lqd (Feb 04 2020 at 20:07, on Zulip):

was a review needed in polonius before the one in rustc or something like that ?

Albin Stjerna (Feb 04 2020 at 20:07, on Zulip):

Hmm, I'm not sure anymore

Albin Stjerna (Feb 04 2020 at 20:08, on Zulip):

But I'm working on rebasing my changes to rustc

lqd (Feb 04 2020 at 20:08, on Zulip):

/me neither :)

Albin Stjerna (Feb 04 2020 at 20:08, on Zulip):

So I guess I'm doing that...first?

lqd (Feb 04 2020 at 20:08, on Zulip):

I assume this PR would refer to one of your polonius branches, right ?

Albin Stjerna (Feb 04 2020 at 20:09, on Zulip):

Anyway, disregarding ordering, we need some changes to the fact generation code, and also some code to test the new changes to Polonius, including fixing some now broken old tests

lqd (Feb 04 2020 at 20:09, on Zulip):

(I guess it's the open both PRs in lockstep dance we have to do)

Albin Stjerna (Feb 04 2020 at 20:09, on Zulip):

Since I renamed virtually all facts, or at least it feels that way

Albin Stjerna (Feb 04 2020 at 20:09, on Zulip):

Ok, no wait, now I remember; I think it's a better idea to do the Polonius changes first, because rustc needs a new Polonius release

lqd (Feb 04 2020 at 20:09, on Zulip):

ah yes, that must be also a reason rebasing is going to be a pain

Albin Stjerna (Feb 04 2020 at 20:09, on Zulip):

In order to have the correct fact names etc

Albin Stjerna (Feb 04 2020 at 20:10, on Zulip):

And to do the release we should have tests

lqd (Feb 04 2020 at 20:10, on Zulip):

do you happen to remember whether the rustc PR passed rustc's tests ?

lqd (Feb 04 2020 at 20:11, on Zulip):

(the polonius compare-mode tests)

Albin Stjerna (Feb 04 2020 at 20:12, on Zulip):

It never has when I run it locally

Albin Stjerna (Feb 04 2020 at 20:13, on Zulip):

But if I recall correctly the errors looked spurious

Albin Stjerna (Feb 04 2020 at 20:13, on Zulip):

(they always do)

lqd (Feb 04 2020 at 20:13, on Zulip):

ah from the OOMs ?

Albin Stjerna (Feb 04 2020 at 20:13, on Zulip):

I don't think so

Albin Stjerna (Feb 04 2020 at 20:13, on Zulip):

It's just...some completely unrelated code crashing

Albin Stjerna (Feb 04 2020 at 20:13, on Zulip):

I don't remember, it's been months

lqd (Feb 04 2020 at 20:14, on Zulip):

ok that's weird :)

Albin Stjerna (Feb 04 2020 at 20:14, on Zulip):

Yes, but it's been that way since the first time I ran them

Albin Stjerna (Feb 04 2020 at 20:14, on Zulip):

Once I get my changes to compile at all I'll look into it more closely

lqd (Feb 04 2020 at 20:14, on Zulip):

I don't know what kind of time I'll have but I'll try to look at the PR, to see if maybe I can help with the rebase or just check if the tests do pass locally

lqd (Feb 04 2020 at 20:17, on Zulip):

@Albin Stjerna thanks for the info, talk to you soon :) good evening :wave:

Albin Stjerna (Feb 04 2020 at 20:17, on Zulip):

Good evening!

Albin Stjerna (Feb 04 2020 at 20:17, on Zulip):

It's not really complicated, it's just...a lot of details

Albin Stjerna (Feb 09 2020 at 13:30, on Zulip):

Follow-up: rebase complete, my laptop is currently cooking my lap recompiling Rust on the train. I'll report how compiletest's working whenever it finishes! WIP PR for fact extension & rehaul: rust#68993

lqd (Feb 10 2020 at 17:12, on Zulip):

btw running rustfmt on it would make it test on CI -- not completely of course, as you're more interested in the polonius compare-mode results, but there are some smoke tests ran by default

Albin Stjerna (Feb 10 2020 at 20:49, on Zulip):

It shouldn’t compile; it needs a new Polonius

Last update: Jul 02 2020 at 19:55UTC