Stream: t-compiler/wg-meta

Topic: Static web page for the compiler team pr merged


Santiago Pastorino (Jul 15 2019 at 17:44, on Zulip):

This https://github.com/rust-lang/compiler-team/pull/103 is now merged!

Santiago Pastorino (Jul 15 2019 at 18:02, on Zulip):

@davidtwco should we have now a gh-pages branch now or use the docs directory?

Santiago Pastorino (Jul 15 2019 at 18:02, on Zulip):

also, not sure if I have the rights for that

davidtwco (Jul 15 2019 at 18:03, on Zulip):

You'll need to set up some process to populate the gh-pages branch with the output, it isn't automatic for non-Jekyll sites AFAIK.

Santiago Pastorino (Jul 15 2019 at 18:04, on Zulip):

I guess that's what @Pietro Albini have said about .travis.yml

davidtwco (Jul 15 2019 at 18:04, on Zulip):

Yeah.

Santiago Pastorino (Jul 15 2019 at 18:05, on Zulip):

but unsure, where is the hugo command setup and all that?

davidtwco (Jul 15 2019 at 18:06, on Zulip):

I assume it is handled by the config you import.

Santiago Pastorino (Jul 15 2019 at 18:06, on Zulip):

yeah, you mean on the infra side?

davidtwco (Jul 15 2019 at 18:07, on Zulip):

Yeah, if they support Hugo.

Santiago Pastorino (Jul 15 2019 at 18:07, on Zulip):

I was wondering is there any other Rust project using Hugo?

Santiago Pastorino (Jul 15 2019 at 18:07, on Zulip):

exactly if they support Hugo, that's exactly what I'm wondering

Santiago Pastorino (Jul 15 2019 at 18:07, on Zulip):

/cc @Pietro Albini

Pietro Albini (Jul 15 2019 at 18:07, on Zulip):

dunno, but I think no

Pietro Albini (Jul 15 2019 at 18:08, on Zulip):

you need to add a travis config that first builds your site with hugo, and then uses the infra snippet to upload it

Santiago Pastorino (Jul 15 2019 at 18:08, on Zulip):

ahh ok

Santiago Pastorino (Jul 15 2019 at 18:25, on Zulip):

@Pietro Albini @davidtwco does any of you know how was in other Rust repos done the process of publishing to a gh-pages branch?

Santiago Pastorino (Jul 15 2019 at 18:25, on Zulip):

should I just push there?

Santiago Pastorino (Jul 15 2019 at 18:25, on Zulip):

I don't even remember if I have rights

Pietro Albini (Jul 15 2019 at 18:26, on Zulip):
env:
  RUSTINFRA_DEPLOY_DIR: path/to/be/deployed
import:
  - rust-lang/simpleinfra/travis-configs/static-websites.yml
Pietro Albini (Jul 15 2019 at 18:26, on Zulip):

of course change path/to/be/deployed

Santiago Pastorino (Jul 15 2019 at 18:26, on Zulip):

ok, it's always done by a bot?

Pietro Albini (Jul 15 2019 at 18:26, on Zulip):

yep

Santiago Pastorino (Jul 15 2019 at 18:26, on Zulip):

that's what you mean?

Santiago Pastorino (Jul 15 2019 at 18:26, on Zulip):

ok

Santiago Pastorino (Jul 15 2019 at 18:27, on Zulip):

ok, we need to hook Hugo someway there

lqd (Jul 15 2019 at 19:15, on Zulip):

@Santiago Pastorino are the changes to the readme expected ? some of the previous content seemed interesting

Santiago Pastorino (Jul 15 2019 at 19:24, on Zulip):

@lqd that is now part of the site

Santiago Pastorino (Jul 15 2019 at 19:24, on Zulip):

meanwhile is not deployed you can find that out in other md files

lqd (Jul 15 2019 at 19:29, on Zulip):

alright, thanks

lqd (Jul 15 2019 at 19:30, on Zulip):

very cool PR in any case :)

Santiago Pastorino (Jul 15 2019 at 19:35, on Zulip):

:+1:

Santiago Pastorino (Jul 15 2019 at 19:35, on Zulip):

@Federico Carrone's work :)

Santiago Pastorino (Jul 15 2019 at 19:36, on Zulip):

btw, left this https://github.com/rust-lang/compiler-team/pull/117 mid road, in case you @Federico Carrone want to pick it up

Santiago Pastorino (Jul 25 2019 at 13:20, on Zulip):

@davidtwco can you do this thing that @Jake Goulding suggested? I can merge PRs but don't have right's to change the description there

davidtwco (Jul 25 2019 at 13:21, on Zulip):

I can't.

Santiago Pastorino (Jul 25 2019 at 13:37, on Zulip):

who is able to do that?

Santiago Pastorino (Jul 25 2019 at 13:38, on Zulip):

btw, the docs directory showing up on urls, that's a github pages deployment thing right?, that's not used in this case or am I wrong?

Pietro Albini (Jul 25 2019 at 13:38, on Zulip):

adding that

Pietro Albini (Jul 25 2019 at 13:39, on Zulip):

oh, someone already did?

Francesco Dainese (Jul 25 2019 at 13:39, on Zulip):

You need to check the repo's settings if GitHub Pages is using /docs or not. You can setup to either deploy on master branch, gh-pages branch, or /docs in master branch

Pietro Albini (Jul 25 2019 at 13:40, on Zulip):

we have a custom deployment process

Pietro Albini (Jul 25 2019 at 13:40, on Zulip):

like, everything seems to be alright, but I think the issue is that the source code is in the content/docs directory, so Hugo prefixes everything with docs

Pietro Albini (Jul 25 2019 at 13:41, on Zulip):

anyone tried to move the pages to the content/ directory?

Francesco Dainese (Jul 25 2019 at 13:41, on Zulip):

Ah I see you are deploying in /public

Francesco Dainese (Jul 25 2019 at 13:43, on Zulip):

I think you are right in the fact that since it's under /docs Hugo puts it there. I would try to move the source files 1 directory up locally but I'm currently not able

Santiago Pastorino (Jul 25 2019 at 14:30, on Zulip):

exactly, I think @Federico Carrone place it on /docs under the impression that we needed that but we don't, so I'd say that we need to move everything from content/docs to content and fix all the links that refers to docs/

Santiago Pastorino (Jul 31 2019 at 13:45, on Zulip):

@davidtwco https://github.com/rust-lang/compiler-team/pull/138 :)

Santiago Pastorino (Jul 31 2019 at 13:45, on Zulip):

@lqd what other things do you see missing?

Santiago Pastorino (Jul 31 2019 at 13:47, on Zulip):

@lqd talking about this https://github.com/rust-lang/compiler-team/issues/137 that @centril opened

lqd (Jul 31 2019 at 14:06, on Zulip):

I think all the commits from the last 5 days or a bit less

Santiago Pastorino (Jul 31 2019 at 14:08, on Zulip):

have you seen any specific? because the docs change is from 2 days ago

Santiago Pastorino (Jul 31 2019 at 14:08, on Zulip):

kind of checked it quickly and couldn't see

lqd (Jul 31 2019 at 14:09, on Zulip):

IIRC my polonius ones, one from Wesley

Santiago Pastorino (Jul 31 2019 at 14:15, on Zulip):

This one https://github.com/rust-lang/compiler-team/commit/7cc7d0a87be66783906bf6b2eb894fe7fcb1d1b7 is lost

lqd (Jul 31 2019 at 14:17, on Zulip):

at least https://github.com/rust-lang/compiler-team/pull/129 and https://github.com/rust-lang/compiler-team/pull/132 I think

Santiago Pastorino (Jul 31 2019 at 14:30, on Zulip):

there are some, I found

Santiago Pastorino (Jul 31 2019 at 14:46, on Zulip):

ok, I've updated the PR to fix all these things https://github.com/rust-lang/compiler-team/pull/138

Santiago Pastorino (Jul 31 2019 at 14:47, on Zulip):

@lqd I think everything is in there

Santiago Pastorino (Jul 31 2019 at 15:21, on Zulip):

@lqd, just merged it and made other fixes too

Santiago Pastorino (Jul 31 2019 at 15:21, on Zulip):

let me know if you see something missing

lqd (Jul 31 2019 at 15:22, on Zulip):

sweet, thanks

Last update: Nov 18 2019 at 01:20UTC