Stream: t-compiler/wg-meta

Topic: expert map


nikomatsakis (Mar 01 2019 at 15:18, on Zulip):

Place to discuss the expert map

Santiago Pastorino (Mar 01 2019 at 15:19, on Zulip):

we are building a map between different areas of the compiler and adding people that know about them

Santiago Pastorino (Mar 01 2019 at 15:20, on Zulip):

https://hackmd.io/Izvor8KZRiqUgcUyd2CYTw

mw (Mar 01 2019 at 16:21, on Zulip):

@nikomatsakis feel free to add yourself to the incremental compilation line :)

nikomatsakis (Mar 01 2019 at 16:26, on Zulip):

You're too kind ;)

nikomatsakis (Mar 01 2019 at 16:27, on Zulip):

or crates

lqd (Mar 01 2019 at 16:28, on Zulip):

could use "CTFE/Miri" with oli and eddy, presumably

nikomatsakis (Mar 01 2019 at 16:29, on Zulip):

I added various lines

nikomatsakis (Mar 01 2019 at 16:30, on Zulip):

i.e., I feel like... I could probably fix or explain the codegen unit partitioner

nikomatsakis (Mar 01 2019 at 16:30, on Zulip):

I'm not sure I'd say I'm an expert in it :P

nikomatsakis (Mar 01 2019 at 16:31, on Zulip):

whoever added "Libs", what is it meant to be? :)

nikomatsakis (Mar 01 2019 at 18:02, on Zulip):

I am debating what it means to be an "expert" now :)

nikomatsakis (Mar 01 2019 at 18:02, on Zulip):

I was thinking .. maybe we should include "directories" in this listing?

nikomatsakis (Mar 01 2019 at 19:08, on Zulip):

I do think @Santiago Pastorino that "MIR" should probably be divided into

nikomatsakis (Mar 01 2019 at 19:09, on Zulip):

in general, there are some areas of the compiler (e.g., librustc/ty) that are like "type definitions" -- I would call e.g. @eddyb or @varkor an expert on those, but also many other folks, maybe we should list them, maybe not

nikomatsakis (Mar 01 2019 at 19:09, on Zulip):

I'm also not sure if listing paths is right but I definitely think it will be useful in some sense:)

varkor (Mar 02 2019 at 01:24, on Zulip):

how specific do we intend to get with the map?

varkor (Mar 02 2019 at 01:25, on Zulip):

for example, I have a good understanding of the exhaustiveness/pattern matching code, but I'm not sure if that's broad enough an area to include here

oli (Mar 02 2019 at 16:42, on Zulip):

I added myself to a bunch of things where I think I can be of help. I'd also like to split up a few things into dirs/files

mw (Mar 04 2019 at 10:59, on Zulip):

we should probably have a line for the query system...

mw (Mar 04 2019 at 11:01, on Zulip):

OK, I added one. I put @nikomatsakis, @Zoxc, @eddyb, and me to the list

mw (Mar 04 2019 at 11:02, on Zulip):

feel free to add yourself to/remove your self from it, as you feel appropriate

mw (Mar 04 2019 at 13:26, on Zulip):

I put myself and @eddyb for "debuginfo". @Manish Goregaokar would you say you know about debuginfo in the compiler too? Anyone else?

Manish Goregaokar (Mar 04 2019 at 13:42, on Zulip):

I know a bit, not a ton. I know more about the gdb implementation. Feel free to put me down as backup though.

Manish Goregaokar (Mar 04 2019 at 13:44, on Zulip):

My areas of expertise are: lints, features, editions, diagnostics, parsing, lowering, resolution. I'm willing to mentor stuff in these areas if pinged.

Manish Goregaokar (Mar 04 2019 at 13:44, on Zulip):

(I'm also decently okay with the overall codebase and can figure stuff out reasonably well, but i'm sure that's true for everyone else on this expert map too)

pnkfelix (Mar 06 2019 at 21:28, on Zulip):

I threw on some rows; feel free to delete entries.

pnkfelix (Mar 06 2019 at 21:29, on Zulip):

I am tempted to add "WG-nll" next to "MIR borrow check" because I feel like a lot of the knowledge there has been pretty well dispersed amongst the group

varkor (Mar 11 2019 at 23:53, on Zulip):

does anyone feel like an expert on infer?

varkor (Mar 11 2019 at 23:53, on Zulip):

specifically regarding the confidence to review https://github.com/rust-lang/rust/pull/59008

Vadim Petrochenkov (Mar 12 2019 at 07:00, on Zulip):

Also, does anybody wants to review https://github.com/rust-lang/rust/pull/58349 (resolve: Simplify import resolution for mixed 2015/2018 edition mode)?
I usually reassign anything assigned to @pnkfelix, but in this case I'm not sure who'd be the proper candidate.

pnkfelix (Mar 12 2019 at 09:36, on Zulip):

Ugh I’m sorry to have overlooked that. I can look at it today and then delegate if necessary

pnkfelix (Mar 12 2019 at 10:03, on Zulip):

(Should we make a #t-compiler topic dedicated to general review requests?)

pnkfelix (Mar 12 2019 at 10:12, on Zulip):

created topic for review requests over here

nikomatsakis (Mar 12 2019 at 14:42, on Zulip):

does anyone feel like an expert on infer?

@varkor I am

varkor (Mar 12 2019 at 15:06, on Zulip):

@nikomatsakis: I cc'd you in the pull request, but I know you're very busy at the moment, so I was wondering whether anyone else was familiar enough, to avoid piling more reviews on your plate

Santiago Pastorino (Mar 12 2019 at 16:45, on Zulip):

@nikomatsakis @davidtwco added a PR for this as we agreed https://github.com/rust-lang/compiler-team/pull/40

davidtwco (Mar 12 2019 at 16:47, on Zulip):

Regarding your comment about embedding it directly into the repository, I think the intent was that we would do that eventually, once we had felt it settled down and wouldn't get changed as frequently. relevant message from meeting

Santiago Pastorino (Mar 12 2019 at 16:48, on Zulip):

yes, I was thinking if it's not sufficiently stable

Santiago Pastorino (Mar 12 2019 at 16:48, on Zulip):

but anyway, I'm fine with both things :)

Santiago Pastorino (Mar 12 2019 at 16:58, on Zulip):

also done this https://github.com/rust-lang/rustc-guide/pull/286

Santiago Pastorino (Mar 12 2019 at 16:58, on Zulip):

sorry for my very limited english vocabulary

Santiago Pastorino (Mar 12 2019 at 16:58, on Zulip):

it's like written by a 4 year old kid :P

centril (Mar 12 2019 at 19:13, on Zulip):

@Santiago Pastorino it's perfectly fine English :slight_smile:

centril (Mar 12 2019 at 19:13, on Zulip):

writing complicated sentences is not better formal writing, simpler is often better ^^

Santiago Pastorino (Mar 14 2019 at 03:00, on Zulip):

@centril thanks :)

nikomatsakis (Mar 14 2019 at 15:27, on Zulip):

@Santiago Pastorino I left a review with a few suggestions

Santiago Pastorino (Mar 14 2019 at 15:46, on Zulip):

will check now

Santiago Pastorino (Mar 14 2019 at 16:01, on Zulip):

@nikomatsakis both things are done!

Santiago Pastorino (Apr 22 2019 at 20:14, on Zulip):

@nikomatsakis @davidtwco I've opened a thread about this on t-compiler

Santiago Pastorino (Apr 22 2019 at 20:14, on Zulip):

saw that that was one of the things that happened during last wg-meta meetings

Santiago Pastorino (Apr 22 2019 at 20:15, on Zulip):

unsure what else we can do, other than what I've done which is asking the rest of compiler people if they can fill the thing

Santiago Pastorino (Apr 22 2019 at 20:15, on Zulip):

maybe we can mention this during next steering meeting?

Santiago Pastorino (Apr 22 2019 at 20:15, on Zulip):

after that I guess we can just move the thing to github and start using PRs as a way to modify it accordingly

lokalmatador (Apr 22 2019 at 20:25, on Zulip):

@Santiago Pastorino , yup, thanks. already got all info

Last update: Nov 18 2019 at 02:15UTC