Stream: t-compiler/wg-meta

Topic: meeting 2019.07.25


nikomatsakis (Jul 25 2019 at 17:53, on Zulip):

(just a quick note that I can't make a meeting today)

Santiago Pastorino (Jul 25 2019 at 18:16, on Zulip):

@nikomatsakis no worries, if @davidtwco is around we can go over at least some issues/prs

Santiago Pastorino (Jul 25 2019 at 18:17, on Zulip):

@davidtwco ping me if you have some spare minutes to go over some of this stuff

davidtwco (Jul 25 2019 at 18:18, on Zulip):

@Santiago Pastorino I’m around just now.

Santiago Pastorino (Jul 25 2019 at 18:20, on Zulip):

cool

Santiago Pastorino (Jul 25 2019 at 18:21, on Zulip):

so ... let's start with PRs I guess?

davidtwco (Jul 25 2019 at 18:21, on Zulip):

Sure.

Santiago Pastorino (Jul 25 2019 at 18:21, on Zulip):

yesterday I went over the minutes and merged them all

Santiago Pastorino (Jul 25 2019 at 18:21, on Zulip):

I'd add an automerge bot for those :)

Santiago Pastorino (Jul 25 2019 at 18:22, on Zulip):

there were like 4 rustc minutes unmerged

davidtwco (Jul 25 2019 at 18:22, on Zulip):

Makes sense. I can try be more active in looking over those.

Santiago Pastorino (Jul 25 2019 at 18:22, on Zulip):

yeah, yesterday I realize that I should be more active on that regard too

Santiago Pastorino (Jul 25 2019 at 18:22, on Zulip):

I will

Santiago Pastorino (Jul 25 2019 at 18:23, on Zulip):

first PR compiler-team#112

davidtwco (Jul 25 2019 at 18:24, on Zulip):

Looks like it should be closed but wasn’t due to a rustbot bug?

Santiago Pastorino (Jul 25 2019 at 18:24, on Zulip):

hmm I think so?

Santiago Pastorino (Jul 25 2019 at 18:25, on Zulip):

should we close it then?

davidtwco (Jul 25 2019 at 18:25, on Zulip):

Yeah.

Santiago Pastorino (Jul 25 2019 at 18:26, on Zulip):

done

Santiago Pastorino (Jul 25 2019 at 18:26, on Zulip):

left the ticket open on my browser just in case bots are mad again

Santiago Pastorino (Jul 25 2019 at 18:26, on Zulip):

next

Santiago Pastorino (Jul 25 2019 at 18:27, on Zulip):

compiler-team#95

davidtwco (Jul 25 2019 at 18:27, on Zulip):

If you’re happy with it, can probably just merge.

Santiago Pastorino (Jul 25 2019 at 18:27, on Zulip):

well this was at some point on my plate but I kind of left it around expecting that some people would more info there

Santiago Pastorino (Jul 25 2019 at 18:27, on Zulip):

I mean, merging won't be bad but it's still incomplete

Santiago Pastorino (Jul 25 2019 at 18:28, on Zulip):

maybe we should merge and create an issue for that?

Santiago Pastorino (Jul 25 2019 at 18:28, on Zulip):

I don't feel strong to fill all the different possibilities to be honest and I may need to spend some time to come up with a complete picture of that

Santiago Pastorino (Jul 25 2019 at 18:28, on Zulip):

so, unsure

Santiago Pastorino (Jul 25 2019 at 18:28, on Zulip):

do you have the knowledge to completely fill that?

Santiago Pastorino (Jul 25 2019 at 18:29, on Zulip):

mainly I wonder what to do to move this forward

davidtwco (Jul 25 2019 at 18:29, on Zulip):

I don’t think so. We did want to add a not-quite-experts level.

Santiago Pastorino (Jul 25 2019 at 18:29, on Zulip):

should we get somebody to try to do that?

davidtwco (Jul 25 2019 at 18:29, on Zulip):

Which might help, since I think individuals would be more likely to sign themselves up (I know I would) should that be added.

Santiago Pastorino (Jul 25 2019 at 18:31, on Zulip):

have just force pushed

Santiago Pastorino (Jul 25 2019 at 18:31, on Zulip):

in case you want to merge

Santiago Pastorino (Jul 25 2019 at 18:31, on Zulip):

I guess we can open an issue

Santiago Pastorino (Jul 25 2019 at 18:32, on Zulip):

actually there is an issue already compiler-team#87

davidtwco (Jul 25 2019 at 18:32, on Zulip):

If you’re interested in doing more on it, we should add some “knowledgeable” or “familiar” level to it and then advertise it again.

Santiago Pastorino (Jul 25 2019 at 18:34, on Zulip):

commented on the issue

Santiago Pastorino (Jul 25 2019 at 18:34, on Zulip):

If you’re interested in doing more on it, we should add some “knowledgeable” or “familiar” level to it and then advertise it again.

how would that look like?

Santiago Pastorino (Jul 25 2019 at 18:35, on Zulip):

a level like that added where?

Santiago Pastorino (Jul 25 2019 at 18:35, on Zulip):

we have https://rust-lang.github.io/compiler-team/docs/experts/

Santiago Pastorino (Jul 25 2019 at 18:35, on Zulip):

we want https://rust-lang.github.io/compiler-team/docs/knowledgeable/ ?

Santiago Pastorino (Jul 25 2019 at 18:36, on Zulip):

or we want the knowleadgeable to live in the same experts map but with a different section for it?

davidtwco (Jul 25 2019 at 18:36, on Zulip):

I’d change [[experts]] to [[areas]] and then change the area key to name and who to experts. Then add a knowledgeable or familiar key.

Santiago Pastorino (Jul 25 2019 at 18:36, on Zulip):

ok

davidtwco (Jul 25 2019 at 18:37, on Zulip):

Unless you have another preference, but I think that would generalise it to multiple lists of people per area.

Santiago Pastorino (Jul 25 2019 at 18:37, on Zulip):

:+1: seems good

Santiago Pastorino (Jul 25 2019 at 18:37, on Zulip):

btw, this compiler-team#95 is now mergeable in case you missed my comment

davidtwco (Jul 25 2019 at 18:38, on Zulip):

Feel free to merge it or you can add the new level on that PR, whatever you prefer.

Santiago Pastorino (Jul 25 2019 at 18:38, on Zulip):

and this compiler-team#67 is the other PR and I'd just leave issues for next time

davidtwco (Jul 25 2019 at 18:39, on Zulip):

I’ll update that this week to be integrated into the website.

Santiago Pastorino (Jul 25 2019 at 18:39, on Zulip):

let's merge it and leave that thing for another PR

Santiago Pastorino (Jul 25 2019 at 18:39, on Zulip):

are we allowed to merge our own PRs? :P

Santiago Pastorino (Jul 25 2019 at 18:39, on Zulip):

I'd feel better if you do it :P

davidtwco (Jul 25 2019 at 18:39, on Zulip):

I can click the button if you want.

Santiago Pastorino (Jul 25 2019 at 18:39, on Zulip):

:)

Santiago Pastorino (Jul 25 2019 at 18:40, on Zulip):

to be honest, I know is a bit silly for this kind of PRs but not sure if there's a policy or something around

Santiago Pastorino (Jul 25 2019 at 18:40, on Zulip):

last one compiler-team#67

Santiago Pastorino (Jul 25 2019 at 18:40, on Zulip):

I guess you're more aware than I am about it

davidtwco (Jul 25 2019 at 18:41, on Zulip):

Yeah, I’ll update that this week to be part of the website.

Santiago Pastorino (Jul 25 2019 at 18:41, on Zulip):

cool

Santiago Pastorino (Jul 25 2019 at 18:41, on Zulip):

are we done then?

Santiago Pastorino (Jul 25 2019 at 18:41, on Zulip):

:)

davidtwco (Jul 25 2019 at 18:41, on Zulip):

I think so.

Santiago Pastorino (Jul 25 2019 at 18:43, on Zulip):

cool :wave: then

Santiago Pastorino (Jul 25 2019 at 18:53, on Zulip):

@davidtwco last thing https://github.com/rust-lang/compiler-team/pull/130

davidtwco (Jul 25 2019 at 18:54, on Zulip):

Nice, we should let people know it is a thing so they can add themselves. I’ll take a look and do that later.

Santiago Pastorino (Jul 25 2019 at 19:01, on Zulip):

I'm already writing a post to IRLO

Santiago Pastorino (Jul 25 2019 at 19:02, on Zulip):

@davidtwco would be better if I send that after we merge this

Santiago Pastorino (Jul 25 2019 at 19:02, on Zulip):

As people have probably seen we have an experts map that tries to put together different areas of the compiler with their respective directories that involved the code of that area and the experts and people familiar with the code base of that area.

We wanted to make a call for people that work on the compiler to automatically sign in there the areas they feel experts or a bit familiar or knowledgeable. In meanwhile you're at there in the areas you know about if you can complete the directories section would be appreciated.

This is the issue in question https://github.com/rust-lang/compiler-team/issues/87 and you can see the experts map here https://github.com/rust-lang/compiler-team/blob/master/content/docs/experts/map.toml

davidtwco (Jul 25 2019 at 19:02, on Zulip):

I don’t mind either way.

davidtwco (Jul 25 2019 at 19:03, on Zulip):

Looks good.

Santiago Pastorino (Jul 25 2019 at 19:03, on Zulip):

I think it would be better to send that after so we already have the familiar place holder

Santiago Pastorino (Jul 25 2019 at 19:03, on Zulip):

if you want to help me improve that in some way, I'm more than open to that :)

Santiago Pastorino (Jul 25 2019 at 19:03, on Zulip):

otherwise I'd just wait you to merge the thing and post it

davidtwco (Jul 25 2019 at 19:04, on Zulip):

Merged.

Santiago Pastorino (Jul 25 2019 at 19:05, on Zulip):

https://internals.rust-lang.org/t/call-to-fill-compiler-experts-familiar-map/10630

Santiago Pastorino (Jul 26 2019 at 19:09, on Zulip):

@davidtwco have you seen this https://github.com/rust-lang/compiler-team/pull/131 from @lqd ?

Santiago Pastorino (Jul 26 2019 at 19:09, on Zulip):

maybe it's a good idea to have a key for external crates?

davidtwco (Jul 26 2019 at 19:10, on Zulip):

Yeah, that sounds good.

lqd (Jul 26 2019 at 19:17, on Zulip):

eg crates or repositories ?

Santiago Pastorino (Jul 26 2019 at 19:18, on Zulip):

yeah, maybe something like that

lqd (Jul 26 2019 at 19:26, on Zulip):

@davidtwco wdyt, something like crates=["https://github.com/rust-lang/polonius", "https://github.com/rust-lang/datafrog"] ?

davidtwco (Jul 26 2019 at 19:37, on Zulip):

Nit: If we’re going to have links to GitHub then repositories is probably a more accurate key name.

Otherwise, LGTM.

lqd (Jul 26 2019 at 19:50, on Zulip):

or just the names in crates if you'd rather not have links

Santiago Pastorino (Jul 26 2019 at 20:04, on Zulip):

I'd go with crates names

lqd (Jul 26 2019 at 20:05, on Zulip):

ok I'll update the PR :)

Santiago Pastorino (Jul 26 2019 at 20:05, on Zulip):

@lqd :+1: meanwhile you're there if you can add crates = [] for the rest of the entries

lqd (Jul 26 2019 at 20:06, on Zulip):

sure no problem

lqd (Jul 26 2019 at 20:20, on Zulip):

@Santiago Pastorino here you go I added the crates entries

Santiago Pastorino (Jul 26 2019 at 20:30, on Zulip):

merged

Santiago Pastorino (Jul 26 2019 at 20:30, on Zulip):

btw guys, if you can add more directories that you know are related to some of the areas that would be more than welcome :)

Santiago Pastorino (Jul 26 2019 at 20:40, on Zulip):

@lqd in particular I've just realized that you've removed the directories entries on polonius area

Santiago Pastorino (Jul 26 2019 at 20:40, on Zulip):

add those back, please :)

lqd (Jul 26 2019 at 20:41, on Zulip):

which entries ? there weren’t any right ?

Santiago Pastorino (Jul 26 2019 at 20:42, on Zulip):

unsure, maybe I'm confused with another PR :)

lqd (Jul 26 2019 at 20:42, on Zulip):

did you see the question I asked in the PR about those btw ?

Santiago Pastorino (Jul 26 2019 at 20:43, on Zulip):

but would be great if you add that here https://github.com/rust-lang/compiler-team/pull/131/files#diff-af6067ceedc68fd82fb1bdcd5b66c548R133

Santiago Pastorino (Jul 26 2019 at 20:43, on Zulip):

ahh ya

Santiago Pastorino (Jul 26 2019 at 20:43, on Zulip):

you put those in a comment

Santiago Pastorino (Jul 26 2019 at 20:44, on Zulip):

hmm I'm wondering if we should reference some of those directories there too

Santiago Pastorino (Jul 26 2019 at 20:44, on Zulip):

what do you think?

Santiago Pastorino (Jul 26 2019 at 20:44, on Zulip):

I know those are not specifically a Polonius thing, it's just that Polonius is used from there

Santiago Pastorino (Jul 26 2019 at 20:44, on Zulip):

unsure, maybe we should leave that empty?

lqd (Jul 26 2019 at 20:44, on Zulip):

since they’re really NLL directories I was unsure whether it was what you wanted, but I don’t really mind either way

lqd (Jul 26 2019 at 20:46, on Zulip):

if the goal of these is for people to know whom to ask for help when they’re in one of those directories, then maybe empty for now, I’m not sure :thinking:

Santiago Pastorino (Jul 26 2019 at 20:46, on Zulip):

yeah empty is better I think :+1:

Last update: Nov 18 2019 at 02:15UTC