Stream: t-compiler/wg-meta

Topic: icebreaker group compiler-team#174


nikomatsakis (Oct 02 2019 at 20:04, on Zulip):

@Santiago Pastorino shall I merge https://github.com/rust-lang/rustc-guide/pull/452 I guess?

Santiago Pastorino (Oct 02 2019 at 20:06, on Zulip):

@nikomatsakis yes, there is a conflict but seems good to me

Santiago Pastorino (Oct 02 2019 at 20:06, on Zulip):

as I said on the PR, my questions were mainly because I wasn't sure if it was a WIP or it was ready

Santiago Pastorino (Oct 02 2019 at 20:06, on Zulip):

but +1

nikomatsakis (Oct 02 2019 at 20:07, on Zulip):

Also I wrote a draft announcement here

nikomatsakis (Oct 02 2019 at 20:07, on Zulip):

this would be intended for the rust blog (or more likely the "Inside Rust" blog)

Santiago Pastorino (Oct 02 2019 at 20:08, on Zulip):

cool

Santiago Pastorino (Oct 02 2019 at 20:08, on Zulip):

reading it

Santiago Pastorino (Oct 02 2019 at 20:09, on Zulip):

open a PR! is a link, wouldn't that be, open a PR adding yourself to the team repo

Santiago Pastorino (Oct 02 2019 at 20:09, on Zulip):

and even maybe put a link to a PR that helps as example?

Santiago Pastorino (Oct 02 2019 at 20:12, on Zulip):

@nikomatsakis announcement looks great :)

nikomatsakis (Oct 02 2019 at 20:13, on Zulip):

ok, rebased

nikomatsakis (Oct 02 2019 at 20:13, on Zulip):

open a PR! is a link, wouldn't that be, open a PR adding yourself to the team repo

I was expecting it to link to some place with directions

Santiago Pastorino (Oct 02 2019 at 20:16, on Zulip):

well, right, we need to merge this https://github.com/rust-lang/team/pull/123

Santiago Pastorino (Oct 02 2019 at 20:17, on Zulip):

once that's merged directions are just add a PR with your name on that toml file

Santiago Pastorino (Oct 02 2019 at 20:18, on Zulip):

but yeah to merge that someone needs to implement what @Pietro Albini has suggested here https://github.com/rust-lang/team/pull/123#issuecomment-535657719

Santiago Pastorino (Oct 07 2019 at 12:54, on Zulip):

hi @Pietro Albini, so you merged this https://github.com/rust-lang/team/pull/135 and https://github.com/rust-lang/team/pull/123 is waiting

Santiago Pastorino (Oct 07 2019 at 12:54, on Zulip):

in the middle we needed to update a bunch of things that depended on team

Pietro Albini (Oct 07 2019 at 12:54, on Zulip):

yep

Santiago Pastorino (Oct 07 2019 at 12:55, on Zulip):

have you done that?, do you need help with it?

Pietro Albini (Oct 07 2019 at 12:56, on Zulip):

I can try and see if I have time later today

Pietro Albini (Oct 07 2019 at 13:02, on Zulip):

actually I'm a bit blocked on other people right now, let me check that

Santiago Pastorino (Oct 07 2019 at 13:06, on Zulip):

:+1:

Santiago Pastorino (Oct 07 2019 at 21:35, on Zulip):

@Pietro Albini seems like everything has now landed :tada:

Pietro Albini (Oct 08 2019 at 08:04, on Zulip):

yeah let's wait for @nikomatsakis to approve and merge it

Last update: Nov 18 2019 at 00:40UTC