Stream: t-compiler/wg-meta

Topic: meeting 2019.06.27


Santiago Pastorino (Jun 27 2019 at 18:01, on Zulip):

hi @T-compiler/WG-meta

Santiago Pastorino (Jun 27 2019 at 18:01, on Zulip):

meeting time I guess?

Santiago Pastorino (Jun 27 2019 at 18:03, on Zulip):

@davidtwco seems like the ones around are you and me?

Santiago Pastorino (Jun 27 2019 at 18:03, on Zulip):

should we go over issues and prs I guess?

davidtwco (Jun 27 2019 at 18:06, on Zulip):

Sure.

Santiago Pastorino (Jun 27 2019 at 18:07, on Zulip):

let's go over the assigned ones I guess

Santiago Pastorino (Jun 27 2019 at 18:07, on Zulip):

starting with ours

Santiago Pastorino (Jun 27 2019 at 18:07, on Zulip):

compiler-team#60

davidtwco (Jun 27 2019 at 18:08, on Zulip):

Blocked on having a website so we can make it dynamic in a way that isn't painful.

Santiago Pastorino (Jun 27 2019 at 18:08, on Zulip):

btw, I was playing with Hugo and seems very nice :)

Santiago Pastorino (Jun 27 2019 at 18:08, on Zulip):

unsure what were we looking for on this task

davidtwco (Jun 27 2019 at 18:09, on Zulip):

Some list of check-ins that doesn't need manually updated.

Santiago Pastorino (Jun 27 2019 at 18:09, on Zulip):

:+1:

Santiago Pastorino (Jun 27 2019 at 18:09, on Zulip):

do you need something to unblock the "having a website" task?

davidtwco (Jun 27 2019 at 18:09, on Zulip):

No, there's a PR for that which I'll review in the next day or two when I get some time.

Santiago Pastorino (Jun 27 2019 at 18:10, on Zulip):

:+1:

Santiago Pastorino (Jun 27 2019 at 18:10, on Zulip):

then Niko have 2 issues assigned

Santiago Pastorino (Jun 27 2019 at 18:10, on Zulip):

and I have

Santiago Pastorino (Jun 27 2019 at 18:10, on Zulip):

compiler-team#87

Santiago Pastorino (Jun 27 2019 at 18:10, on Zulip):

which is there since a long while

Santiago Pastorino (Jun 27 2019 at 18:11, on Zulip):

I was expecting that people jump out there and say, ok this directory is related to this part of the compiler and stuff like that but didn't happen :smile:

Santiago Pastorino (Jun 27 2019 at 18:11, on Zulip):

I think describing the directory structure of the compiler with some more details would be even nice for rustc-guide

Santiago Pastorino (Jun 27 2019 at 18:12, on Zulip):

gonna take the idea for the learning wg

Santiago Pastorino (Jun 27 2019 at 18:12, on Zulip):

do you want to discuss about Niko's issues?

Santiago Pastorino (Jun 27 2019 at 18:12, on Zulip):

there's the contributor RFC for instance

Santiago Pastorino (Jun 27 2019 at 18:12, on Zulip):

I have no clue what's the current status of all that

Santiago Pastorino (Jun 27 2019 at 18:13, on Zulip):

so if you don't have more info on those I'd just skip them

davidtwco (Jun 27 2019 at 18:13, on Zulip):

I think the description of the issue is still correct.

Santiago Pastorino (Jun 27 2019 at 18:13, on Zulip):

:+1:

Santiago Pastorino (Jun 27 2019 at 18:14, on Zulip):

do you want to discuss something else from issues? or we can take a look at some prs?

davidtwco (Jun 27 2019 at 18:14, on Zulip):

I'm good for the issues.

Santiago Pastorino (Jun 27 2019 at 18:15, on Zulip):

ok

Santiago Pastorino (Jun 27 2019 at 18:15, on Zulip):

prs

Santiago Pastorino (Jun 27 2019 at 18:15, on Zulip):

the two from @Wesley Wiser should be merged I think

Santiago Pastorino (Jun 27 2019 at 18:15, on Zulip):

it's notes

Santiago Pastorino (Jun 27 2019 at 18:15, on Zulip):

and some are kind of old so I don't remember anymore

Santiago Pastorino (Jun 27 2019 at 18:15, on Zulip):

but better to have something than nothing

Santiago Pastorino (Jun 27 2019 at 18:16, on Zulip):

and we trust @Wesley Wiser

Santiago Pastorino (Jun 27 2019 at 18:16, on Zulip):

just in case he reads :P

Wesley Wiser (Jun 27 2019 at 18:17, on Zulip):

Notes from various meetings tend to accumulate in the PR queue. I wonder if we should have a more formal policy like "note takers can merge themselves after 24hours and no reviews" or something.

davidtwco (Jun 27 2019 at 18:17, on Zulip):

I think that would make sense.

Santiago Pastorino (Jun 27 2019 at 18:17, on Zulip):

I think that's a good idea

Santiago Pastorino (Jun 27 2019 at 18:17, on Zulip):

or at least ping somebody quickly to put on eye on the notes

Santiago Pastorino (Jun 27 2019 at 18:17, on Zulip):

you definitely can ping me

Santiago Pastorino (Jun 27 2019 at 18:18, on Zulip):

or even mention @T-compiler/WG-meta

Wesley Wiser (Jun 27 2019 at 18:18, on Zulip):

Sure, I can do that in the future

Santiago Pastorino (Jun 27 2019 at 18:18, on Zulip):

there are 3 more about meetings

Santiago Pastorino (Jun 27 2019 at 18:18, on Zulip):

let's take a look quickly and merge I think

Santiago Pastorino (Jun 27 2019 at 18:19, on Zulip):

looking at least for grammatical errors and typos

Santiago Pastorino (Jun 27 2019 at 18:19, on Zulip):

meetings that I did not attend, so ...

Wesley Wiser (Jun 27 2019 at 18:19, on Zulip):

I know there's others that take notes so having something in writing about what the PR etiquette is would probably be generally appreciated.

Santiago Pastorino (Jun 27 2019 at 18:19, on Zulip):

@davidtwco do you think doing that make sense? or should someone that have attended merge this?

Santiago Pastorino (Jun 27 2019 at 18:19, on Zulip):

that's also another discussion

Santiago Pastorino (Jun 27 2019 at 18:19, on Zulip):

should I merge a note from a meeting I even did not attend?

davidtwco (Jun 27 2019 at 18:20, on Zulip):

I think if they sit a while it's fine, only trusted folks have permissions to press merge anyway.

davidtwco (Jun 27 2019 at 18:20, on Zulip):

should I merge a note from a meeting I even did not attend?

It depends what we're trying to achieve with the review of notes - checking spelling/grammar; checking they're in the right place; checking that we agree with the summary?

Wesley Wiser (Jun 27 2019 at 18:22, on Zulip):

(I've only ever gotten spelling/grammar suggestions for what that's worth)

Santiago Pastorino (Jun 27 2019 at 18:23, on Zulip):

yeah I guess just grammar and common sense

Santiago Pastorino (Jun 27 2019 at 18:23, on Zulip):

for instance, take a look at what I just did https://github.com/rust-lang/compiler-team/pull/99#issuecomment-506457163

Santiago Pastorino (Jun 27 2019 at 18:23, on Zulip):

unsure if you'd agree

Santiago Pastorino (Jun 27 2019 at 18:23, on Zulip):

but it's a very bad message to have a month old minute note hanging around

davidtwco (Jun 27 2019 at 18:23, on Zulip):

Yeah, I think that's fine.

Wesley Wiser (Jun 27 2019 at 18:23, on Zulip):

As far as I know, the people who typically write notes are "trusted" community members. So I think the main thing is just spelling/grammar.

Santiago Pastorino (Jun 27 2019 at 18:23, on Zulip):

groups may start not paying attention to it if the notes are not merged quickly

Santiago Pastorino (Jun 27 2019 at 18:24, on Zulip):

I think we need some kind of simple rule here

Santiago Pastorino (Jun 27 2019 at 18:24, on Zulip):

maybe as @Wesley Wiser have said, 24hs after the thing was added it needs to be merged

Santiago Pastorino (Jun 27 2019 at 18:25, on Zulip):

or 48hs, something like that

Wesley Wiser (Jun 27 2019 at 18:25, on Zulip):

I just didn't want to start smashing the Merge PR button without some others opinions :slight_smile:

Santiago Pastorino (Jun 27 2019 at 18:26, on Zulip):

don't worry @Wesley Wiser I just did all that, took the blame out of you :P

Santiago Pastorino (Jun 27 2019 at 18:28, on Zulip):

@davidtwco we are running out of time, is there any other PR we should consider now?

davidtwco (Jun 27 2019 at 18:28, on Zulip):

The big one is the website PR, which I intend to review in a day or two when I have time.

Santiago Pastorino (Jun 27 2019 at 18:29, on Zulip):

:+1:

Santiago Pastorino (Jun 27 2019 at 18:29, on Zulip):

ok, I guess we are done then

Santiago Pastorino (Jun 27 2019 at 18:29, on Zulip):

thanks guys :wave:

Last update: Nov 18 2019 at 01:45UTC