Hey @Pietro Albini -- so i'd like to have this ICE-breaker concept, of people who want to get cc'd on certain kinds of bugs. How hard would it be to have some kind of "github team" that people can easily add themselves to? Can triage bot be extended to do this?
We could also just use the team repo and encourage people to open PRs
Perhaps providing some sort of template or whatever
I'm still a bit hesitant about letting random people add themselves to the org outside the team repo
as everything they'd say in issues or PRs would be interpreted as "official" by outsider (thanks to the "member" badge)
nikomatsakis: We could also just use the team repo and encourage people to open PRs
nikomatsakis: Perhaps providing some sort of template or whatever
heh, the only template we can provide is "run
cargo run add-person foo" and then add your name to wg-ice-breakers
it's annoying and I don't like it, but we need to record the github api id along with the username for security reasons
I see Pietro's point and the discussion is really interesting, because, at the same time, I think in general we adding everyone that just sign up to working groups
so the issue that Pietro is describing is still there
but we have to sign people up manually
adding people manually adds some sort of protection to this at least
yeah, agree :)
the only solution I can see is some sort of web ui that creates the PR for you
but it seems a bit overengineering, and I have other priorities atm
If we just want to cc some group of people I imagine we could add them to a mailing list or so
and just set up a single rust user whose GH notification email is that mailing list
does Github allow to ping some group on another "organization"
I think you can only ping teams within an org
(we run into this with rust-lang-nursery repos which can't ping e.g. rust-lang/libs or so)
would be a nice feature :)
FWIW, if we're expecting <50 people on this group then another "easy" solution is to just list their GH usernames in the comment
not pretty but
maybe from an org you could whitelist other orgs and allow ping teams across orgs :P
dreaming about gh features :)
we could do a browser plugin that once you write @wg-rust-lang/ice-breakers it automatically expands into that
Well, getting rustbot to ping the group if you just said ping
@rustbot break ice would be pretty easy
yeah, better :)
so ... given that we don't want to allow people to auto sign up for Rust team repo but it would be nice if people can automatically add themselves somewhere and be pinged ...
why don't we use rustbot and get a list of wg members from somewhere else? so they can auto sign to a place that don't make them belong to the org
well, we can still have them in the team repo and such, it's just we wouldn't sync that wg to a github team
they can add themselves via PR to said repo (I'd imagine a 1-2 day max of latency to that isn't too bad, and the likely latency is ~1 hour or so)
maybe that's the best approach then?
If someone files an issue on rustbot I can likely get an impl going in a week or so (but it shouldn't be too difficult to add for anyone, if someone else wants to)
/cc @nikomatsakis does this works for you?
having wg members on team repo not being part of the org, people can sign up to a wg by sending a pr to team repo and then we can ping groups using rustbot
that seems plausible
I think submitting a PR to the team repo is reasonable, and we can leave some simple instructions
I don't have a strong opinion about GH team sync
but I agree that if we can avoid doing it lightly it's better
@Pietro Albini @simulacrum @nikomatsakis to summarize decisions ...
On team repo we would like to keep track of members of working-groups but have them not being syncronized with rust-lang github organization, rather keep a list of them so we can query for data
On triagebot repo we would like to implement a feature where we can ping groups using @rustbot. I can open an issue for that.
So people can sign up for WGs, just by putting a PR to team repo
and we can notify them using @rustbot and keep rights on the org in a sane way.
quouting @nikomatsakis ...
in particular, in my ideal world, we'd make a toml file with some intro text, maybe a link to the "how to fix a bug" guide, and then we'd say @rustbot icebreaker llvm or something, and it would add a note that's like
Dear LLVM icebreakers! This might be a good bug to look at!
and includes the links etc
(plus sets label)
does that sounds good?
should the text be different between "icebreaker teams"?
Yes, that all sounds good -- not quite sure about the toml file (purpose, etc) but it sounds reasonable. Can probably spec it out in the issue.
because otherwise all the team repo work is already done
I will note that I become much more motivated with a complete spec to implement things in triagebot :)
but yeah an issue with a spec would be good
should the text be different between "icebreaker teams"?
the text is probably more or less the same, but the links will vary -- e.g., I expect that for each team there'll be a different link giving guidelines specific to fixing those sorts of bugs
hmm, not sure whether it's better to put it into triagebot's config or the team repo
I'm leaning the team repo as the triagebot config is sort of a pain to tweak
(as its configuration is
triagebot.toml in the root of the repo, aka it needs to go through bors)
@simulacrum @Pietro Albini triagebot#169 let me know if this makes sense to you and you have all the needed information
I think that's pretty good, I'll take a look sometime this week
modulo Pietro's question
@simulacrum which one in particular?
@Santiago Pastorino from the comment on the issue?
I'd say whatever is better for you guys
It doesn't really matter all that much so I'll just make some decision when I get to that point