Stream: t-compiler/wg-meta

Topic: ICE breaker self-subscribing github team


nikomatsakis (Sep 10 2019 at 15:00, on Zulip):

Hey @Pietro Albini -- so i'd like to have this ICE-breaker concept, of people who want to get cc'd on certain kinds of bugs. How hard would it be to have some kind of "github team" that people can easily add themselves to? Can triage bot be extended to do this?

nikomatsakis (Sep 10 2019 at 15:01, on Zulip):

We could also just use the team repo and encourage people to open PRs

nikomatsakis (Sep 10 2019 at 15:01, on Zulip):

Perhaps providing some sort of template or whatever

Pietro Albini (Sep 10 2019 at 16:25, on Zulip):

I'm still a bit hesitant about letting random people add themselves to the org outside the team repo

Pietro Albini (Sep 10 2019 at 16:26, on Zulip):

as everything they'd say in issues or PRs would be interpreted as "official" by outsider (thanks to the "member" badge)

Pietro Albini (Sep 10 2019 at 16:28, on Zulip):

nikomatsakis: We could also just use the team repo and encourage people to open PRs
nikomatsakis: Perhaps providing some sort of template or whatever

heh, the only template we can provide is "run cargo run add-person foo" and then add your name to wg-ice-breakers

Pietro Albini (Sep 10 2019 at 16:29, on Zulip):

it's annoying and I don't like it, but we need to record the github api id along with the username for security reasons

Santiago Pastorino (Sep 10 2019 at 16:31, on Zulip):

I see Pietro's point and the discussion is really interesting, because, at the same time, I think in general we adding everyone that just sign up to working groups

Santiago Pastorino (Sep 10 2019 at 16:31, on Zulip):

so the issue that Pietro is describing is still there

Santiago Pastorino (Sep 10 2019 at 16:32, on Zulip):

but we have to sign people up manually

Pietro Albini (Sep 10 2019 at 16:34, on Zulip):

adding people manually adds some sort of protection to this at least

Santiago Pastorino (Sep 10 2019 at 16:52, on Zulip):

yeah, agree :)

Pietro Albini (Sep 10 2019 at 16:53, on Zulip):

the only solution I can see is some sort of web ui that creates the PR for you

Pietro Albini (Sep 10 2019 at 16:53, on Zulip):

but it seems a bit overengineering, and I have other priorities atm

simulacrum (Sep 10 2019 at 17:16, on Zulip):

If we just want to cc some group of people I imagine we could add them to a mailing list or so

simulacrum (Sep 10 2019 at 17:17, on Zulip):

and just set up a single rust user whose GH notification email is that mailing list

Santiago Pastorino (Sep 10 2019 at 17:17, on Zulip):

does Github allow to ping some group on another "organization"

Santiago Pastorino (Sep 10 2019 at 17:18, on Zulip):

like /cc @rust-lang-wgs/ice-breakers

simulacrum (Sep 10 2019 at 17:18, on Zulip):

I think you can only ping teams within an org

simulacrum (Sep 10 2019 at 17:18, on Zulip):

(we run into this with rust-lang-nursery repos which can't ping e.g. rust-lang/libs or so)

Santiago Pastorino (Sep 10 2019 at 17:18, on Zulip):

would be a nice feature :)

simulacrum (Sep 10 2019 at 17:19, on Zulip):

FWIW, if we're expecting <50 people on this group then another "easy" solution is to just list their GH usernames in the comment

simulacrum (Sep 10 2019 at 17:19, on Zulip):

not pretty but

Santiago Pastorino (Sep 10 2019 at 17:22, on Zulip):

(deleted)

Santiago Pastorino (Sep 10 2019 at 17:22, on Zulip):

maybe from an org you could whitelist other orgs and allow ping teams across orgs :P

Santiago Pastorino (Sep 10 2019 at 17:22, on Zulip):

dreaming about gh features :)

Santiago Pastorino (Sep 10 2019 at 17:22, on Zulip):

we could do a browser plugin that once you write @wg-rust-lang/ice-breakers it automatically expands into that

simulacrum (Sep 10 2019 at 17:23, on Zulip):

Well, getting rustbot to ping the group if you just said ping @rustbot break ice would be pretty easy

Santiago Pastorino (Sep 10 2019 at 17:23, on Zulip):

yeah, better :)

Santiago Pastorino (Sep 10 2019 at 17:24, on Zulip):

so ... given that we don't want to allow people to auto sign up for Rust team repo but it would be nice if people can automatically add themselves somewhere and be pinged ...

Santiago Pastorino (Sep 10 2019 at 17:25, on Zulip):

why don't we use rustbot and get a list of wg members from somewhere else? so they can auto sign to a place that don't make them belong to the org

simulacrum (Sep 10 2019 at 17:26, on Zulip):

well, we can still have them in the team repo and such, it's just we wouldn't sync that wg to a github team

simulacrum (Sep 10 2019 at 17:26, on Zulip):

they can add themselves via PR to said repo (I'd imagine a 1-2 day max of latency to that isn't too bad, and the likely latency is ~1 hour or so)

Santiago Pastorino (Sep 10 2019 at 17:29, on Zulip):

maybe that's the best approach then?

Santiago Pastorino (Sep 10 2019 at 17:29, on Zulip):

:+1:

simulacrum (Sep 10 2019 at 17:53, on Zulip):

If someone files an issue on rustbot I can likely get an impl going in a week or so (but it shouldn't be too difficult to add for anyone, if someone else wants to)

Santiago Pastorino (Sep 10 2019 at 18:01, on Zulip):

/cc @nikomatsakis does this works for you?

Santiago Pastorino (Sep 10 2019 at 18:03, on Zulip):

having wg members on team repo not being part of the org, people can sign up to a wg by sending a pr to team repo and then we can ping groups using rustbot

nikomatsakis (Sep 11 2019 at 15:43, on Zulip):

that seems plausible

nikomatsakis (Sep 11 2019 at 15:43, on Zulip):

I think submitting a PR to the team repo is reasonable, and we can leave some simple instructions

nikomatsakis (Sep 11 2019 at 15:43, on Zulip):

I don't have a strong opinion about GH team sync

nikomatsakis (Sep 11 2019 at 15:43, on Zulip):

but I agree that if we can avoid doing it lightly it's better

Santiago Pastorino (Sep 19 2019 at 20:38, on Zulip):

@Pietro Albini @simulacrum @nikomatsakis to summarize decisions ...

Santiago Pastorino (Sep 19 2019 at 20:38, on Zulip):

On team repo we would like to keep track of members of working-groups but have them not being syncronized with rust-lang github organization, rather keep a list of them so we can query for data

Santiago Pastorino (Sep 19 2019 at 20:39, on Zulip):

On triagebot repo we would like to implement a feature where we can ping groups using @rustbot. I can open an issue for that.

Santiago Pastorino (Sep 19 2019 at 20:39, on Zulip):

So people can sign up for WGs, just by putting a PR to team repo

Santiago Pastorino (Sep 19 2019 at 20:39, on Zulip):

and we can notify them using @rustbot and keep rights on the org in a sane way.

Santiago Pastorino (Sep 19 2019 at 20:39, on Zulip):

quouting @nikomatsakis ...

Santiago Pastorino (Sep 19 2019 at 20:40, on Zulip):

in particular, in my ideal world, we'd make a toml file with some intro text, maybe a link to the "how to fix a bug" guide, and then we'd say @rustbot icebreaker llvm or something, and it would add a note that's like

Dear LLVM icebreakers! This might be a good bug to look at!

and includes the links etc

(plus sets label)

Santiago Pastorino (Sep 19 2019 at 20:40, on Zulip):

does that sounds good?

Pietro Albini (Sep 19 2019 at 20:42, on Zulip):

should the text be different between "icebreaker teams"?

simulacrum (Sep 19 2019 at 20:42, on Zulip):

Yes, that all sounds good -- not quite sure about the toml file (purpose, etc) but it sounds reasonable. Can probably spec it out in the issue.

Pietro Albini (Sep 19 2019 at 20:42, on Zulip):

because otherwise all the team repo work is already done

Pietro Albini (Sep 19 2019 at 20:42, on Zulip):

i.e. https://team-api.infra.rust-lang.org/v1/teams/compiler.json

simulacrum (Sep 19 2019 at 20:42, on Zulip):

I will note that I become much more motivated with a complete spec to implement things in triagebot :)

Pietro Albini (Sep 19 2019 at 20:43, on Zulip):

but yeah an issue with a spec would be good

nikomatsakis (Sep 19 2019 at 20:53, on Zulip):

should the text be different between "icebreaker teams"?

the text is probably more or less the same, but the links will vary -- e.g., I expect that for each team there'll be a different link giving guidelines specific to fixing those sorts of bugs

Pietro Albini (Sep 19 2019 at 20:59, on Zulip):

hmm, not sure whether it's better to put it into triagebot's config or the team repo

Pietro Albini (Sep 19 2019 at 20:59, on Zulip):

I'm leaning the team repo as the triagebot config is sort of a pain to tweak

Pietro Albini (Sep 19 2019 at 21:00, on Zulip):

(as its configuration is triagebot.toml in the root of the repo, aka it needs to go through bors)

Santiago Pastorino (Sep 23 2019 at 17:04, on Zulip):

@simulacrum @Pietro Albini triagebot#169 let me know if this makes sense to you and you have all the needed information

simulacrum (Sep 23 2019 at 18:28, on Zulip):

I think that's pretty good, I'll take a look sometime this week

simulacrum (Sep 23 2019 at 18:28, on Zulip):

(hopefully)

simulacrum (Sep 23 2019 at 18:29, on Zulip):

modulo Pietro's question

Santiago Pastorino (Sep 23 2019 at 19:57, on Zulip):

@simulacrum which one in particular?

simulacrum (Sep 23 2019 at 19:59, on Zulip):

@Santiago Pastorino from the comment on the issue?

Santiago Pastorino (Sep 23 2019 at 20:03, on Zulip):

@nikomatsakis https://github.com/rust-lang/triagebot/issues/169#issuecomment-534194212

Santiago Pastorino (Sep 23 2019 at 20:03, on Zulip):

I'd say whatever is better for you guys

simulacrum (Sep 23 2019 at 20:25, on Zulip):

It doesn't really matter all that much so I'll just make some decision when I get to that point

nikomatsakis (Sep 24 2019 at 14:32, on Zulip):

Left a comment

Last update: Nov 18 2019 at 01:20UTC