Stream: t-compiler/wg-meta

Topic: meeting 2020.01.16


nikomatsakis (Jan 16 2020 at 19:04, on Zulip):

Hey @T-compiler/WG-meta -- sorry, a few minutes late, time flies

davidtwco (Jan 16 2020 at 19:05, on Zulip):

:wave:

nikomatsakis (Jan 16 2020 at 19:05, on Zulip):

The main thing on my mind is the continuing to setup and announce the "cleanup crew"

nikomatsakis (Jan 16 2020 at 19:06, on Zulip):

Though there are a few other "leadership-y" things that I've been pondering:

nikomatsakis (Jan 16 2020 at 19:06, on Zulip):

https://github.com/rust-lang/compiler-team/issues/207

nikomatsakis (Jan 16 2020 at 19:07, on Zulip):

Check list of things to do:

pnkfelix (Jan 16 2020 at 19:07, on Zulip):

is the guide on how to bisect-and-reduce part of the existing rustc-dev-guide ? Or is it a separate thing?

nikomatsakis (Jan 16 2020 at 19:08, on Zulip):

it's https://github.com/rust-lang/rustc-guide/pull/556/

nikomatsakis (Jan 16 2020 at 19:08, on Zulip):

I should update the issue with a link

nikomatsakis (Jan 16 2020 at 19:08, on Zulip):

I think that PR is almost done? the main thing it needs is a bit more about how to identify range of PRs in a nightly

nikomatsakis (Jan 16 2020 at 19:08, on Zulip):

e.g. I think it should say "get a checkout of rustc"

nikomatsakis (Jan 16 2020 at 19:08, on Zulip):

"run this horrific git command"

nikomatsakis (Jan 16 2020 at 19:08, on Zulip):

e.g., the --author bors bit is not obvious

nikomatsakis (Jan 16 2020 at 19:09, on Zulip):

What is the command anyway? git log --author bors --oneline SHA1..SHA2?

nikomatsakis (Jan 16 2020 at 19:09, on Zulip):

someting like that

nikomatsakis (Jan 16 2020 at 19:09, on Zulip):

I should go try it out I guess

nikomatsakis (Jan 16 2020 at 19:10, on Zulip):

OK, created https://github.com/rust-lang/rust/labels/ICEBreaker-Cleanup-Crew

nikomatsakis (Jan 16 2020 at 19:11, on Zulip):

does anybody want to take on any of the other work items? I can maybe just bang them out right now..

nikomatsakis (Jan 16 2020 at 19:11, on Zulip):

otherwise not sure if we have anything else to talk about this week :)

davidtwco (Jan 16 2020 at 19:12, on Zulip):

I don't think I've got any free time this week, university has just resumed.

nikomatsakis (Jan 16 2020 at 19:12, on Zulip):

:heart:

pnkfelix (Jan 16 2020 at 19:12, on Zulip):

git log --author=bors --format=oneline SHA1..SHA2 ... I've cut and pasted it into some recent PR's so that's probably the best thing to refer to

pnkfelix (Jan 16 2020 at 19:13, on Zulip):

Do we know if anyone (e.g. @Santiago Pastorino ) is going to try to add stuff like Github API support to cargo-bisect-rustc in the near term?

pnkfelix (Jan 16 2020 at 19:14, on Zulip):

i ask because the tool rocks and I figure i might hack some stuff (maybe start with smaller things like a --invert flag) onto it as needed in my work

nikomatsakis (Jan 16 2020 at 19:14, on Zulip):

Do we know if anyone (e.g. Santiago Pastorino ) is going to try to add stuff like Github API support to cargo-bisect-rustc in the near term?

@Santiago Pastorino is on vacation till Feb or so, but I think if you have specific feature requests we can discuss them

nikomatsakis (Jan 16 2020 at 19:15, on Zulip):

I am very much in favor of improving the tool

nikomatsakis (Jan 16 2020 at 19:15, on Zulip):

I think those kind of investments pay for themselves many times over

nikomatsakis (Jan 16 2020 at 19:17, on Zulip):

Does somebody want to look at https://github.com/rust-lang/rustc-guide/pull/556/

nikomatsakis (Jan 16 2020 at 19:17, on Zulip):

I just pushed the git log info

pnkfelix (Jan 16 2020 at 19:18, on Zulip):

I skimmed it before, you can assign full review to me... I don't even know if I have r+ privileges on rust-lang/rustc-guide :embarrassed:

pnkfelix (Jan 16 2020 at 19:18, on Zulip):

or I just self-assigned

nikomatsakis (Jan 16 2020 at 19:19, on Zulip):

I think everybody in compiler-team probably does

nikomatsakis (Jan 16 2020 at 19:19, on Zulip):

Yes, they do

pnkfelix (Jan 16 2020 at 19:20, on Zulip):

BTW, what is the "ideal" with respect to linking duplicate bugs?

pnkfelix (Jan 16 2020 at 19:20, on Zulip):

I know that github will show a reference inline on the issue page

pnkfelix (Jan 16 2020 at 19:20, on Zulip):

but that is a consequence of a mention of the issue

nikomatsakis (Jan 16 2020 at 19:20, on Zulip):

good question

pnkfelix (Jan 16 2020 at 19:20, on Zulip):

and thus you do not always know why there is a link

nikomatsakis (Jan 16 2020 at 19:21, on Zulip):

I don't know the answer

pnkfelix (Jan 16 2020 at 19:21, on Zulip):

arguably bugzilla does this better, by having a dedicated field for listing dupes

nikomatsakis (Jan 16 2020 at 19:21, on Zulip):

the main thing I know is that if you close one bug in favor of the other, I think it's good practice to copy the "minimized test" if it feels "substantially different"

nikomatsakis (Jan 16 2020 at 19:21, on Zulip):

arguably bugzilla does this better, by having a dedicated field for listing dupes

this is like so many things in bugzilla :)

nikomatsakis (Jan 16 2020 at 19:21, on Zulip):

bugzilla's best feature is powerful metadata, github's best feature is blinding simplicity...

pnkfelix (Jan 16 2020 at 19:21, on Zulip):

(and yet we prefer github issues. probably because it lets you edit comments. and is, you know, integrated with github... and has markdown formatting)

pnkfelix (Jan 16 2020 at 19:22, on Zulip):

anyway I have caused a slight digression.

pnkfelix (Jan 16 2020 at 19:22, on Zulip):

we don't have to resolve the question of "ideal duplicate presentation" here

pnkfelix (Jan 16 2020 at 19:23, on Zulip):

(in my ideal world,. the issue description would be updated with this sort of metadata)

nikomatsakis (Jan 16 2020 at 19:25, on Zulip):

yeah

nikomatsakis (Jan 16 2020 at 19:25, on Zulip):

it seems like something github could add

nikomatsakis (Jan 16 2020 at 19:25, on Zulip):

similar to Fixes #123

nikomatsakis (Jan 16 2020 at 19:25, on Zulip):

you could have some magic keywords

nikomatsakis (Jan 16 2020 at 19:25, on Zulip):

duplicate of #123

nikomatsakis (Jan 16 2020 at 19:25, on Zulip):

and it would show in the issue header

nikomatsakis (Jan 16 2020 at 19:26, on Zulip):

created https://github.com/rust-lang/team/pull/214

nikomatsakis (Jan 16 2020 at 19:26, on Zulip):

not sure if we have some initial person who wants to be pinged for cleanup crew to put in the list :)

Santiago Pastorino (Jan 17 2020 at 04:15, on Zulip):

Do we know if anyone (e.g. Santiago Pastorino ) is going to try to add stuff like Github API support to cargo-bisect-rustc in the near term?

Santiago Pastorino is on vacation till Feb or so, but I think if you have specific feature requests we can discuss them

@nikomatsakis @pnkfelix My vacations end today, on monday I will be back and we can talk about this :).

Last update: Feb 25 2020 at 04:15UTC