Stream: t-compiler/wg-meta

Topic: bots


Pietro Albini (Apr 18 2019 at 19:17, on Zulip):

so, we discussed in the infra team meeting bots for the out-of-tree repositories

Pietro Albini (Apr 18 2019 at 19:17, on Zulip):

and... there were some conflicting opinions

Pietro Albini (Apr 18 2019 at 19:19, on Zulip):

on one hand we want configuring bots to be as easy as possible, ideally in a way y'all can do that without even notifying infra

Pietro Albini (Apr 18 2019 at 19:20, on Zulip):

but on the other hand we don't want to give bots full permissions across the whole org, since having a god token is not really the best thing security wise

Pietro Albini (Apr 18 2019 at 19:23, on Zulip):

there were also some doubts whether bors is really needed for out of tree repos

Pietro Albini (Apr 18 2019 at 19:23, on Zulip):

@nikomatsakis @davidtwco ?

Pietro Albini (Apr 18 2019 at 19:25, on Zulip):

the way I'm envisioning a possible "setting up bots" workflow (at least for triagebot) is:
- adding a configuration file (like triagebot.toml) at the root of the repo with the bot configuration file
- adding write access to a "bots" team in the settings

davidtwco (Apr 18 2019 at 19:31, on Zulip):

I think the primary desire is to have a uniform contributing experience for compiler folks whether they work in tree or out.

davidtwco (Apr 18 2019 at 19:32, on Zulip):

And a decent part of that is bots.

Pietro Albini (Apr 18 2019 at 19:46, on Zulip):

also cc @simulacrum

Pietro Albini (Apr 18 2019 at 19:47, on Zulip):

@davidtwco hmm, ok

Pietro Albini (Apr 18 2019 at 19:48, on Zulip):

setting up bors is going to require manually pinging the infra team for the foreseeable future, but we can make adding triagebot a thing you can do yourself as the compiler team

Pietro Albini (Apr 18 2019 at 19:48, on Zulip):

and for highfive... I just want to reimplement it in triagebot in the near future

davidtwco (Apr 18 2019 at 19:55, on Zulip):

I don't think we'll be creating out-of-tree crates that much, at least in the short term. So that sounds totally fine.

We've got compiler-team#57 to finish off our out-of-tree crates instructions, and most of that is documenting how to set up the bots and things like that.

simulacrum (Apr 18 2019 at 20:22, on Zulip):

FWIW @Alex Crichton has mentioned multiple times that bors is probably not needed for anything beyond rust-lang/rust

nikomatsakis (Apr 18 2019 at 22:03, on Zulip):

I .. am of mixed minds. I agree with @davidtwco that it'd be nice to be uniform in our process and experience. I also agree that for most smaller repos I don't feel a strong need for bors. I'm curious what the downsides of using bors are.

nikomatsakis (Apr 18 2019 at 22:03, on Zulip):

Like, if the setup is easy...why not?

nikomatsakis (Apr 18 2019 at 22:03, on Zulip):

the way I'm envisioning a possible "setting up bots" workflow (at least for triagebot) is:
- adding a configuration file (like triagebot.toml) at the root of the repo with the bot configuration file
- adding write access to a "bots" team in the settings

in general though this sounds pretty good

davidtwco (Apr 18 2019 at 22:06, on Zulip):

I'll clarify that I feel the same way, I don't disagree that most of the repos probably don't warrant as heavyweight a tool as bors while simultaneously thinking it would be valuable to have a uniform experience across repositories.

Pietro Albini (Apr 18 2019 at 22:32, on Zulip):

well, the setup of bors is a bit of a pain because it requires a RCS redeploy, which is not nice

Pietro Albini (Apr 18 2019 at 22:33, on Zulip):

but the upside is that bors configuration doesn't really change once setup, especially now that reviewers are moved to the team repo

Alex Crichton (Apr 18 2019 at 23:25, on Zulip):

@nikomatsakis yeah I'd agree with @Pietro Albini in that the setup is pretty nontrivial right now and runs a risk of putting too much burden on the infra team relative to the gains earned

Alex Crichton (Apr 18 2019 at 23:25, on Zulip):

I definitely agree that having a good uniform experience is nice though

Last update: Nov 18 2019 at 01:25UTC