Stream: t-compiler/wg-meta

Topic: meeting 2019.10.10


nikomatsakis (Oct 10 2019 at 18:05, on Zulip):

Hey @T-compiler/WG-meta :wave:

Santiago Pastorino (Oct 10 2019 at 18:05, on Zulip):

hey

nikomatsakis (Oct 10 2019 at 18:06, on Zulip):

So I think a lot has happened but I've not caught up

nikomatsakis (Oct 10 2019 at 18:06, on Zulip):

In particular I guess the LLVM ICE-breaker signup is basically ready to go?

Santiago Pastorino (Oct 10 2019 at 18:07, on Zulip):

on my side https://github.com/rust-lang/team/pull/135 and https://github.com/rust-lang/team/pull/123

Santiago Pastorino (Oct 10 2019 at 18:07, on Zulip):

yeah, @Pietro Albini delegated the one about the team to you :)

nikomatsakis (Oct 10 2019 at 18:07, on Zulip):

I just have to merge https://github.com/rust-lang/team/pull/123 ?

Pietro Albini (Oct 10 2019 at 18:07, on Zulip):

yeah

Santiago Pastorino (Oct 10 2019 at 18:07, on Zulip):

yes

nikomatsakis (Oct 10 2019 at 18:08, on Zulip):

question:

nikomatsakis (Oct 10 2019 at 18:08, on Zulip):

can you make "template PRs" in GH?

Santiago Pastorino (Oct 10 2019 at 18:08, on Zulip):

there's the setup work, the code to support Marker teams and the other one is adding the actual icebreakers-llvm with nagisa and nikic as leads

nikomatsakis (Oct 10 2019 at 18:08, on Zulip):

i.e., if we wanted to say "to add yourself to the team, do this"

nikomatsakis (Oct 10 2019 at 18:08, on Zulip):

could we link to some "template PR" like you have an issue template?

Santiago Pastorino (Oct 10 2019 at 18:08, on Zulip):

I don't think so

Pietro Albini (Oct 10 2019 at 18:09, on Zulip):

@nikomatsakis it wouldn't be possible

nikomatsakis (Oct 10 2019 at 18:09, on Zulip):

I guess not

Santiago Pastorino (Oct 10 2019 at 18:09, on Zulip):

but I guess you can point to the file in questions and say add your name here :)

nikomatsakis (Oct 10 2019 at 18:09, on Zulip):

yeah it's fine

Pietro Albini (Oct 10 2019 at 18:09, on Zulip):

to add yourself to the team repo you have to insert your github id

nikomatsakis (Oct 10 2019 at 18:09, on Zulip):

ah, hmm, yeah

nikomatsakis (Oct 10 2019 at 18:09, on Zulip):

ok so we have to write-up the instructions properly

Pietro Albini (Oct 10 2019 at 18:09, on Zulip):

yeah, it kinda sucks

nikomatsakis (Oct 10 2019 at 18:09, on Zulip):

you have to do two things basically, right?

  1. add your name to the list
  2. cargo run some command?
Santiago Pastorino (Oct 10 2019 at 18:09, on Zulip):

people can also edit the file using github UI

Pietro Albini (Oct 10 2019 at 18:10, on Zulip):

it would be nice to get some sort of self-service dashboard that you log into with oauth and it prepares the PR for you

Santiago Pastorino (Oct 10 2019 at 18:10, on Zulip):

ahh right, they need to add themselves to people/

Pietro Albini (Oct 10 2019 at 18:10, on Zulip):

(which could be extended to automate other stuff for team members)

Pietro Albini (Oct 10 2019 at 18:10, on Zulip):

but I guess people would have to develop it

nikomatsakis (Oct 10 2019 at 18:10, on Zulip):

it's fine

nikomatsakis (Oct 10 2019 at 18:10, on Zulip):

people can run the command for now

nikomatsakis (Oct 10 2019 at 18:10, on Zulip):

or they can open a PR and I will run the command for them

nikomatsakis (Oct 10 2019 at 18:11, on Zulip):

ok I merged https://github.com/rust-lang/team/pull/123

Santiago Pastorino (Oct 10 2019 at 18:11, on Zulip):

wouldn't make sense to support people only in this kind of teams to not be on people directory?

Pietro Albini (Oct 10 2019 at 18:11, on Zulip):

steps are:

  1. clone the repo
  2. run cargo run add-person username
  3. add yourself to teams/icebreakers-llvm.toml
  4. commit and send the PR
Santiago Pastorino (Oct 10 2019 at 18:11, on Zulip):

yes

Pietro Albini (Oct 10 2019 at 18:11, on Zulip):

@Santiago Pastorino no, we need the github id for security reasons

Santiago Pastorino (Oct 10 2019 at 18:11, on Zulip):

I wonder if we could get rid of 2 for these teams

nikomatsakis (Oct 10 2019 at 18:12, on Zulip):

@Pietro Albini steps 2 and 3 can be done in any order, right?

Pietro Albini (Oct 10 2019 at 18:12, on Zulip):

yeah

Santiago Pastorino (Oct 10 2019 at 18:12, on Zulip):

Santiago Pastorino no, we need the github id for security reasons

:+1:

Santiago Pastorino (Oct 10 2019 at 18:12, on Zulip):

hmm but why? what's the security concern in this case?

Pietro Albini (Oct 10 2019 at 18:12, on Zulip):

the issue is we can't rely on the github username for any integration, as people can change their username and anyone can claim the old one

Santiago Pastorino (Oct 10 2019 at 18:13, on Zulip):

I mean, remember that the names here are only for triagebot to ping them when there's an issue

nikomatsakis (Oct 10 2019 at 18:13, on Zulip):

@Pietro Albini also, is this a good example? everything look right?

Santiago Pastorino (Oct 10 2019 at 18:14, on Zulip):

the worst that can happen is that if there's somebody in a group and change their name we may end pinging the wrong person

nikomatsakis (Oct 10 2019 at 18:15, on Zulip):

https://github.com/rust-lang/team/pull/140

nikomatsakis (Oct 10 2019 at 18:15, on Zulip):

I'm just going to close the PR since I don't actually want me name on there, but then I can link to it as an example

Pietro Albini (Oct 10 2019 at 18:15, on Zulip):

@nikomatsakis tweaked the text a bit

nikomatsakis (Oct 10 2019 at 18:16, on Zulip):

great, thanks

Pietro Albini (Oct 10 2019 at 18:16, on Zulip):

@Santiago Pastorino I really don't want to add exceptions for this rule, all the integrations rely on the github id being present

Santiago Pastorino (Oct 10 2019 at 18:16, on Zulip):

:+1:

Santiago Pastorino (Oct 10 2019 at 18:17, on Zulip):

if we were creating a fake PR like this for people don't we want to create it for a non member user?

nikomatsakis (Oct 10 2019 at 18:17, on Zulip):

the steps are the same, I think? except they have to run the command

Pietro Albini (Oct 10 2019 at 18:17, on Zulip):

shrugs the file is auto-generated anyway

Santiago Pastorino (Oct 10 2019 at 18:17, on Zulip):

like why don't you use john_doe ...

Santiago Pastorino (Oct 10 2019 at 18:17, on Zulip):

well ok :)

nikomatsakis (Oct 10 2019 at 18:18, on Zulip):

good question

nikomatsakis (Oct 10 2019 at 18:18, on Zulip):

good enough

Santiago Pastorino (Oct 10 2019 at 18:18, on Zulip):

anyway, the question is ... if people do not figure out, do they deserve to be part of team? :joy:

nikomatsakis (Oct 10 2019 at 18:19, on Zulip):

exactly ;)

Santiago Pastorino (Oct 10 2019 at 18:19, on Zulip):

hehe

Santiago Pastorino (Oct 10 2019 at 18:20, on Zulip):

with this in place I can ping @simulacrum about the bot

Pietro Albini (Oct 10 2019 at 18:21, on Zulip):

(if y'all don't need anything else from me I'll grab something to eat)

nikomatsakis (Oct 10 2019 at 18:21, on Zulip):

go eat :croissant:

Santiago Pastorino (Oct 10 2019 at 18:21, on Zulip):

thanks @Pietro Albini

nikomatsakis (Oct 10 2019 at 18:21, on Zulip):

@Santiago Pastorino r? https://github.com/rust-lang/rustc-guide/pull/463

nikomatsakis (Oct 10 2019 at 18:22, on Zulip):

and then I can create the blog post

Santiago Pastorino (Oct 10 2019 at 18:22, on Zulip):

looks good

nikomatsakis (Oct 10 2019 at 18:22, on Zulip):

and I guess we are .. good to go?

nikomatsakis (Oct 10 2019 at 18:22, on Zulip):

we should probably tag an issue or two :)

Santiago Pastorino (Oct 10 2019 at 18:22, on Zulip):

as soon as the CI allows me I can merge

nikomatsakis (Oct 10 2019 at 18:22, on Zulip):

and yeah we need the infra stuff to ping people

Santiago Pastorino (Oct 10 2019 at 18:23, on Zulip):

yes, for now that would be done manually

nikomatsakis (Oct 10 2019 at 18:23, on Zulip):

though I don't know that we have to block on that

Santiago Pastorino (Oct 10 2019 at 18:24, on Zulip):

the build errored, probably it's already red, I don't see how your PR make things wrong

Santiago Pastorino (Oct 10 2019 at 18:24, on Zulip):

checking

Santiago Pastorino (Oct 10 2019 at 18:24, on Zulip):

ahh yes

Santiago Pastorino (Oct 10 2019 at 18:24, on Zulip):

line length

Santiago Pastorino (Oct 10 2019 at 18:24, on Zulip):

max 100

nikomatsakis (Oct 10 2019 at 18:25, on Zulip):

sigh

nikomatsakis (Oct 10 2019 at 18:26, on Zulip):

I have a vague fear that people will associate "ICE-breakers" with ICE the government agency

Santiago Pastorino (Oct 10 2019 at 18:28, on Zulip):

hehehe

Santiago Pastorino (Oct 10 2019 at 18:28, on Zulip):

here ICE is meaningless :)

Santiago Pastorino (Oct 10 2019 at 18:28, on Zulip):

I've updated https://github.com/rust-lang/triagebot/issues/169

Santiago Pastorino (Oct 10 2019 at 18:28, on Zulip):

merged https://github.com/rust-lang/rustc-guide/pull/463

nikomatsakis (Oct 10 2019 at 18:30, on Zulip):

Well this is very exciting :)

nikomatsakis (Oct 10 2019 at 18:30, on Zulip):

OK I opened https://github.com/rust-lang/blog.rust-lang.org/pull/417

nikomatsakis (Oct 10 2019 at 18:31, on Zulip):

I should run to lang team pre-triage

Santiago Pastorino (Oct 10 2019 at 18:31, on Zulip):

gonna review that, go go, talk to you later

simulacrum (Oct 10 2019 at 18:40, on Zulip):

Presuming no blockers to implementing the changes probably a couple hours of work - maybe a day or two

simulacrum (Oct 10 2019 at 18:54, on Zulip):

oh, this was the wrong thread to reply to I think

simulacrum (Oct 10 2019 at 18:54, on Zulip):

anyway that holds true here as well

Last update: Nov 11 2019 at 22:00UTC