Hey @T-compiler/WG-meta :wave:
So I think a lot has happened but I've not caught up
In particular I guess the LLVM ICE-breaker signup is basically ready to go?
yeah, @Pietro Albini delegated the one about the team to you :)
I just have to merge https://github.com/rust-lang/team/pull/123 ?
can you make "template PRs" in GH?
there's the setup work, the code to support Marker teams and the other one is adding the actual icebreakers-llvm with nagisa and nikic as leads
i.e., if we wanted to say "to add yourself to the team, do this"
could we link to some "template PR" like you have an issue template?
I don't think so
@nikomatsakis it wouldn't be possible
I guess not
but I guess you can point to the file in questions and say add your name here :)
yeah it's fine
to add yourself to the team repo you have to insert your github id
ah, hmm, yeah
ok so we have to write-up the instructions properly
yeah, it kinda sucks
you have to do two things basically, right?
cargo runsome command?
people can also edit the file using github UI
it would be nice to get some sort of self-service dashboard that you log into with oauth and it prepares the PR for you
ahh right, they need to add themselves to people/
(which could be extended to automate other stuff for team members)
but I guess people would have to develop it
people can run the command for now
or they can open a PR and I will run the command for them
ok I merged https://github.com/rust-lang/team/pull/123
wouldn't make sense to support people only in this kind of teams to not be on people directory?
cargo run add-person username
@Santiago Pastorino no, we need the github id for security reasons
I wonder if we could get rid of 2 for these teams
@Pietro Albini steps 2 and 3 can be done in any order, right?
Santiago Pastorino no, we need the github id for security reasons
hmm but why? what's the security concern in this case?
the issue is we can't rely on the github username for any integration, as people can change their username and anyone can claim the old one
I mean, remember that the names here are only for triagebot to ping them when there's an issue
@Pietro Albini also, is this a good example? everything look right?
the worst that can happen is that if there's somebody in a group and change their name we may end pinging the wrong person
I'm just going to close the PR since I don't actually want me name on there, but then I can link to it as an example
@nikomatsakis tweaked the text a bit
@Santiago Pastorino I really don't want to add exceptions for this rule, all the integrations rely on the github id being present
if we were creating a fake PR like this for people don't we want to create it for a non member user?
the steps are the same, I think? except they have to run the command
shrugs the file is auto-generated anyway
like why don't you use john_doe ...
well ok :)
anyway, the question is ... if people do not figure out, do they deserve to be part of team? :joy:
with this in place I can ping @simulacrum about the bot
(if y'all don't need anything else from me I'll grab something to eat)
go eat :croissant:
thanks @Pietro Albini
@Santiago Pastorino r? https://github.com/rust-lang/rustc-guide/pull/463
and then I can create the blog post
and I guess we are .. good to go?
we should probably tag an issue or two :)
as soon as the CI allows me I can merge
and yeah we need the infra stuff to ping people
yes, for now that would be done manually
though I don't know that we have to block on that
the build errored, probably it's already red, I don't see how your PR make things wrong
I have a vague fear that people will associate "ICE-breakers" with ICE the government agency
here ICE is meaningless :)
I've updated https://github.com/rust-lang/triagebot/issues/169
Well this is very exciting :)
I should run to lang team pre-triage
gonna review that, go go, talk to you later
Presuming no blockers to implementing the changes probably a couple hours of work - maybe a day or two
oh, this was the wrong thread to reply to I think
anyway that holds true here as well